All of lore.kernel.org
 help / color / mirror / Atom feed
From: Murphy Zhou <jencce.kernel@gmail.com>
To: linux-ext4@vger.kernel.org, fstests@vger.kernel.org
Subject: ext4 dio RWF_NOWAIT change
Date: Wed, 5 Feb 2020 17:13:44 +0800	[thread overview]
Message-ID: <20200205091344.u5c3nnblezzh5xgb@xzhoux.usersys.redhat.com> (raw)

Hi,

Kernel commit 378f32bab3714f04c4e0c3aee4129f6703805550
Author: Matthew Bobrowski <mbobrowski@mbobrowski.org>
Date:   Tue Nov 5 23:02:39 2019 +1100

    ext4: introduce direct I/O write using iomap infrastructure


Changed the logic of dio+RWF_NOWAIT

from:

-       if (!inode_trylock(inode)) {
-               if (iocb->ki_flags & IOCB_NOWAIT)
-                       return -EAGAIN;
-               inode_lock(inode);
-       }


to:

+       if (iocb->ki_flags & IOCB_NOWAIT) {
+               if (!inode_trylock(inode))
+                       return -EAGAIN;
+       } else {
+               inode_lock(inode);
+       }


fstests generic/471 expecet EAGAIN on this situation, so it started to
fail since than.

The current logic is similar with other filesystems, but only ext4 fails
on geneirc/471.

Any thoughts how to fix this?

Thanks,
Murphy

             reply	other threads:[~2020-02-05  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05  9:13 Murphy Zhou [this message]
2020-02-07 15:38 ` ext4 dio RWF_NOWAIT change Theodore Y. Ts'o
2020-02-12 10:50   ` Murphy Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200205091344.u5c3nnblezzh5xgb@xzhoux.usersys.redhat.com \
    --to=jencce.kernel@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.