From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F920C35254 for ; Wed, 5 Feb 2020 13:50:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E709120702 for ; Wed, 5 Feb 2020 13:50:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EtvVsh1T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbgBENuy (ORCPT ); Wed, 5 Feb 2020 08:50:54 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:27957 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726822AbgBENuy (ORCPT ); Wed, 5 Feb 2020 08:50:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580910652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GGAQOrIpQIhMs3J8XUYBIl+EiMIkUVPiFf/XyrmfzK0=; b=EtvVsh1TcwsRQltKKdo0f9K0rWNzUG38ItDybBN8ohCWOTBojBDEKzCTpVioczScRdTmGM 1MPw1Z+L3mn/rsRomliIOHPjeBdDOns+LZrnUmkzstx09Lvvvlf5et4ixzanL/1+Qlx0lQ /AlASQFgQGc2JR+Ux42GvC7+driilT8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-cQy2GUdlPbmAYAsd37YIhQ-1; Wed, 05 Feb 2020 08:50:48 -0500 X-MC-Unique: cQy2GUdlPbmAYAsd37YIhQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5BCA7800D54; Wed, 5 Feb 2020 13:50:47 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34F248CCC5; Wed, 5 Feb 2020 13:50:43 +0000 (UTC) Date: Wed, 5 Feb 2020 14:50:40 +0100 From: Cornelia Huck To: Christian Borntraeger Cc: Janosch Frank , KVM , David Hildenbrand , Thomas Huth , Ulrich Weigand , Claudio Imbrenda , Andrea Arcangeli Subject: Re: [RFCv2 19/37] KVM: s390: protvirt: Handle spec exception loops Message-ID: <20200205145040.4ed01a13.cohuck@redhat.com> In-Reply-To: <20200203131957.383915-20-borntraeger@de.ibm.com> References: <20200203131957.383915-1-borntraeger@de.ibm.com> <20200203131957.383915-20-borntraeger@de.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 3 Feb 2020 08:19:39 -0500 Christian Borntraeger wrote: > From: Janosch Frank > > SIE intercept code 8 is used only on exception loops for protected > guests. That means we need stop the guest when we see it. s/need stop/need to stop/ ...which is a task done by userspace? > > Signed-off-by: Janosch Frank > Reviewed-by: Thomas Huth > --- > arch/s390/kvm/intercept.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/s390/kvm/intercept.c b/arch/s390/kvm/intercept.c > index c22214967214..d63f9cf10360 100644 > --- a/arch/s390/kvm/intercept.c > +++ b/arch/s390/kvm/intercept.c > @@ -231,6 +231,13 @@ static int handle_prog(struct kvm_vcpu *vcpu) > > vcpu->stat.exit_program_interruption++; > > + /* > + * Intercept 8 indicates a loop of specification exceptions > + * for protected guests s/guests/guests./ > + */ > + if (kvm_s390_pv_is_protected(vcpu->kvm)) > + return -EOPNOTSUPP; > + > if (guestdbg_enabled(vcpu) && per_event(vcpu)) { > rc = kvm_s390_handle_per_event(vcpu); > if (rc) Reviewed-by: Cornelia Huck