All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] package/erlang: bump to version 22.2
Date: Wed, 5 Feb 2020 15:42:26 +0100	[thread overview]
Message-ID: <20200205154226.0dca67b1@windsurf> (raw)
In-Reply-To: <20200204100733.22106-1-frank.vanbever@essensium.com>

Hello Frank,

I've applied your patch, but with some changes. See below.

On Tue,  4 Feb 2020 11:07:31 +0100
Frank Vanbever <frank.vanbever@essensium.com> wrote:

>  # See note below when updating Erlang
> -ERLANG_VERSION = 21.0
> +ERLANG_VERSION = 22.2
>  ERLANG_SITE = http://www.erlang.org/download
>  ERLANG_SOURCE = otp_src_$(ERLANG_VERSION).tar.gz
>  ERLANG_DEPENDENCIES = host-erlang
> @@ -15,11 +15,20 @@ ERLANG_LICENSE_FILES = LICENSE.txt
>  ERLANG_INSTALL_STAGING = YES
>  
>  # Patched erts/aclocal.m4
> -ERLANG_AUTORECONF = YES
> +define ERLANG_RUN_AUTOCONF
> +	cd $(@D) && PATH=$(BR_PATH) ./otp_build autoconf
> +endef
> +HOST_ERLANG_DEPENDENCIES = host-autoconf
> +ERLANG_PRE_CONFIGURE_HOOKS += ERLANG_RUN_AUTOCONF

ERLANG_AUTORECONF = YES does the thing for both the host and target
packages.

However here, you are adding host-autoconf as a dependency for
host-erlang, but you're doing the autoconf only on the target erlang.
So I fixed that to ensure we add host-autoconf to both target/host
variants of erlang (which is pedantic since anyway erlang depends on
host-erlang) and do the autoconf on both host and target.

> +define ERLANG_RUN_SAVE_BOOTSTRAP
> +	cd $(@D) && PATH=$(BR_PATH) ./otp_build save_bootstrap
> +endef
> +ERLANG_POST_CONFIGURE_HOOKS += ERLANG_RUN_SAVE_BOOTSTRAP

As we discussed, this does not seem to be needed, at least from my
testing, so I dropped this.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2020-02-05 14:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 17:26 [Buildroot] [PATCH 1/3] package/erlang: bump to version 22.2 Frank Vanbever
2020-01-29 17:26 ` [Buildroot] [PATCH 2/3] package/elixir: new package Frank Vanbever
2020-02-01 22:02   ` Thomas Petazzoni
2020-01-29 17:26 ` [Buildroot] [PATCH 3/3] package/rabbitmq-server: bump version to 3.8.2 Frank Vanbever
2020-02-01 21:59   ` Thomas Petazzoni
2020-02-01 21:57 ` [Buildroot] [PATCH 1/3] package/erlang: bump to version 22.2 Thomas Petazzoni
2020-02-04 10:07 ` [Buildroot] [PATCH v2 " Frank Vanbever
2020-02-04 10:07   ` [Buildroot] [PATCH v2 2/3] package/elixir: new package Frank Vanbever
2020-02-05 14:42     ` Thomas Petazzoni
2020-02-04 10:07   ` [Buildroot] [PATCH v2 3/3] package/rabbitmq-server: bump version to 3.8.2 Frank Vanbever
2020-02-05 14:47     ` Thomas Petazzoni
2020-02-13 15:14     ` [Buildroot] [PATCH v3 1/2] package/rabbitmq-server: clean up license list Frank Vanbever
2020-02-13 15:14       ` [Buildroot] [PATCH v3 2/2] package/rabbitmq-server: bump version to 3.8.2 Frank Vanbever
2020-04-12 19:33         ` Thomas Petazzoni
2020-04-12 19:33       ` [Buildroot] [PATCH v3 1/2] package/rabbitmq-server: clean up license list Thomas Petazzoni
2020-02-05  9:37   ` [Buildroot] [PATCH v2 1/3] package/erlang: bump to version 22.2 Thomas Petazzoni
2020-02-05 11:15     ` Frank Vanbever
2020-02-05 14:42   ` Thomas Petazzoni [this message]
2020-02-10 13:28     ` Johan Oudinet
2020-02-10 13:30       ` Thomas Petazzoni
2020-02-10 15:20         ` Johan Oudinet
2020-02-10 15:27           ` Johan Oudinet
2020-02-10 15:51             ` Johan Oudinet
2020-02-10 15:57               ` Thomas Petazzoni
2020-02-10 16:07                 ` Johan Oudinet
2020-02-10 16:48                   ` Johan Oudinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200205154226.0dca67b1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.