From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A4A5C35247 for ; Wed, 5 Feb 2020 18:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D70E217F4 for ; Wed, 5 Feb 2020 18:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbgBESez (ORCPT ); Wed, 5 Feb 2020 13:34:55 -0500 Received: from foss.arm.com ([217.140.110.172]:50984 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbgBESez (ORCPT ); Wed, 5 Feb 2020 13:34:55 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65A031FB; Wed, 5 Feb 2020 10:34:54 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C6FA3F52E; Wed, 5 Feb 2020 10:34:53 -0800 (PST) Date: Wed, 5 Feb 2020 18:34:50 +0000 From: Andre Przywara To: Alexandru Elisei Cc: kvm@vger.kernel.org, will@kernel.org, julien.thierry.kdev@gmail.com, sami.mujawar@arm.com, lorenzo.pieralisi@arm.com, maz@kernel.org Subject: Re: [PATCH v2 kvmtool 23/30] vfio: Reserve ioports when configuring the BAR Message-ID: <20200205183450.70160ed2@donnerap.cambridge.arm.com> In-Reply-To: <20200123134805.1993-24-alexandru.elisei@arm.com> References: <20200123134805.1993-1-alexandru.elisei@arm.com> <20200123134805.1993-24-alexandru.elisei@arm.com> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 23 Jan 2020 13:47:58 +0000 Alexandru Elisei wrote: Hi, > Let's be consistent and reserve ioports when we are configuring the BAR, > not when we map it, just like we do with mmio regions. > > Signed-off-by: Alexandru Elisei Reviewed-by: Andre Przywara Thanks, Andre > --- > vfio/core.c | 9 +++------ > vfio/pci.c | 4 +++- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/vfio/core.c b/vfio/core.c > index 73fdac8be675..6b9b58ea8d2f 100644 > --- a/vfio/core.c > +++ b/vfio/core.c > @@ -202,14 +202,11 @@ static int vfio_setup_trap_region(struct kvm *kvm, struct vfio_device *vdev, > struct vfio_region *region) > { > if (region->is_ioport) { > - int port = pci_get_io_port_block(region->info.size); > - > - port = ioport__register(kvm, port, &vfio_ioport_ops, > - region->info.size, region); > + int port = ioport__register(kvm, region->port_base, > + &vfio_ioport_ops, region->info.size, > + region); > if (port < 0) > return port; > - > - region->port_base = port; > return 0; > } > > diff --git a/vfio/pci.c b/vfio/pci.c > index f86a7d9b7032..abde16dc8693 100644 > --- a/vfio/pci.c > +++ b/vfio/pci.c > @@ -885,7 +885,9 @@ static int vfio_pci_configure_bar(struct kvm *kvm, struct vfio_device *vdev, > } > } > > - if (!region->is_ioport) { > + if (region->is_ioport) { > + region->port_base = pci_get_io_port_block(region->info.size); > + } else { > /* Grab some MMIO space in the guest */ > map_size = ALIGN(region->info.size, PAGE_SIZE); > region->guest_phys_addr = pci_get_mmio_block(map_size);