From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD236C2D0B1 for ; Thu, 6 Feb 2020 13:45:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A366421741 for ; Thu, 6 Feb 2020 13:45:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BINwRiA9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbgBFNpW (ORCPT ); Thu, 6 Feb 2020 08:45:22 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:33705 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727509AbgBFNpV (ORCPT ); Thu, 6 Feb 2020 08:45:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580996720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDU1pecxlc+BOyhBmEht8Gi+UsDhBE70bSJ3aCURxjY=; b=BINwRiA955dn+mQmP5Yzz/eHLrv1JZ17Wmy7/cGbr0CMDtE2lORWkr+c/GIofGkI4m7/W4 albqPN0qG5tgRQfOQfyFM/DKhQwz1P4jiXmiPKkJ41WIlthe4ZwVPmwoz/ankKLjuMp0Sj 4N9dokfZfQVdVzC6HGuyBmby4jYQ4FQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-_j4sQ72kNc6cDjhpHwN4kA-1; Thu, 06 Feb 2020 08:45:16 -0500 X-MC-Unique: _j4sQ72kNc6cDjhpHwN4kA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 059468024DB; Thu, 6 Feb 2020 13:45:15 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1BE484DB4; Thu, 6 Feb 2020 13:45:09 +0000 (UTC) Date: Thu, 6 Feb 2020 14:45:06 +0100 From: Cornelia Huck To: Alex Williamson Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dev@dpdk.org, mtosatti@redhat.com, thomas@monjalon.net, bluca@debian.org, jerinjacobk@gmail.com, bruce.richardson@intel.com Subject: Re: [RFC PATCH 6/7] vfio/pci: Remove dev_fmt definition Message-ID: <20200206144506.178ba10a.cohuck@redhat.com> In-Reply-To: <158085758432.9445.12129266614127683867.stgit@gimli.home> References: <158085337582.9445.17682266437583505502.stgit@gimli.home> <158085758432.9445.12129266614127683867.stgit@gimli.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Feb 2020 16:06:24 -0700 Alex Williamson wrote: > It currently results in messages like: > > "vfio-pci 0000:03:00.0: vfio_pci: ..." > > Which is quite a bit redundant. > > Signed-off-by: Alex Williamson > --- > drivers/vfio/pci/vfio_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c > index 026308aa18b5..343fe38ed06b 100644 > --- a/drivers/vfio/pci/vfio_pci.c > +++ b/drivers/vfio/pci/vfio_pci.c > @@ -9,7 +9,6 @@ > */ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > -#define dev_fmt pr_fmt > > #include > #include > Yes, that looks a bit superfluous. Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DD8C2D0B1 for ; Thu, 6 Feb 2020 13:45:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D7FB921775 for ; Thu, 6 Feb 2020 13:45:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BINwRiA9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7FB921775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CE791C0BC; Thu, 6 Feb 2020 14:45:23 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 4DF7B1C0B2 for ; Thu, 6 Feb 2020 14:45:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580996720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDU1pecxlc+BOyhBmEht8Gi+UsDhBE70bSJ3aCURxjY=; b=BINwRiA955dn+mQmP5Yzz/eHLrv1JZ17Wmy7/cGbr0CMDtE2lORWkr+c/GIofGkI4m7/W4 albqPN0qG5tgRQfOQfyFM/DKhQwz1P4jiXmiPKkJ41WIlthe4ZwVPmwoz/ankKLjuMp0Sj 4N9dokfZfQVdVzC6HGuyBmby4jYQ4FQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-_j4sQ72kNc6cDjhpHwN4kA-1; Thu, 06 Feb 2020 08:45:16 -0500 X-MC-Unique: _j4sQ72kNc6cDjhpHwN4kA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 059468024DB; Thu, 6 Feb 2020 13:45:15 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1BE484DB4; Thu, 6 Feb 2020 13:45:09 +0000 (UTC) Date: Thu, 6 Feb 2020 14:45:06 +0100 From: Cornelia Huck To: Alex Williamson Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dev@dpdk.org, mtosatti@redhat.com, thomas@monjalon.net, bluca@debian.org, jerinjacobk@gmail.com, bruce.richardson@intel.com Message-ID: <20200206144506.178ba10a.cohuck@redhat.com> In-Reply-To: <158085758432.9445.12129266614127683867.stgit@gimli.home> References: <158085337582.9445.17682266437583505502.stgit@gimli.home> <158085758432.9445.12129266614127683867.stgit@gimli.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Subject: Re: [dpdk-dev] [RFC PATCH 6/7] vfio/pci: Remove dev_fmt definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 04 Feb 2020 16:06:24 -0700 Alex Williamson wrote: > It currently results in messages like: > > "vfio-pci 0000:03:00.0: vfio_pci: ..." > > Which is quite a bit redundant. > > Signed-off-by: Alex Williamson > --- > drivers/vfio/pci/vfio_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c > index 026308aa18b5..343fe38ed06b 100644 > --- a/drivers/vfio/pci/vfio_pci.c > +++ b/drivers/vfio/pci/vfio_pci.c > @@ -9,7 +9,6 @@ > */ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > -#define dev_fmt pr_fmt > > #include > #include > Yes, that looks a bit superfluous. Reviewed-by: Cornelia Huck