mesh: Missing API for delivering provisioning public key via OOB?

mesh: Missing API for delivering provisioning public key via OOB?

[Michał Lowas-Rzechonek]

Hi,

I have been playing with mesh-cfgclient, and I've noticed that
provisioning procedure gets stuck when node reports Public Key OOB
information available' in 'Public Key Type' field of Provisioning
Capabilities PDU.

While digging into the code and API, I think we have a missing feature
in the API between provisioner application and the daemon - while there
is an API to deliver OOB keys to the daemon when *the application* is
being provisioned, there doesn't seem to be a way to deliver provisioned
device's public key when is the application who does the provisioning.

Is my understanding correct, or is there something I've missed?

regards
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND

Re: mesh: Missing API for delivering provisioning public key via OOB?

[Gix, Brian]

Hi Michał,

On Thu, 2020-02-06 at 18:16 +0100, Michał Lowas-Rzechonek wrote:
> Hi,
> 
> I have been playing with mesh-cfgclient, and I've noticed that
> provisioning procedure gets stuck when node reports Public Key OOB
> information available' in 'Public Key Type' field of Provisioning
> Capabilities PDU.
> 
> While digging into the code and API, I think we have a missing feature
> in the API between provisioner application and the daemon - while there
> is an API to deliver OOB keys to the daemon when *the application* is
> being provisioned, there doesn't seem to be a way to deliver provisioned
> device's public key when is the application who does the provisioning.
> 
> Is my understanding correct, or is there something I've missed?

Yes... It looks like tools/mesh-cfgclient.c needs to implement the:

	array{byte} PublicKey()

method.

This is a good catch, and needs to be added.  

> 
> regards

Re: mesh: Missing API for delivering provisioning public key via OOB?

[Gix, Brian]

On Thu, 2020-02-06 at 17:25 +0000, Gix, Brian wrote:
> Hi Michał,
> 
> On Thu, 2020-02-06 at 18:16 +0100, Michał Lowas-Rzechonek wrote:
> > Hi,
> > 
> > I have been playing with mesh-cfgclient, and I've noticed that
> > provisioning procedure gets stuck when node reports Public Key OOB
> > information available' in 'Public Key Type' field of Provisioning
> > Capabilities PDU.
> > 
> > While digging into the code and API, I think we have a missing feature
> > in the API between provisioner application and the daemon - while there
> > is an API to deliver OOB keys to the daemon when *the application* is
> > being provisioned, there doesn't seem to be a way to deliver provisioned
> > device's public key when is the application who does the provisioning.
> > 
> > Is my understanding correct, or is there something I've missed?
> 
> Yes... It looks like tools/mesh-cfgclient.c needs to implement the:
> 
> 	array{byte} PublicKey()
> 
> method.
> 
> This is a good catch, and needs to be added.

And before you respond, yes it also needs to be added to mesh/agent.c


>   
> 
> > regards

Re: mesh: Missing API for delivering provisioning public key via OOB?

[michal.lowas-rzechonek]

Brian,

On 02/06, Gix, Brian wrote:
> > Is my understanding correct, or is there something I've missed?
> Yes... It looks like tools/mesh-cfgclient.c needs to implement the:
> 
> 	array{byte} PublicKey()
> 
> method.
> 
> This is a good catch, and needs to be added.  

Ok, thanks. I'll give it a shot, if time permits.

What puzzled me is that the provisioning gets stuck instead of failing,
so it seems it's not only that cfgclient doesn't implement the method,
but also the daemon doesn't seem to check for errors?

-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND