All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
	syzkaller@googlegroups.com, maximmi@mellanox.com
Subject: Re: [PATCH net] ipv6/addrconf: fix potential NULL deref in inet6_set_link_af()
Date: Fri, 07 Feb 2020 10:36:05 +0100 (CET)	[thread overview]
Message-ID: <20200207.103605.2059545131045029032.davem@davemloft.net> (raw)
In-Reply-To: <CANn89iLb-OcdVCV+qNH7BEUjw3KtEPhhOM_XUyyJaWbhA5=dQw@mail.gmail.com>

From: Eric Dumazet <edumazet@google.com>
Date: Thu, 6 Feb 2020 18:50:40 -0800

> If I understood the repro well enough, it seems it sets the device MTU
> to 1023, thus IPV6 is automatically disabled. (as mtu < 1280)

Now I understand.

Can you add some text about this to the commit message?  Just saying
that if the request also lowers the mtu below the ipv6 min mtu then we
will see the NULL idev.

Thanks.

      reply	other threads:[~2020-02-07  9:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 16:55 [PATCH net] ipv6/addrconf: fix potential NULL deref in inet6_set_link_af() Eric Dumazet
2020-02-06 13:13 ` David Miller
2020-02-06 15:18   ` Eric Dumazet
2020-02-07  2:50     ` Eric Dumazet
2020-02-07  9:36       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200207.103605.2059545131045029032.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=maximmi@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=syzkaller@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.