From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E0DC352A2 for ; Fri, 7 Feb 2020 10:08:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3148E20838 for ; Fri, 7 Feb 2020 10:08:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ND2emrhh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbgBGKIC (ORCPT ); Fri, 7 Feb 2020 05:08:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:51578 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726642AbgBGKIB (ORCPT ); Fri, 7 Feb 2020 05:08:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581070079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hww+G4VML7m0WisANEdJ/P2iFS+sF+6xCl9lSHHOIXI=; b=ND2emrhhWdclIrzzkkZ7bQ/od9ewgpblRhGHLi3pbk/92EsZScNfuyW9mIaY81/vgutucW b/gR+TcGEoyet2Mynk2bGx0k/Q/9UV+8VEr7bJp4WRiZgt003KxQPl/5gjaNxegdFjsBi/ ZNb7m9i6Rs4c+3c9nOpHWJsP2ZRVHO8= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-gxe41Z6nNtyoaf1G2NYXmA-1; Fri, 07 Feb 2020 05:07:57 -0500 X-MC-Unique: gxe41Z6nNtyoaf1G2NYXmA-1 Received: by mail-qv1-f72.google.com with SMTP id e10so816558qvq.18 for ; Fri, 07 Feb 2020 02:07:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hww+G4VML7m0WisANEdJ/P2iFS+sF+6xCl9lSHHOIXI=; b=fWKG8IylSwxb0EulorzTMu35Dq0kxWBQE0hOeYJAtAb6cEHQ3LHsQAKxKeYgC5lA/G fX7ewpLic7GxyBZ0MbyWYUM1u4nzNmpy+zqnEp7GQPGxRXOYblzHGVb64YGkItECzv72 aLarcz45xjN8IDLMAjrKyUJZ9tKZghdtcqG2BSbd4LiVX2/+EhnvsrQerR4JC/7gcPKS O57KedTH3YiQ3nBPxMwrt8ssMQXORdisk6n6sgaPinD+Ykv0kjVjlk+yEIqboAbl6yZc wRget9wOLamip7j2VwLS1KKsGFKx7wbsFaUetgM8wvn7y5oMlibND/bS+LD1Y473ti5v 1QVw== X-Gm-Message-State: APjAAAUYqRcIAQuz+v8tDKfDF2ebS2/cL5NwgastLaZN/EP3qTYIvav2 qWPITRcCIh8rKVcxm2mlas7aCRJhKqJKumBlMDJfeM9yQfNvXz/Rfgr+XuDLpGj4Olbylu+y1kq X2n/pvSoQUdQLLcjvZ/YqnuaG X-Received: by 2002:a37:d8e:: with SMTP id 136mr6565030qkn.293.1581070076413; Fri, 07 Feb 2020 02:07:56 -0800 (PST) X-Google-Smtp-Source: APXvYqx2Tf4Dc3I9vhEU7wQz4PfOE2roZy7Xvp6VWxn/M6XGCbLGhkv3J1M03O/Eb7Fbru/j5RsZlQ== X-Received: by 2002:a37:d8e:: with SMTP id 136mr6565001qkn.293.1581070076110; Fri, 07 Feb 2020 02:07:56 -0800 (PST) Received: from redhat.com (bzq-79-176-41-183.red.bezeqint.net. [79.176.41.183]) by smtp.gmail.com with ESMTPSA id g6sm1052150qki.100.2020.02.07.02.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2020 02:07:55 -0800 (PST) Date: Fri, 7 Feb 2020 05:07:50 -0500 From: "Michael S. Tsirkin" To: Cornelia Huck Cc: Christian Borntraeger , eperezma@redhat.com, "virtualization@lists.linux-foundation.org" , Stephen Rothwell , Linux Next Mailing List , "linux-kernel@vger.kernel.org" , kvm list , Halil Pasic Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot Message-ID: <20200207050731-mutt-send-email-mst@kernel.org> References: <20200120012724-mutt-send-email-mst@kernel.org> <2a63b15f-8cf5-5868-550c-42e2cfd92c60@de.ibm.com> <1ade56b5-083f-bb6f-d3e0-3ddcf78f4d26@de.ibm.com> <20200206171349-mutt-send-email-mst@kernel.org> <5c860fa1-cef5-b389-4ebf-99a62afa0fe8@de.ibm.com> <20200207025806-mutt-send-email-mst@kernel.org> <97c93d38-ef07-e321-d133-18483d54c0c0@de.ibm.com> <20200207095353.08bc91e4.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200207095353.08bc91e4.cohuck@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 07, 2020 at 09:53:53AM +0100, Cornelia Huck wrote: > On Fri, 7 Feb 2020 09:13:14 +0100 > Christian Borntraeger wrote: > > > On 07.02.20 08:58, Michael S. Tsirkin wrote: > > > On Fri, Feb 07, 2020 at 08:47:14AM +0100, Christian Borntraeger wrote: > > >> Also adding Cornelia. > > >> > > >> > > >> On 06.02.20 23:17, Michael S. Tsirkin wrote: > > >>> On Thu, Feb 06, 2020 at 04:12:21PM +0100, Christian Borntraeger wrote: > > >>>> > > >>>> > > >>>> On 06.02.20 15:22, eperezma@redhat.com wrote: > > >>>>> Hi Christian. > > >>>>> > > >>>>> Could you try this patch on top of ("38ced0208491 vhost: use batched version by default")? > > >>>>> > > >>>>> It will not solve your first random crash but it should help with the lost of network connectivity. > > >>>>> > > >>>>> Please let me know how does it goes. > > >>>> > > >>>> > > >>>> 38ced0208491 + this seem to be ok. > > >>>> > > >>>> Not sure if you can make out anything of this (and the previous git bisect log) > > >>> > > >>> Yes it does - that this is just bad split-up of patches, and there's > > >>> still a real bug that caused worse crashes :) > > >>> > > >>> So I just pushed batch-v4. > > >>> I expect that will fail, and bisect to give us > > >>> vhost: batching fetches > > >>> Can you try that please? > > >>> > > >> > > >> yes. > > >> > > >> eccb852f1fe6bede630e2e4f1a121a81e34354ab is the first bad commit > > >> commit eccb852f1fe6bede630e2e4f1a121a81e34354ab > > >> Author: Michael S. Tsirkin > > >> Date: Mon Oct 7 06:11:18 2019 -0400 > > >> > > >> vhost: batching fetches > > >> > > >> With this patch applied, new and old code perform identically. > > >> > > >> Lots of extra optimizations are now possible, e.g. > > >> we can fetch multiple heads with copy_from/to_user now. > > >> We can get rid of maintaining the log array. Etc etc. > > >> > > >> Signed-off-by: Michael S. Tsirkin > > >> > > >> drivers/vhost/test.c | 2 +- > > >> drivers/vhost/vhost.c | 39 ++++++++++++++++++++++++++++++++++----- > > >> drivers/vhost/vhost.h | 4 +++- > > >> 3 files changed, 38 insertions(+), 7 deletions(-) > > >> > > > > > > > > > And the symptom is still the same - random crashes > > > after a bit of traffic, right? > > > > random guest crashes after a reboot of the guests. As if vhost would still > > write into now stale buffers. > > > > I'm late to the party; but where is that commit located? Or has it been > dropped again already? my vhost tree. Tag batch-v4. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot Date: Fri, 7 Feb 2020 05:07:50 -0500 Message-ID: <20200207050731-mutt-send-email-mst@kernel.org> References: <20200120012724-mutt-send-email-mst@kernel.org> <2a63b15f-8cf5-5868-550c-42e2cfd92c60@de.ibm.com> <1ade56b5-083f-bb6f-d3e0-3ddcf78f4d26@de.ibm.com> <20200206171349-mutt-send-email-mst@kernel.org> <5c860fa1-cef5-b389-4ebf-99a62afa0fe8@de.ibm.com> <20200207025806-mutt-send-email-mst@kernel.org> <97c93d38-ef07-e321-d133-18483d54c0c0@de.ibm.com> <20200207095353.08bc91e4.cohuck@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200207095353.08bc91e4.cohuck@redhat.com> Sender: kvm-owner@vger.kernel.org To: Cornelia Huck Cc: Christian Borntraeger , eperezma@redhat.com, "virtualization@lists.linux-foundation.org" , Stephen Rothwell , Linux Next Mailing List , "linux-kernel@vger.kernel.org" , kvm list , Halil Pasic List-Id: virtualization@lists.linuxfoundation.org On Fri, Feb 07, 2020 at 09:53:53AM +0100, Cornelia Huck wrote: > On Fri, 7 Feb 2020 09:13:14 +0100 > Christian Borntraeger wrote: > > > On 07.02.20 08:58, Michael S. Tsirkin wrote: > > > On Fri, Feb 07, 2020 at 08:47:14AM +0100, Christian Borntraeger wrote: > > >> Also adding Cornelia. > > >> > > >> > > >> On 06.02.20 23:17, Michael S. Tsirkin wrote: > > >>> On Thu, Feb 06, 2020 at 04:12:21PM +0100, Christian Borntraeger wrote: > > >>>> > > >>>> > > >>>> On 06.02.20 15:22, eperezma@redhat.com wrote: > > >>>>> Hi Christian. > > >>>>> > > >>>>> Could you try this patch on top of ("38ced0208491 vhost: use batched version by default")? > > >>>>> > > >>>>> It will not solve your first random crash but it should help with the lost of network connectivity. > > >>>>> > > >>>>> Please let me know how does it goes. > > >>>> > > >>>> > > >>>> 38ced0208491 + this seem to be ok. > > >>>> > > >>>> Not sure if you can make out anything of this (and the previous git bisect log) > > >>> > > >>> Yes it does - that this is just bad split-up of patches, and there's > > >>> still a real bug that caused worse crashes :) > > >>> > > >>> So I just pushed batch-v4. > > >>> I expect that will fail, and bisect to give us > > >>> vhost: batching fetches > > >>> Can you try that please? > > >>> > > >> > > >> yes. > > >> > > >> eccb852f1fe6bede630e2e4f1a121a81e34354ab is the first bad commit > > >> commit eccb852f1fe6bede630e2e4f1a121a81e34354ab > > >> Author: Michael S. Tsirkin > > >> Date: Mon Oct 7 06:11:18 2019 -0400 > > >> > > >> vhost: batching fetches > > >> > > >> With this patch applied, new and old code perform identically. > > >> > > >> Lots of extra optimizations are now possible, e.g. > > >> we can fetch multiple heads with copy_from/to_user now. > > >> We can get rid of maintaining the log array. Etc etc. > > >> > > >> Signed-off-by: Michael S. Tsirkin > > >> > > >> drivers/vhost/test.c | 2 +- > > >> drivers/vhost/vhost.c | 39 ++++++++++++++++++++++++++++++++++----- > > >> drivers/vhost/vhost.h | 4 +++- > > >> 3 files changed, 38 insertions(+), 7 deletions(-) > > >> > > > > > > > > > And the symptom is still the same - random crashes > > > after a bit of traffic, right? > > > > random guest crashes after a reboot of the guests. As if vhost would still > > write into now stale buffers. > > > > I'm late to the party; but where is that commit located? Or has it been > dropped again already? my vhost tree. Tag batch-v4.