From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: pierre-louis.bossart@linux.intel.com, broonie@kernel.org,
kai.vehmanen@linux.intel.com, tiwai@suse.de,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] ASoC: SOF: core: release resources on errors in" failed to apply to 5.5-stable tree
Date: Fri, 7 Feb 2020 09:47:41 -0500 [thread overview]
Message-ID: <20200207144741.GV31482@sasha-vm> (raw)
In-Reply-To: <1581065627242228@kroah.com>
On Fri, Feb 07, 2020 at 09:53:47AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.5-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 410e5e55c9c1c9c0d452ac5b9adb37b933a7747e Mon Sep 17 00:00:00 2001
>From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>Date: Fri, 24 Jan 2020 15:36:21 -0600
>Subject: [PATCH] ASoC: SOF: core: release resources on errors in
> probe_continue
>
>The initial intent of releasing resources in the .remove does not work
>well with HDaudio codecs. If the probe_continue() fails in a work
>queue, e.g. due to missing firmware or authentication issues, we don't
>release any resources, and as a result the kernel oopses during
>suspend operations.
>
>The suggested fix is to release all resources during errors in
>probe_continue(), and use fw_state to track resource allocation
>state, so that .remove does not attempt to release the same
>hardware resources twice. PM operations are also modified so that
>no action is done if DSP resources have been freed due to
>an error at probe.
>
>Reported-by: Takashi Iwai <tiwai@suse.de>
>Co-developed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
>Bugzilla: http://bugzilla.suse.com/show_bug.cgi?id=1161246
>Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>Reviewed-by: Takashi Iwai <tiwai@suse.de>
>Link: https://lore.kernel.org/r/20200124213625.30186-4-pierre-louis.bossart@linux.intel.com
>Signed-off-by: Mark Brown <broonie@kernel.org>
>Cc: stable@vger.kernel.org
Conflict due to missing 285880a23d10 ("ASoC: SOF: Make creation of
machine device from SOF core optional") and a "random" space added in
this commit. Cleaned up and queued for 5.5 and 5.4.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-02-07 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 8:53 FAILED: patch "[PATCH] ASoC: SOF: core: release resources on errors in" failed to apply to 5.5-stable tree gregkh
2020-02-07 14:47 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207144741.GV31482@sasha-vm \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.