From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, fw@strlen.de,
netfilter-devel@vger.kernel.org,
syzbot+adf6c6c2be1c3a718121@syzkaller.appspotmail.com,
Jozsef Kadlecsik <kadlec@netfilter.org>
Subject: Re: [Patch nf v2 3/3] xt_hashlimit: limit the max size of hashtable
Date: Fri, 7 Feb 2020 15:56:53 +0100 [thread overview]
Message-ID: <20200207145653.x2sb3kds6butpf6j@salvia> (raw)
In-Reply-To: <20200203043053.19192-4-xiyou.wangcong@gmail.com>
On Sun, Feb 02, 2020 at 08:30:53PM -0800, Cong Wang wrote:
> The user-specified hashtable size is unbound, this could
> easily lead to an OOM or a hung task as we hold the global
> mutex while allocating and initializing the new hashtable.
>
> Add a max value to cap both cfg->size and cfg->max, as
> suggested by Florian.
Also applied, thanks.
prev parent reply other threads:[~2020-02-07 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 4:30 [Patch nf v2 0/3] netfilter: xt_hashlimit: a few improvements Cong Wang
2020-02-03 4:30 ` [Patch nf v2 1/3] xt_hashlimit: avoid OOM for user-controlled vmalloc Cong Wang
2020-02-03 12:16 ` Florian Westphal
2020-02-03 18:54 ` Cong Wang
2020-02-03 20:18 ` Florian Westphal
2020-02-07 14:57 ` Pablo Neira Ayuso
2020-02-03 4:30 ` [Patch nf v2 2/3] xt_hashlimit: reduce hashlimit_mutex scope for htable_put() Cong Wang
2020-02-07 14:54 ` Pablo Neira Ayuso
2020-02-03 4:30 ` [Patch nf v2 3/3] xt_hashlimit: limit the max size of hashtable Cong Wang
2020-02-03 12:06 ` Florian Westphal
2020-02-07 14:56 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207145653.x2sb3kds6butpf6j@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=syzbot+adf6c6c2be1c3a718121@syzkaller.appspotmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.