All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: robert.foley@linaro.org, robhenry@microsoft.com,
	aaron@os.amperecomputing.com, cota@braap.org,
	kuhn.chenqun@huawei.com, peter.puhov@linaro.org,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH  v1 5/5] tests/plugins: make howvec clean-up after itself.
Date: Fri,  7 Feb 2020 15:01:18 +0000	[thread overview]
Message-ID: <20200207150118.23007-6-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200207150118.23007-1-alex.bennee@linaro.org>

TCG plugins are responsible for their own memory usage and although
the plugin_exit is tied to the end of execution in this case it is
still poor practice. Ensure we delete the hash table and related data
when we are done to be a good plugin citizen.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/plugin/howvec.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/plugin/howvec.c b/tests/plugin/howvec.c
index 4ca555e1239..7b77403559d 100644
--- a/tests/plugin/howvec.c
+++ b/tests/plugin/howvec.c
@@ -163,6 +163,13 @@ static gint cmp_exec_count(gconstpointer a, gconstpointer b)
     return ea->count > eb->count ? -1 : 1;
 }
 
+static void free_record(gpointer data)
+{
+    InsnExecCount *rec = (InsnExecCount *) data;
+    g_free(rec->insn);
+    g_free(rec);
+}
+
 static void plugin_exit(qemu_plugin_id_t id, void *p)
 {
     g_autoptr(GString) report = g_string_new("Instruction Classes:\n");
@@ -213,12 +220,15 @@ static void plugin_exit(qemu_plugin_id_t id, void *p)
         g_list_free(it);
     }
 
+    g_list_free(counts);
+    g_hash_table_destroy(insns);
+
     qemu_plugin_outs(report->str);
 }
 
 static void plugin_init(void)
 {
-    insns = g_hash_table_new(NULL, g_direct_equal);
+    insns = g_hash_table_new_full(NULL, g_direct_equal, NULL, &free_record);
 }
 
 static void vcpu_insn_exec_before(unsigned int cpu_index, void *udata)
-- 
2.20.1



  parent reply	other threads:[~2020-02-07 15:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 15:01 [PATCH v1 0/5] plugins/next Alex Bennée
2020-02-07 15:01 ` [PATCH v1 1/5] docs/devel: document query handle lifetimes Alex Bennée
2020-02-07 16:38   ` Robert Foley
2020-02-09 18:20   ` Richard Henderson
2020-02-07 15:01 ` [PATCH v1 2/5] plugins/core: add missing break in cb_to_tcg_flags Alex Bennée
2020-02-11 17:56   ` Richard Henderson
2020-02-07 15:01 ` [PATCH v1 3/5] tests/plugin: prevent uninitialized warning Alex Bennée
2020-02-11 17:57   ` Richard Henderson
2020-02-07 15:01 ` [PATCH v1 4/5] target/riscv: progressively load the instruction during decode Alex Bennée
2020-02-07 15:01   ` Alex Bennée
2020-02-07 16:33   ` Robert Foley
2020-02-07 16:33     ` Robert Foley
2020-02-07 16:47     ` Alex Bennée
2020-02-07 16:47       ` Alex Bennée
2020-02-11 18:00   ` Richard Henderson
2020-02-11 18:00     ` Richard Henderson
2020-02-07 15:01 ` Alex Bennée [this message]
2020-02-10 19:34   ` [PATCH v1 5/5] tests/plugins: make howvec clean-up after itself Robert Foley
2020-02-11 18:01   ` Richard Henderson
2020-02-07 20:55 ` [PATCH v1 0/5] plugins/next no-reply
2020-02-07 21:27 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200207150118.23007-6-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aaron@os.amperecomputing.com \
    --cc=cota@braap.org \
    --cc=kuhn.chenqun@huawei.com \
    --cc=peter.puhov@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=robert.foley@linaro.org \
    --cc=robhenry@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.