From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xIo7=33=vger.kernel.org=kvm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1B0B8C2BA83
	for <kvm@archiver.kernel.org>; Fri,  7 Feb 2020 17:38:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E6C1A222D9
	for <kvm@archiver.kernel.org>; Fri,  7 Feb 2020 17:38:34 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727581AbgBGRie (ORCPT <rfc822;kvm@archiver.kernel.org>);
        Fri, 7 Feb 2020 12:38:34 -0500
Received: from foss.arm.com ([217.140.110.172]:42506 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727574AbgBGRid (ORCPT <rfc822;kvm@vger.kernel.org>);
        Fri, 7 Feb 2020 12:38:33 -0500
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
        by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73A6D1FB;
        Fri,  7 Feb 2020 09:38:33 -0800 (PST)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14])
        by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C0633F68E;
        Fri,  7 Feb 2020 09:38:32 -0800 (PST)
Date:   Fri, 7 Feb 2020 17:38:29 +0000
From:   Andre Przywara <andre.przywara@arm.com>
To:     Alexandru Elisei <alexandru.elisei@arm.com>
Cc:     kvm@vger.kernel.org, will@kernel.org,
        julien.thierry.kdev@gmail.com, sami.mujawar@arm.com,
        lorenzo.pieralisi@arm.com, maz@kernel.org,
        Julien Thierry <julien.thierry@arm.com>
Subject: Re: [PATCH v2 kvmtool 28/30] arm/fdt: Remove 'linux,pci-probe-only'
 property
Message-ID: <20200207173829.1ac1884e@donnerap.cambridge.arm.com>
In-Reply-To: <20200123134805.1993-29-alexandru.elisei@arm.com>
References: <20200123134805.1993-1-alexandru.elisei@arm.com>
        <20200123134805.1993-29-alexandru.elisei@arm.com>
Organization: ARM
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: kvm-owner@vger.kernel.org
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org

On Thu, 23 Jan 2020 13:48:03 +0000
Alexandru Elisei <alexandru.elisei@arm.com> wrote:

Hi,

> From: Julien Thierry <julien.thierry@arm.com>
> 
> PCI now supports configurable BARs. Get rid of the no longer needed,
> Linux-only, fdt property.

I was just wondering: what is the x86 story here?
Does the x86 kernel never reassign BARs? Or is this dependent on something else?
I see tons of pci kernel command line parameters for pci=, maybe one of them would explicitly allow reassigning?

Cheers,
Andre

> Signed-off-by: Julien Thierry <julien.thierry@arm.com>
> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
> ---
>  arm/fdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arm/fdt.c b/arm/fdt.c
> index c80e6da323b6..02091e9e0bee 100644
> --- a/arm/fdt.c
> +++ b/arm/fdt.c
> @@ -130,7 +130,6 @@ static int setup_fdt(struct kvm *kvm)
>  
>  	/* /chosen */
>  	_FDT(fdt_begin_node(fdt, "chosen"));
> -	_FDT(fdt_property_cell(fdt, "linux,pci-probe-only", 1));
>  
>  	/* Pass on our amended command line to a Linux kernel only. */
>  	if (kvm->cfg.firmware_filename) {