From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E80C35250 for ; Sat, 8 Feb 2020 10:20:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D8DC21741 for ; Sat, 8 Feb 2020 10:20:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QM7NtvrZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbgBHKUD (ORCPT ); Sat, 8 Feb 2020 05:20:03 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:48825 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726876AbgBHKUC (ORCPT ); Sat, 8 Feb 2020 05:20:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581157200; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1oYKtYdvQ2KKVcuQsPOQM5Pyjwzq0LKVSkL25Hb2e5M=; b=QM7NtvrZhNgaZFGHVdrQDoIBEhtTFszWVisgGMSezQJLAIQL+011oI+pdjEDCPOwBJGsjb 7wk9+ay3YrIRGSXnUPrNkPwhUdhgQBV8oWMRwZQbIgHSc2RKi6a6YeTSFRDeNH+2Lf70DW KBKk1amJ+VCvrNfu5qctdusqPO8+c4A= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-0gBR3L3iPJK2e92EknHXvA-1; Sat, 08 Feb 2020 05:19:56 -0500 X-MC-Unique: 0gBR3L3iPJK2e92EknHXvA-1 Received: by mail-yb1-f199.google.com with SMTP id n71so1535330ybf.0 for ; Sat, 08 Feb 2020 02:19:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=1oYKtYdvQ2KKVcuQsPOQM5Pyjwzq0LKVSkL25Hb2e5M=; b=TMAj2499+hwEKX/hbzmOFk1zTN5JAYNyXOjjyHvwBy6OxjqCeulABCFHQZlnM61eqi ksNrej/hoPZVrPFxsH7MLYCh9HwYg20hAaXHo5EFDA/y5sEz8sqc46DWt3j2YGF0hzjU ag7AiGV8e4DUWN+g1gcBid43ixIHGdpwQHbBni6FZ8uUkSfc3TweqoBqtISEjaQe6/Yo Bdr3OCcW+GAHCZsSJjYDbYnfFV66FB4X3VlL6MPNWP67ChOd3GIRGcaQjl9nF+i9NDGR bzUIQfFIjtnBaqphh4x48B9bpeX4WrObNXKUgKj/nbqWkF7cfGLubDHLfOHC70SQBeBW ERhQ== X-Gm-Message-State: APjAAAVuC0Gy6FXZ+EJcK9dTcpzpPgmGIxLO3c3o9lLmpYDwLptLjpof L9zbB4l0UO7g9RXrZDcyUuxVp2ez+w5r4ZbTXLPk1vEqk5v7MiMON81uRucoucqfdwCQxupxdZV yZ1NvS6bpsgMvd7XKlJRs1SQY X-Received: by 2002:a81:5247:: with SMTP id g68mr2885211ywb.51.1581157195169; Sat, 08 Feb 2020 02:19:55 -0800 (PST) X-Google-Smtp-Source: APXvYqwfnsphh0+CPl2tWU7uiny2/uuJzcPYBmgFOFmblHLg70e0vzKJCQRSeueShavTQ/EJaBsiBQ== X-Received: by 2002:a81:5247:: with SMTP id g68mr2885192ywb.51.1581157194587; Sat, 08 Feb 2020 02:19:54 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id 124sm2548909ywm.25.2020.02.08.02.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2020 02:19:53 -0800 (PST) Date: Sat, 8 Feb 2020 03:19:52 -0700 From: Jerry Snitselaar To: Lu Baolu Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: warning from domain_get_iommu Message-ID: <20200208101952.mrawika2wf4kwt3y@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Lu Baolu , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20200204200714.u4ezhi6vhqhxog6e@cantor> <20200206174358.shzhieijle5wdshr@cantor> <20200207093413.oy4tclbrb3vqs3vz@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat Feb 08 20, Lu Baolu wrote: >Hi Jerry, > >On 2020/2/7 17:34, Jerry Snitselaar wrote: >>On Thu Feb 06 20, Jerry Snitselaar wrote: >>>On Tue Feb 04 20, Jerry Snitselaar wrote: >>>>I'm working on getting a system to reproduce this, and verify it >>>>also occurs >>>>with 5.5, but I have a report of a case where the kdump kernel gives >>>>warnings like the following on a hp dl360 gen9: >>>> >>>>[    2.830589] ehci_hcd: USB 2.0 'Enhanced' Host Controller >>>>(EHCI) Driver >>>>[    2.832615] ehci-pci: EHCI PCI platform driver >>>>[    2.834190] ehci-pci 0000:00:1a.0: EHCI Host Controller >>>>[    2.835974] ehci-pci 0000:00:1a.0: new USB bus registered, >>>>assigned bus number 1 >>>>[    2.838276] ehci-pci 0000:00:1a.0: debug port 2 >>>>[    2.839700] WARNING: CPU: 0 PID: 1 at >>>>drivers/iommu/intel-iommu.c:598 domain_get_iommu+0x55/0x60 >>>>[    2.840671] Modules linked in: >>>>[    2.840671] CPU: 0 PID: 1 Comm: swapper/0 Not tainted >>>>4.18.0-170.el8.kdump2.x86_64 #1 >>>>[    2.840671] Hardware name: HP ProLiant DL360 Gen9/ProLiant >>>>DL360 Gen9, BIOS P89 07/21/2019 >>>>[    2.840671] RIP: 0010:domain_get_iommu+0x55/0x60 >>>>[    2.840671] Code: c2 01 eb 0b 48 83 c0 01 8b 34 87 85 f6 75 >>>>0b 48 63 c8 48 39 c2 75 ed 31 c0 c3 48 c1 e1 03 48 8b 05 70 f3 >>>>91 01 48 8b 04 08 c3 <0f> 0b 31 c0 c3 31 c9 eb eb 66 90 0f 1f 44 >>>>00 00 41 55 40 0f b6 f6 >>>>[    2.840671] RSP: 0018:ffffc900000dfab8 EFLAGS: 00010202 >>>>[    2.840671] RAX: ffff88ec7f1c8000 RBX: 0000006c7c867000 RCX: >>>>0000000000000000 >>>>[    2.840671] RDX: 00000000fffffff0 RSI: 0000000000000000 RDI: >>>>ffff88ec7f1c8000 >>>>[    2.840671] RBP: ffff88ec6f7000b0 R08: ffff88ec7f19d000 R09: >>>>ffff88ec7cbfcd00 >>>>[    2.840671] R10: 0000000000000095 R11: ffffc900000df928 R12: >>>>0000000000000000 >>>>[    2.840671] R13: ffff88ec7f1c8000 R14: 0000000000001000 R15: >>>>00000000ffffffff >>>>[    2.840671] FS:  0000000000000000(0000) >>>>GS:ffff88ec7f600000(0000) knlGS:0000000000000000 >>>>[    2.840671] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>[    2.840671] CR2: 00007ff3e1713000 CR3: 0000006c7de0a004 CR4: >>>>00000000001606b0 >>>>[    2.840671] Call Trace: >>>>[    2.840671]  __intel_map_single+0x62/0x140 >>>>[    2.840671]  intel_alloc_coherent+0xa6/0x130 >>>>[    2.840671]  dma_pool_alloc+0xd8/0x1e0 >>>>[    2.840671]  e_qh_alloc+0x55/0x130 >>>>[    2.840671]  ehci_setup+0x284/0x7b0 >>>>[    2.840671]  ehci_pci_setup+0xa3/0x530 >>>>[    2.840671]  usb_add_hcd+0x2b6/0x800 >>>>[    2.840671]  usb_hcd_pci_probe+0x375/0x460 >>>>[    2.840671]  local_pci_probe+0x41/0x90 >>>>[    2.840671]  pci_device_probe+0x105/0x1b0 >>>>[    2.840671]  driver_probe_device+0x12d/0x460 >>>>[    2.840671]  device_driver_attach+0x50/0x60 >>>>[    2.840671]  __driver_attach+0x61/0x130 >>>>[    2.840671]  ? device_driver_attach+0x60/0x60 >>>>[    2.840671]  bus_for_each_dev+0x77/0xc0 >>>>[    2.840671]  ? klist_add_tail+0x3b/0x70 >>>>[    2.840671]  bus_add_driver+0x14d/0x1e0 >>>>[    2.840671]  ? ehci_hcd_init+0xaa/0xaa >>>>[    2.840671]  ? do_early_param+0x91/0x91 >>>>[    2.840671]  driver_register+0x6b/0xb0 >>>>[    2.840671]  ? ehci_hcd_init+0xaa/0xaa >>>>[    2.840671]  do_one_initcall+0x46/0x1c3 >>>>[    2.840671]  ? do_early_param+0x91/0x91 >>>>[    2.840671]  kernel_init_freeable+0x1af/0x258 >>>>[    2.840671]  ? rest_init+0xaa/0xaa >>>>[    2.840671]  kernel_init+0xa/0xf9 >>>>[    2.840671]  ret_from_fork+0x35/0x40 >>>>[    2.840671] ---[ end trace e87b0d9a1c8135c4 ]--- >>>>[    3.010848] ehci-pci 0000:00:1a.0: Using iommu dma mapping >>>>[    3.012551] ehci-pci 0000:00:1a.0: 32bit DMA uses >>>>non-identity mapping >>>>[    3.018537] ehci-pci 0000:00:1a.0: cache line size of 64 is >>>>not supported >>>>[    3.021188] ehci-pci 0000:00:1a.0: irq 18, io mem 0x93002000 >>>>[    3.029006] ehci-pci 0000:00:1a.0: USB 2.0 started, EHCI 1.00 >>>>[    3.030918] usb usb1: New USB device found, idVendor=1d6b, >>>>idProduct=0002, bcdDevice= 4.18 >>>>[    3.033491] usb usb1: New USB device strings: Mfr=3, >>>>Product=2, SerialNumber=1 >>>>[    3.035900] usb usb1: Product: EHCI Host Controller >>>>[    3.037423] usb usb1: Manufacturer: Linux >>>>4.18.0-170.el8.kdump2.x86_64 ehci_hcd >>>>[    3.039691] usb usb1: SerialNumber: 0000:00:1a.0 >>>> >>>>It looks like the device finishes initializing once it figures out it >>>>needs dma mapping instead of the default >>>>passthrough. intel_alloc_coherent calls iommu_need_mapping, before it >>>>calls __intel_map_single, so I'm not sure why it is tripping over the >>>>WARN_ON in domain_get_iommu. >>>> >>>>one thing I noticed while looking at this is that domain_get_iommu can >>>>return NULL. So should there be something like the following in >>>>__intel_map_single after the domain_get_iommu call? >>>> >>>>if (!iommu) >>>> goto error; >>>> >>>>It is possible to deref the null pointer later otherwise. >>>> >>>>Regards, >>>>Jerry >>> >>>I reproduced the warning with a 5.5 kernel on an Intel NUC5i5MYBE. >> >>Hi Baolu, >> >>I think I understand what is happening here. With the kdump boot >>translation is pre-enabled, so in intel_iommu_add_device things are >>getting set to DEFER_DEVICE_DOMAIN_INFO. When intel_alloc_coherent >>calls iommu_need_mapping it returns true, but doesn't do the dma >>domain switch because of DEFER_DEVICE_DOMAIN_INFO. Then >>__intel_map_single gets called and it calls deferred_attach_domain, >>which sets the domain to the group domain, which in this case is the >>identity domain. Then it calls domain_get_iommu, which spits out the >>warning because the domain type was dma and returns null. My >>workaround was to add a call to iommu_need_mapping and find_domain >>after the deferred_attach_domain, but I don't know if that is the >>correct solution. There are a couple other spots like intel_map_sg >>that have the deferred_attach_domain after iommu_need_mapping that >>possibly will suffer from the same problem. >> >>diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c >>index b5c5ab58d395..063f45323cfc 100644 >>--- a/drivers/iommu/intel-iommu.c >>+++ b/drivers/iommu/intel-iommu.c >>@@ -3515,6 +3515,10 @@ static dma_addr_t __intel_map_single(struct >>device *dev, phys_addr_t paddr, >>         if (!domain) >>                 return DMA_MAPPING_ERROR; >> >>+       if (!iommu_need_mapping(dev)) >>+               return paddr; >>+ >>+       domain = find_domain(dev); >>         iommu = domain_get_iommu(domain); >>         size = aligned_nrpages(paddr, size); >> >> >>I finally got a git repo over to one of these systems, and was >>able to reproduce the issue with the head of linus's tree. With commit >>9235cb13d7d1 ("iommu/vt-d: Allow devices with RMRRs to use identity >>domain") >>there are more of the warnings, because devices are using identity that >>weren't before. >> > >Is it possible to move deferred domain attachment to identity_mapping()? > >diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c >index 9dc37672bf89..234ab346198e 100644 >--- a/drivers/iommu/intel-iommu.c >+++ b/drivers/iommu/intel-iommu.c >@@ -2913,13 +2913,11 @@ static int __init si_domain_init(int hw) > > static int identity_mapping(struct device *dev) > { >- struct device_domain_info *info; >+ struct dmar_domain *domain; > >- info = dev->archdata.iommu; >- if (info && info != DUMMY_DEVICE_DOMAIN_INFO && info != >DEFER_DEVICE_DOMAIN_INFO) >- return (info->domain == si_domain); >+ domain = deferred_attach_domain(dev); > >- return 0; >+ return (!domain || domain_type_is_si(domain)); > } > > static int domain_add_dev_info(struct dmar_domain *domain, struct >device *dev) > >Best regards, >baolu Hi Baolu, I think that would work, and then change the deferred_attach_domain calls in __intel_map_single and intel_map_sg to find_domain? I did a quick test with it on the system where I've been looking at this. Regards, Jerry >_______________________________________________ >iommu mailing list >iommu@lists.linux-foundation.org >https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37876C35250 for ; Sat, 8 Feb 2020 10:20:07 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3B9B21741 for ; Sat, 8 Feb 2020 10:20:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QM7NtvrZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3B9B21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id BACB02040B; Sat, 8 Feb 2020 10:20:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9c-5ucec3wEs; Sat, 8 Feb 2020 10:20:05 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 699CB203D5; Sat, 8 Feb 2020 10:20:05 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4F958C0178; Sat, 8 Feb 2020 10:20:05 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7E224C013E for ; Sat, 8 Feb 2020 10:20:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 7568D87E5F for ; Sat, 8 Feb 2020 10:20:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qmPr+uY-ROHs for ; Sat, 8 Feb 2020 10:20:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2BE1287E5B for ; Sat, 8 Feb 2020 10:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581157200; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1oYKtYdvQ2KKVcuQsPOQM5Pyjwzq0LKVSkL25Hb2e5M=; b=QM7NtvrZhNgaZFGHVdrQDoIBEhtTFszWVisgGMSezQJLAIQL+011oI+pdjEDCPOwBJGsjb 7wk9+ay3YrIRGSXnUPrNkPwhUdhgQBV8oWMRwZQbIgHSc2RKi6a6YeTSFRDeNH+2Lf70DW KBKk1amJ+VCvrNfu5qctdusqPO8+c4A= Received: from mail-yw1-f71.google.com (mail-yw1-f71.google.com [209.85.161.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-5QpUuz_2MqeuqhbF72LhKw-1; Sat, 08 Feb 2020 05:19:56 -0500 Received: by mail-yw1-f71.google.com with SMTP id j9so1824817ywg.14 for ; Sat, 08 Feb 2020 02:19:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=1oYKtYdvQ2KKVcuQsPOQM5Pyjwzq0LKVSkL25Hb2e5M=; b=VsHe/EMpAUUxohlg77wMtX2q88X/+VHsp1sDmu2Xfj16dtUyg1M7ZO5GAVhBn60/hT XLdhfWOKt5kN2j7u3RAzTLKMATeUTl63lg/JipRt1LS5fcso1SDnToncy1p4J7PXJtgz vHA/7aCdJGyr4kyV48rBM4t9Vb+qQvOvPRJZvvDY7z0hI5hLbGjgGFKzLhQOQZysXE5P WH0miSn/eUpm/7ny5cV0eT/vzqA4Mg7+xaW8XVl44qNINmVdYZFUBAosI9+1rRtdJP1F Fej9ieA5SfmPJ6hjYXBxmsXIjEBLIbf/hJ4UM9lijgRLzt1tfBeO6Gt4Q8siJv7yROyU ve3A== X-Gm-Message-State: APjAAAVAwfvfg/XWV2S3EAbdq7nvJT947SMM9WH1fWdh/37bfMAlJn1f WvAhc2Pa3k3dKRQLbvdhK4Yt/US/1dItPrJy+nN9TPbf84pfPrBTL5QpvmRurMtIlmfqQWlsVEb RBWLGJrGn8/p8GTP+kVpmHw553PlfRg== X-Received: by 2002:a81:5247:: with SMTP id g68mr2885210ywb.51.1581157195169; Sat, 08 Feb 2020 02:19:55 -0800 (PST) X-Google-Smtp-Source: APXvYqwfnsphh0+CPl2tWU7uiny2/uuJzcPYBmgFOFmblHLg70e0vzKJCQRSeueShavTQ/EJaBsiBQ== X-Received: by 2002:a81:5247:: with SMTP id g68mr2885192ywb.51.1581157194587; Sat, 08 Feb 2020 02:19:54 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id 124sm2548909ywm.25.2020.02.08.02.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2020 02:19:53 -0800 (PST) Date: Sat, 8 Feb 2020 03:19:52 -0700 From: Jerry Snitselaar To: Lu Baolu Subject: Re: warning from domain_get_iommu Message-ID: <20200208101952.mrawika2wf4kwt3y@cantor> Mail-Followup-To: Lu Baolu , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20200204200714.u4ezhi6vhqhxog6e@cantor> <20200206174358.shzhieijle5wdshr@cantor> <20200207093413.oy4tclbrb3vqs3vz@cantor> MIME-Version: 1.0 In-Reply-To: X-MC-Unique: 5QpUuz_2MqeuqhbF72LhKw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jerry Snitselaar Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gU2F0IEZlYiAwOCAyMCwgTHUgQmFvbHUgd3JvdGU6Cj5IaSBKZXJyeSwKPgo+T24gMjAyMC8y LzcgMTc6MzQsIEplcnJ5IFNuaXRzZWxhYXIgd3JvdGU6Cj4+T24gVGh1IEZlYiAwNiAyMCwgSmVy cnkgU25pdHNlbGFhciB3cm90ZToKPj4+T24gVHVlIEZlYiAwNCAyMCwgSmVycnkgU25pdHNlbGFh ciB3cm90ZToKPj4+PkknbSB3b3JraW5nIG9uIGdldHRpbmcgYSBzeXN0ZW0gdG8gcmVwcm9kdWNl IHRoaXMsIGFuZCB2ZXJpZnkgaXQgCj4+Pj5hbHNvIG9jY3Vycwo+Pj4+d2l0aCA1LjUsIGJ1dCBJ IGhhdmUgYSByZXBvcnQgb2YgYSBjYXNlIHdoZXJlIHRoZSBrZHVtcCBrZXJuZWwgZ2l2ZXMKPj4+ Pndhcm5pbmdzIGxpa2UgdGhlIGZvbGxvd2luZyBvbiBhIGhwIGRsMzYwIGdlbjk6Cj4+Pj4KPj4+ PlvCoMKgwqAgMi44MzA1ODldIGVoY2lfaGNkOiBVU0IgMi4wICdFbmhhbmNlZCcgSG9zdCBDb250 cm9sbGVyIAo+Pj4+KEVIQ0kpIERyaXZlcgo+Pj4+W8KgwqDCoCAyLjgzMjYxNV0gZWhjaS1wY2k6 IEVIQ0kgUENJIHBsYXRmb3JtIGRyaXZlcgo+Pj4+W8KgwqDCoCAyLjgzNDE5MF0gZWhjaS1wY2kg MDAwMDowMDoxYS4wOiBFSENJIEhvc3QgQ29udHJvbGxlcgo+Pj4+W8KgwqDCoCAyLjgzNTk3NF0g ZWhjaS1wY2kgMDAwMDowMDoxYS4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCAKPj4+PmFzc2ln bmVkIGJ1cyBudW1iZXIgMQo+Pj4+W8KgwqDCoCAyLjgzODI3Nl0gZWhjaS1wY2kgMDAwMDowMDox YS4wOiBkZWJ1ZyBwb3J0IDIKPj4+PlvCoMKgwqAgMi44Mzk3MDBdIFdBUk5JTkc6IENQVTogMCBQ SUQ6IDEgYXQgCj4+Pj5kcml2ZXJzL2lvbW11L2ludGVsLWlvbW11LmM6NTk4IGRvbWFpbl9nZXRf aW9tbXUrMHg1NS8weDYwCj4+Pj5bwqDCoMKgIDIuODQwNjcxXSBNb2R1bGVzIGxpbmtlZCBpbjoK Pj4+PlvCoMKgwqAgMi44NDA2NzFdIENQVTogMCBQSUQ6IDEgQ29tbTogc3dhcHBlci8wIE5vdCB0 YWludGVkIAo+Pj4+NC4xOC4wLTE3MC5lbDgua2R1bXAyLng4Nl82NCAjMQo+Pj4+W8KgwqDCoCAy Ljg0MDY3MV0gSGFyZHdhcmUgbmFtZTogSFAgUHJvTGlhbnQgREwzNjAgR2VuOS9Qcm9MaWFudCAK Pj4+PkRMMzYwIEdlbjksIEJJT1MgUDg5IDA3LzIxLzIwMTkKPj4+PlvCoMKgwqAgMi44NDA2NzFd IFJJUDogMDAxMDpkb21haW5fZ2V0X2lvbW11KzB4NTUvMHg2MAo+Pj4+W8KgwqDCoCAyLjg0MDY3 MV0gQ29kZTogYzIgMDEgZWIgMGIgNDggODMgYzAgMDEgOGIgMzQgODcgODUgZjYgNzUgCj4+Pj4w YiA0OCA2MyBjOCA0OCAzOSBjMiA3NSBlZCAzMSBjMCBjMyA0OCBjMSBlMSAwMyA0OCA4YiAwNSA3 MCBmMyAKPj4+PjkxIDAxIDQ4IDhiIDA0IDA4IGMzIDwwZj4gMGIgMzEgYzAgYzMgMzEgYzkgZWIg ZWIgNjYgOTAgMGYgMWYgNDQgCj4+Pj4wMCAwMCA0MSA1NSA0MCAwZiBiNiBmNgo+Pj4+W8KgwqDC oCAyLjg0MDY3MV0gUlNQOiAwMDE4OmZmZmZjOTAwMDAwZGZhYjggRUZMQUdTOiAwMDAxMDIwMgo+ Pj4+W8KgwqDCoCAyLjg0MDY3MV0gUkFYOiBmZmZmODhlYzdmMWM4MDAwIFJCWDogMDAwMDAwNmM3 Yzg2NzAwMCBSQ1g6IAo+Pj4+MDAwMDAwMDAwMDAwMDAwMAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV0g UkRYOiAwMDAwMDAwMGZmZmZmZmYwIFJTSTogMDAwMDAwMDAwMDAwMDAwMCBSREk6IAo+Pj4+ZmZm Zjg4ZWM3ZjFjODAwMAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV0gUkJQOiBmZmZmODhlYzZmNzAwMGIw IFIwODogZmZmZjg4ZWM3ZjE5ZDAwMCBSMDk6IAo+Pj4+ZmZmZjg4ZWM3Y2JmY2QwMAo+Pj4+W8Kg wqDCoCAyLjg0MDY3MV0gUjEwOiAwMDAwMDAwMDAwMDAwMDk1IFIxMTogZmZmZmM5MDAwMDBkZjky OCBSMTI6IAo+Pj4+MDAwMDAwMDAwMDAwMDAwMAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV0gUjEzOiBm ZmZmODhlYzdmMWM4MDAwIFIxNDogMDAwMDAwMDAwMDAwMTAwMCBSMTU6IAo+Pj4+MDAwMDAwMDBm ZmZmZmZmZgo+Pj4+W8KgwqDCoCAyLjg0MDY3MV0gRlM6wqAgMDAwMDAwMDAwMDAwMDAwMCgwMDAw KSAKPj4+PkdTOmZmZmY4OGVjN2Y2MDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMAo+ Pj4+W8KgwqDCoCAyLjg0MDY3MV0gQ1M6wqAgMDAxMCBEUzogMDAwMCBFUzogMDAwMCBDUjA6IDAw MDAwMDAwODAwNTAwMzMKPj4+PlvCoMKgwqAgMi44NDA2NzFdIENSMjogMDAwMDdmZjNlMTcxMzAw MCBDUjM6IDAwMDAwMDZjN2RlMGEwMDQgQ1I0OiAKPj4+PjAwMDAwMDAwMDAxNjA2YjAKPj4+PlvC oMKgwqAgMi44NDA2NzFdIENhbGwgVHJhY2U6Cj4+Pj5bwqDCoMKgIDIuODQwNjcxXcKgIF9faW50 ZWxfbWFwX3NpbmdsZSsweDYyLzB4MTQwCj4+Pj5bwqDCoMKgIDIuODQwNjcxXcKgIGludGVsX2Fs bG9jX2NvaGVyZW50KzB4YTYvMHgxMzAKPj4+PlvCoMKgwqAgMi44NDA2NzFdwqAgZG1hX3Bvb2xf YWxsb2MrMHhkOC8weDFlMAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCBlX3FoX2FsbG9jKzB4NTUv MHgxMzAKPj4+PlvCoMKgwqAgMi44NDA2NzFdwqAgZWhjaV9zZXR1cCsweDI4NC8weDdiMAo+Pj4+ W8KgwqDCoCAyLjg0MDY3MV3CoCBlaGNpX3BjaV9zZXR1cCsweGEzLzB4NTMwCj4+Pj5bwqDCoMKg IDIuODQwNjcxXcKgIHVzYl9hZGRfaGNkKzB4MmI2LzB4ODAwCj4+Pj5bwqDCoMKgIDIuODQwNjcx XcKgIHVzYl9oY2RfcGNpX3Byb2JlKzB4Mzc1LzB4NDYwCj4+Pj5bwqDCoMKgIDIuODQwNjcxXcKg IGxvY2FsX3BjaV9wcm9iZSsweDQxLzB4OTAKPj4+PlvCoMKgwqAgMi44NDA2NzFdwqAgcGNpX2Rl dmljZV9wcm9iZSsweDEwNS8weDFiMAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCBkcml2ZXJfcHJv YmVfZGV2aWNlKzB4MTJkLzB4NDYwCj4+Pj5bwqDCoMKgIDIuODQwNjcxXcKgIGRldmljZV9kcml2 ZXJfYXR0YWNoKzB4NTAvMHg2MAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCBfX2RyaXZlcl9hdHRh Y2grMHg2MS8weDEzMAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCA/IGRldmljZV9kcml2ZXJfYXR0 YWNoKzB4NjAvMHg2MAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCBidXNfZm9yX2VhY2hfZGV2KzB4 NzcvMHhjMAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCA/IGtsaXN0X2FkZF90YWlsKzB4M2IvMHg3 MAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCBidXNfYWRkX2RyaXZlcisweDE0ZC8weDFlMAo+Pj4+ W8KgwqDCoCAyLjg0MDY3MV3CoCA/IGVoY2lfaGNkX2luaXQrMHhhYS8weGFhCj4+Pj5bwqDCoMKg IDIuODQwNjcxXcKgID8gZG9fZWFybHlfcGFyYW0rMHg5MS8weDkxCj4+Pj5bwqDCoMKgIDIuODQw NjcxXcKgIGRyaXZlcl9yZWdpc3RlcisweDZiLzB4YjAKPj4+PlvCoMKgwqAgMi44NDA2NzFdwqAg PyBlaGNpX2hjZF9pbml0KzB4YWEvMHhhYQo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCBkb19vbmVf aW5pdGNhbGwrMHg0Ni8weDFjMwo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCA/IGRvX2Vhcmx5X3Bh cmFtKzB4OTEvMHg5MQo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCBrZXJuZWxfaW5pdF9mcmVlYWJs ZSsweDFhZi8weDI1OAo+Pj4+W8KgwqDCoCAyLjg0MDY3MV3CoCA/IHJlc3RfaW5pdCsweGFhLzB4 YWEKPj4+PlvCoMKgwqAgMi44NDA2NzFdwqAga2VybmVsX2luaXQrMHhhLzB4ZjkKPj4+PlvCoMKg wqAgMi44NDA2NzFdwqAgcmV0X2Zyb21fZm9yaysweDM1LzB4NDAKPj4+PlvCoMKgwqAgMi44NDA2 NzFdIC0tLVsgZW5kIHRyYWNlIGU4N2IwZDlhMWM4MTM1YzQgXS0tLQo+Pj4+W8KgwqDCoCAzLjAx MDg0OF0gZWhjaS1wY2kgMDAwMDowMDoxYS4wOiBVc2luZyBpb21tdSBkbWEgbWFwcGluZwo+Pj4+ W8KgwqDCoCAzLjAxMjU1MV0gZWhjaS1wY2kgMDAwMDowMDoxYS4wOiAzMmJpdCBETUEgdXNlcyAK Pj4+Pm5vbi1pZGVudGl0eSBtYXBwaW5nCj4+Pj5bwqDCoMKgIDMuMDE4NTM3XSBlaGNpLXBjaSAw MDAwOjAwOjFhLjA6IGNhY2hlIGxpbmUgc2l6ZSBvZiA2NCBpcyAKPj4+Pm5vdCBzdXBwb3J0ZWQK Pj4+PlvCoMKgwqAgMy4wMjExODhdIGVoY2ktcGNpIDAwMDA6MDA6MWEuMDogaXJxIDE4LCBpbyBt ZW0gMHg5MzAwMjAwMAo+Pj4+W8KgwqDCoCAzLjAyOTAwNl0gZWhjaS1wY2kgMDAwMDowMDoxYS4w OiBVU0IgMi4wIHN0YXJ0ZWQsIEVIQ0kgMS4wMAo+Pj4+W8KgwqDCoCAzLjAzMDkxOF0gdXNiIHVz YjE6IE5ldyBVU0IgZGV2aWNlIGZvdW5kLCBpZFZlbmRvcj0xZDZiLCAKPj4+PmlkUHJvZHVjdD0w MDAyLCBiY2REZXZpY2U9IDQuMTgKPj4+PlvCoMKgwqAgMy4wMzM0OTFdIHVzYiB1c2IxOiBOZXcg VVNCIGRldmljZSBzdHJpbmdzOiBNZnI9MywgCj4+Pj5Qcm9kdWN0PTIsIFNlcmlhbE51bWJlcj0x Cj4+Pj5bwqDCoMKgIDMuMDM1OTAwXSB1c2IgdXNiMTogUHJvZHVjdDogRUhDSSBIb3N0IENvbnRy b2xsZXIKPj4+PlvCoMKgwqAgMy4wMzc0MjNdIHVzYiB1c2IxOiBNYW51ZmFjdHVyZXI6IExpbnV4 IAo+Pj4+NC4xOC4wLTE3MC5lbDgua2R1bXAyLng4Nl82NCBlaGNpX2hjZAo+Pj4+W8KgwqDCoCAz LjAzOTY5MV0gdXNiIHVzYjE6IFNlcmlhbE51bWJlcjogMDAwMDowMDoxYS4wCj4+Pj4KPj4+Pkl0 IGxvb2tzIGxpa2UgdGhlIGRldmljZSBmaW5pc2hlcyBpbml0aWFsaXppbmcgb25jZSBpdCBmaWd1 cmVzIG91dCBpdAo+Pj4+bmVlZHMgZG1hIG1hcHBpbmcgaW5zdGVhZCBvZiB0aGUgZGVmYXVsdAo+ Pj4+cGFzc3Rocm91Z2guIGludGVsX2FsbG9jX2NvaGVyZW50IGNhbGxzIGlvbW11X25lZWRfbWFw cGluZywgYmVmb3JlIGl0Cj4+Pj5jYWxscyBfX2ludGVsX21hcF9zaW5nbGUsIHNvIEknbSBub3Qg c3VyZSB3aHkgaXQgaXMgdHJpcHBpbmcgb3ZlciB0aGUKPj4+PldBUk5fT04gaW4gZG9tYWluX2dl dF9pb21tdS4KPj4+Pgo+Pj4+b25lIHRoaW5nIEkgbm90aWNlZCB3aGlsZSBsb29raW5nIGF0IHRo aXMgaXMgdGhhdCBkb21haW5fZ2V0X2lvbW11IGNhbgo+Pj4+cmV0dXJuIE5VTEwuIFNvIHNob3Vs ZCB0aGVyZSBiZSBzb21ldGhpbmcgbGlrZSB0aGUgZm9sbG93aW5nIGluCj4+Pj5fX2ludGVsX21h cF9zaW5nbGUgYWZ0ZXIgdGhlIGRvbWFpbl9nZXRfaW9tbXUgY2FsbD8KPj4+Pgo+Pj4+aWYgKCFp b21tdSkKPj4+PsKgZ290byBlcnJvcjsKPj4+Pgo+Pj4+SXQgaXMgcG9zc2libGUgdG8gZGVyZWYg dGhlIG51bGwgcG9pbnRlciBsYXRlciBvdGhlcndpc2UuCj4+Pj4KPj4+PlJlZ2FyZHMsCj4+Pj5K ZXJyeQo+Pj4KPj4+SSByZXByb2R1Y2VkIHRoZSB3YXJuaW5nIHdpdGggYSA1LjUga2VybmVsIG9u IGFuIEludGVsIE5VQzVpNU1ZQkUuCj4+Cj4+SGkgQmFvbHUsCj4+Cj4+SSB0aGluayBJIHVuZGVy c3RhbmQgd2hhdCBpcyBoYXBwZW5pbmcgaGVyZS4gV2l0aCB0aGUga2R1bXAgYm9vdAo+PnRyYW5z bGF0aW9uIGlzIHByZS1lbmFibGVkLCBzbyBpbiBpbnRlbF9pb21tdV9hZGRfZGV2aWNlIHRoaW5n cyBhcmUKPj5nZXR0aW5nIHNldCB0byBERUZFUl9ERVZJQ0VfRE9NQUlOX0lORk8uIFdoZW4gaW50 ZWxfYWxsb2NfY29oZXJlbnQKPj5jYWxscyBpb21tdV9uZWVkX21hcHBpbmcgaXQgcmV0dXJucyB0 cnVlLCBidXQgZG9lc24ndCBkbyB0aGUgZG1hCj4+ZG9tYWluIHN3aXRjaCBiZWNhdXNlIG9mIERF RkVSX0RFVklDRV9ET01BSU5fSU5GTy4gVGhlbgo+Pl9faW50ZWxfbWFwX3NpbmdsZSBnZXRzIGNh bGxlZCBhbmQgaXQgY2FsbHMgZGVmZXJyZWRfYXR0YWNoX2RvbWFpbiwKPj53aGljaCBzZXRzIHRo ZSBkb21haW4gdG8gdGhlIGdyb3VwIGRvbWFpbiwgd2hpY2ggaW4gdGhpcyBjYXNlIGlzIHRoZQo+ PmlkZW50aXR5IGRvbWFpbi4gVGhlbiBpdCBjYWxscyBkb21haW5fZ2V0X2lvbW11LCB3aGljaCBz cGl0cyBvdXQgdGhlCj4+d2FybmluZyBiZWNhdXNlIHRoZSBkb21haW4gdHlwZSB3YXMgZG1hIGFu ZCByZXR1cm5zIG51bGwuIE15Cj4+d29ya2Fyb3VuZCB3YXMgdG8gYWRkIGEgY2FsbCB0byBpb21t dV9uZWVkX21hcHBpbmcgYW5kIGZpbmRfZG9tYWluCj4+YWZ0ZXIgdGhlIGRlZmVycmVkX2F0dGFj aF9kb21haW4sIGJ1dCBJIGRvbid0IGtub3cgaWYgdGhhdCBpcyB0aGUKPj5jb3JyZWN0IHNvbHV0 aW9uLiBUaGVyZSBhcmUgYSBjb3VwbGUgb3RoZXIgc3BvdHMgbGlrZSBpbnRlbF9tYXBfc2cKPj50 aGF0IGhhdmUgdGhlIGRlZmVycmVkX2F0dGFjaF9kb21haW4gYWZ0ZXIgaW9tbXVfbmVlZF9tYXBw aW5nIHRoYXQKPj5wb3NzaWJseSB3aWxsIHN1ZmZlciBmcm9tIHRoZSBzYW1lIHByb2JsZW0uCj4+ Cj4+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW9tbXUvaW50ZWwtaW9tbXUuYyBiL2RyaXZlcnMvaW9t bXUvaW50ZWwtaW9tbXUuYwo+PmluZGV4IGI1YzVhYjU4ZDM5NS4uMDYzZjQ1MzIzY2ZjIDEwMDY0 NAo+Pi0tLSBhL2RyaXZlcnMvaW9tbXUvaW50ZWwtaW9tbXUuYwo+PisrKyBiL2RyaXZlcnMvaW9t bXUvaW50ZWwtaW9tbXUuYwo+PkBAIC0zNTE1LDYgKzM1MTUsMTAgQEAgc3RhdGljIGRtYV9hZGRy X3QgX19pbnRlbF9tYXBfc2luZ2xlKHN0cnVjdCAKPj5kZXZpY2UgKmRldiwgcGh5c19hZGRyX3Qg cGFkZHIsCj4+IMKgwqDCoMKgwqDCoMKgIGlmICghZG9tYWluKQo+PiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgcmV0dXJuIERNQV9NQVBQSU5HX0VSUk9SOwo+Pgo+PivCoMKgwqDCoMKg wqAgaWYgKCFpb21tdV9uZWVkX21hcHBpbmcoZGV2KSkKPj4rwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCByZXR1cm4gcGFkZHI7Cj4+Kwo+PivCoMKgwqDCoMKgwqAgZG9tYWluID0gZmluZF9k b21haW4oZGV2KTsKPj4gwqDCoMKgwqDCoMKgwqAgaW9tbXUgPSBkb21haW5fZ2V0X2lvbW11KGRv bWFpbik7Cj4+IMKgwqDCoMKgwqDCoMKgIHNpemUgPSBhbGlnbmVkX25ycGFnZXMocGFkZHIsIHNp emUpOwo+Pgo+Pgo+PkkgZmluYWxseSBnb3QgYSBnaXQgcmVwbyBvdmVyIHRvIG9uZSBvZiB0aGVz ZSBzeXN0ZW1zLCBhbmQgd2FzCj4+YWJsZSB0byByZXByb2R1Y2UgdGhlIGlzc3VlIHdpdGggdGhl IGhlYWQgb2YgbGludXMncyB0cmVlLiBXaXRoIGNvbW1pdAo+PjkyMzVjYjEzZDdkMSAoImlvbW11 L3Z0LWQ6IEFsbG93IGRldmljZXMgd2l0aCBSTVJScyB0byB1c2UgaWRlbnRpdHkgCj4+ZG9tYWlu IikKPj50aGVyZSBhcmUgbW9yZSBvZiB0aGUgd2FybmluZ3MsIGJlY2F1c2UgZGV2aWNlcyBhcmUg dXNpbmcgaWRlbnRpdHkgdGhhdAo+PndlcmVuJ3QgYmVmb3JlLgo+Pgo+Cj5JcyBpdCBwb3NzaWJs ZSB0byBtb3ZlIGRlZmVycmVkIGRvbWFpbiBhdHRhY2htZW50IHRvIGlkZW50aXR5X21hcHBpbmco KT8KPgo+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW9tbXUvaW50ZWwtaW9tbXUuYyBiL2RyaXZlcnMv aW9tbXUvaW50ZWwtaW9tbXUuYwo+aW5kZXggOWRjMzc2NzJiZjg5Li4yMzRhYjM0NjE5OGUgMTAw NjQ0Cj4tLS0gYS9kcml2ZXJzL2lvbW11L2ludGVsLWlvbW11LmMKPisrKyBiL2RyaXZlcnMvaW9t bXUvaW50ZWwtaW9tbXUuYwo+QEAgLTI5MTMsMTMgKzI5MTMsMTEgQEAgc3RhdGljIGludCBfX2lu aXQgc2lfZG9tYWluX2luaXQoaW50IGh3KQo+Cj4gc3RhdGljIGludCBpZGVudGl0eV9tYXBwaW5n KHN0cnVjdCBkZXZpY2UgKmRldikKPiB7Cj4tICAgICAgIHN0cnVjdCBkZXZpY2VfZG9tYWluX2lu Zm8gKmluZm87Cj4rICAgICAgIHN0cnVjdCBkbWFyX2RvbWFpbiAqZG9tYWluOwo+Cj4tICAgICAg IGluZm8gPSBkZXYtPmFyY2hkYXRhLmlvbW11Owo+LSAgICAgICBpZiAoaW5mbyAmJiBpbmZvICE9 IERVTU1ZX0RFVklDRV9ET01BSU5fSU5GTyAmJiBpbmZvICE9IAo+REVGRVJfREVWSUNFX0RPTUFJ Tl9JTkZPKQo+LSAgICAgICAgICAgICAgIHJldHVybiAoaW5mby0+ZG9tYWluID09IHNpX2RvbWFp bik7Cj4rICAgICAgIGRvbWFpbiA9IGRlZmVycmVkX2F0dGFjaF9kb21haW4oZGV2KTsKPgo+LSAg ICAgICByZXR1cm4gMDsKPisgICAgICAgcmV0dXJuICghZG9tYWluIHx8IGRvbWFpbl90eXBlX2lz X3NpKGRvbWFpbikpOwo+IH0KPgo+IHN0YXRpYyBpbnQgZG9tYWluX2FkZF9kZXZfaW5mbyhzdHJ1 Y3QgZG1hcl9kb21haW4gKmRvbWFpbiwgc3RydWN0IAo+ZGV2aWNlICpkZXYpCj4KPkJlc3QgcmVn YXJkcywKPmJhb2x1CgpIaSBCYW9sdSwKCkkgdGhpbmsgdGhhdCB3b3VsZCB3b3JrLCBhbmQgdGhl biBjaGFuZ2UgdGhlIGRlZmVycmVkX2F0dGFjaF9kb21haW4KY2FsbHMgaW4gX19pbnRlbF9tYXBf c2luZ2xlIGFuZCBpbnRlbF9tYXBfc2cgdG8gZmluZF9kb21haW4/CgpJIGRpZCBhIHF1aWNrIHRl c3Qgd2l0aCBpdCBvbiB0aGUgc3lzdGVtIHdoZXJlIEkndmUgYmVlbiBsb29raW5nIGF0IHRoaXMu CgpSZWdhcmRzLApKZXJyeQoKPl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj5pb21tdSBtYWlsaW5nIGxpc3QKPmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRp b24ub3JnCj5odHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5m by9pb21tdQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K aW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBz Oi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11