All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 02/10] package/rust: build and install cargo
Date: Sun, 9 Feb 2020 11:21:31 +0100	[thread overview]
Message-ID: <20200209102131.GK23769@scaer> (raw)
In-Reply-To: <20200207180829.165689-3-arnout@mind.be>

Arnout, All,

On 2020-02-07 19:08 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> 
> Cargo source code is not provided anymore as a separate tarball but is
> now built along with the Rust compiler.
> 
> So update rust host variant to build Cargo and install the
> cross-compilation configuration file.
> 
> All this will be overwritten again by the host-cargo package, but
> that will be removed in later commits.
> 
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
> Tested-by: Sam Voss <sam.voss@rockwellcollins.com>
> [Arnout: merge all install commands in HOST_RUST_INSTALL_CMDS]
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

The commit does not look to do what it says in the commit log.

The commit log says "merge all install commands in HOST_RUST_INSTALL_CMDS"
but HOST_RUST_INSTALL_CMDS are not touched; only CONFIGURE_CMDS are.

So, I'm not sure I follow what's going on...

Regards,
Yann E. MORIN.

> ---
>  package/rust/rust.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/rust/rust.mk b/package/rust/rust.mk
> index 5d14fc6682..9bbed15082 100644
> --- a/package/rust/rust.mk
> +++ b/package/rust/rust.mk
> @@ -47,11 +47,14 @@ define HOST_RUST_CONFIGURE_CMDS
>  		echo 'python = "$(HOST_DIR)/bin/python2"'; \
>  		echo 'submodules = false'; \
>  		echo 'vendor = true'; \
> +		echo 'extended = true'; \
> +		echo 'tools = ["cargo"]'; \
>  		echo 'compiler-docs = false'; \
>  		echo 'docs = false'; \
>  		echo 'verbose = $(HOST_RUST_VERBOSITY)'; \
>  		echo '[install]'; \
>  		echo 'prefix = "$(HOST_DIR)"'; \
> +		echo 'sysconfdir = "$(HOST_DIR)/etc"'; \
>  		echo '[rust]'; \
>  		echo 'channel = "stable"'; \
>  		echo '[target.$(RUSTC_TARGET_NAME)]'; \
> -- 
> 2.24.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-02-09 10:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 18:08 [Buildroot] [PATCH v3 00/10] Merge rust and cargo Arnout Vandecappelle
2020-02-07 18:08 ` [Buildroot] [PATCH v3 01/10] package/rustc: install cargo config as toolchain post-install hook Arnout Vandecappelle
2020-03-27 10:42   ` David PIERRET
2020-05-18 10:51   ` Patrick Havelange
2020-07-27 11:49   ` Thomas Petazzoni
2020-02-07 18:08 ` [Buildroot] [PATCH v3 02/10] package/rust: build and install cargo Arnout Vandecappelle
2020-02-09 10:21   ` Yann E. MORIN [this message]
2020-02-09 16:37     ` Arnout Vandecappelle
2020-03-27 10:44       ` David PIERRET
2020-04-29 13:15   ` Romain Naour
2020-07-27 11:49   ` Thomas Petazzoni
2020-02-07 18:08 ` [Buildroot] [PATCH v3 03/10] package/cargo-bin: install if rust-bin selected Arnout Vandecappelle
2020-03-27 10:47   ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 04/10] package/rust-bin: host variant depends on host-cargo-bin Arnout Vandecappelle
2020-03-27 10:50   ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 05/10] package/rust: drop dependency " Arnout Vandecappelle
2020-03-27 10:51   ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 06/10] package/ripgrep: depends on host-rustc Arnout Vandecappelle
2020-03-27 10:53   ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 07/10] package/cargo: drop package Arnout Vandecappelle
2020-03-27 10:56   ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 08/10] docs/manual: cargo packages depend on host-rustc Arnout Vandecappelle
2020-03-27 10:57   ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 09/10] package/rust: bump to 1.40 Arnout Vandecappelle
2020-03-27 11:02   ` David PIERRET
2020-02-07 18:08 ` [Buildroot] [PATCH v3 10/10] package/cargo-bin: remove and use cargo-bin from rust-bin package Arnout Vandecappelle
2020-03-27 11:08   ` David PIERRET
2020-07-27 11:51   ` Thomas Petazzoni
2020-02-07 21:19 ` [Buildroot] [PATCH v3 00/10] Merge rust and cargo Matthew Weber
2020-07-27 11:48 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200209102131.GK23769@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.