From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED03C35254 for ; Sun, 9 Feb 2020 21:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5D7C2080C for ; Sun, 9 Feb 2020 21:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581282197; bh=KC9IpAGE6KGFjiHbtyoLHb96L0+56asDYIPJpJQvbuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BkKZooyyfS9OYJtA3XoNIP1c3mgjf3hp5mZqlFYoQYj5ivhsdYFEJJ5FoE7gVDyjb 6Sderjf7HCVcDamuqzcBf0DntYxgXUqeEsnauvx2DZsPhcZ5Jeyjj7DU9MnpabbtlV n/IsFLK8+k2NXbMwM4jjBCoxjjpfPMx8N8/TVJpo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727427AbgBIVDQ (ORCPT ); Sun, 9 Feb 2020 16:03:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:60194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727404AbgBIVDP (ORCPT ); Sun, 9 Feb 2020 16:03:15 -0500 Received: from localhost (unknown [38.98.37.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 340BE20733; Sun, 9 Feb 2020 21:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581282195; bh=KC9IpAGE6KGFjiHbtyoLHb96L0+56asDYIPJpJQvbuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k5qUnLm9zBT8RXXizch89Ontj4w33hU/m0SljoAKD9XibfRY/ItzOBv/im72ZELai oHYifNCSyQhdyMzy+x2Khe08K5bi/TAWVaa4PO2VSCrOOh82jieVxDfDqIwKvorowN aR8ZFRcKLxUm41A9x4ob3K/BlnG00M0zcRQKkm4Y= Date: Sun, 9 Feb 2020 22:03:03 +0100 From: Greg Kroah-Hartman To: Andrii Nakryiko Cc: Naresh Kamboju , Andrii Nakryiko , Sasha Levin , bpf , Netdev , Alexei Starovoitov , Daniel Borkmann , Kernel Team , linux- stable , lkft-triage@lists.linaro.org, Arnaldo Carvalho de Melo , Leo Yan Subject: Re: [PATCH bpf-next 0/4] Fix perf_buffer creation on systems with offline CPUs Message-ID: <20200209210303.GA50543@kroah.com> References: <20191212013521.1689228-1-andriin@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, Feb 09, 2020 at 10:32:43AM -0800, Andrii Nakryiko wrote: > On Sun, Feb 9, 2020 at 9:18 AM Naresh Kamboju wrote: > > > > On Thu, 12 Dec 2019 at 07:05, Andrii Nakryiko wrote: > > > > > > This patch set fixes perf_buffer__new() behavior on systems which have some of > > > the CPUs offline/missing (due to difference between "possible" and "online" > > > sets). perf_buffer will create per-CPU buffer and open/attach to corresponding > > > perf_event only on CPUs present and online at the moment of perf_buffer > > > creation. Without this logic, perf_buffer creation has no chances of > > > succeeding on such systems, preventing valid and correct BPF applications from > > > starting. > > > > > > Andrii Nakryiko (4): > > > libbpf: extract and generalize CPU mask parsing logic > > > selftests/bpf: add CPU mask parsing tests > > > libbpf: don't attach perf_buffer to offline/missing CPUs > > > > perf build failed on stable-rc 5.5 branch. > > > > libbpf.c: In function '__perf_buffer__new': > > libbpf.c:6159:8: error: implicit declaration of function > > 'parse_cpu_mask_file'; did you mean 'parse_uint_from_file'? > > [-Werror=implicit-function-declaration] > > err = parse_cpu_mask_file(online_cpus_file, &online, &n); > > ^~~~~~~~~~~~~~~~~~~ > > parse_uint_from_file > > libbpf.c:6159:8: error: nested extern declaration of > > 'parse_cpu_mask_file' [-Werror=nested-externs] > > > > build log, > > https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-5.5/DISTRO=lkft,MACHINE=hikey,label=docker-lkft/11/console > > > > Thanks for reporting! > > These changes depend on commit 6803ee25f0ea ("libbpf: Extract and > generalize CPU mask parsing logic"), which weren't backported to > stable. Greg, can you please pull that one as well? Thanks! Now applied, thanks! greg k-h