From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E58D6C352A3 for ; Mon, 10 Feb 2020 16:44:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0A1820863 for ; Mon, 10 Feb 2020 16:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581353088; bh=N8yq2QheeIQsMuSfVUwgC4v4zDfKO0EfsxrtfIRuif4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=whgUpdMTcmpgtYD0NlarrDSqjS/3AFoqPs37UHVHqMa1OGLJRIrhFdwW6/IhPUF8b 2V5LXU8vJYO8u7q0uMAK5wvol7xAPnPM7/pLVQirmpKWh+knlAOTprgrG5MzLKmYZW 5vM+bWV2HZhAltppdHMfqUfPtMbabOnC5OgyTHy4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727641AbgBJQos (ORCPT ); Mon, 10 Feb 2020 11:44:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:39524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726896AbgBJQor (ORCPT ); Mon, 10 Feb 2020 11:44:47 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1346120733; Mon, 10 Feb 2020 16:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581353087; bh=N8yq2QheeIQsMuSfVUwgC4v4zDfKO0EfsxrtfIRuif4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2VwzkEdpM+ZMnhTLMJYcU9N3jiiHVKzdt/a8hF/PCj1fXdjLM5sFDHMXpzaDNZC5v rX1pFDXRVL2huOr1q9AxbDro7JOJTMPmLrqO9yHDSnnqfpwUUIBJGDEnezY64skR+M BIMtEnTzgYJ9mRVtp/4/HnR7TwXJiZDAKuqYFC68= Date: Mon, 10 Feb 2020 16:44:41 +0000 From: Will Deacon To: Sami Tolvanen Cc: Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Mark Rutland , james.morse@arm.com, Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 09/11] arm64: disable SCS for hypervisor code Message-ID: <20200210164440.GC21900@willie-the-truck> References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <20200128184934.77625-10-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200128184934.77625-10-samitolvanen@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 28, 2020 at 10:49:32AM -0800, Sami Tolvanen wrote: > Filter out CC_FLAGS_SCS and -ffixed-x18 for code that runs at a > different exception level. > > Suggested-by: Steven Rostedt (VMware) > Signed-off-by: Sami Tolvanen > Reviewed-by: Kees Cook > Reviewed-by: Mark Rutland > --- > arch/arm64/kvm/hyp/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile > index ea710f674cb6..5843adef9ef6 100644 > --- a/arch/arm64/kvm/hyp/Makefile > +++ b/arch/arm64/kvm/hyp/Makefile > @@ -28,3 +28,6 @@ GCOV_PROFILE := n > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > KCOV_INSTRUMENT := n > + > +# remove the SCS flags from all objects in this directory > +KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1AAC352A3 for ; Mon, 10 Feb 2020 16:44:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DC2A20838 for ; Mon, 10 Feb 2020 16:44:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ROTzpzrS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2VwzkEdp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DC2A20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Opw1fVobI5sWN/VVCVVsawRe9WA7mj1VpNEnT/Nmk9A=; b=ROTzpzrS9onwz0 IbqnJAKO1+ZmwIdL0HXO//fFvVR8Nz1gQUwHdF8RDcbayFdiGhrqdKogUmjKan3VrFx9x/GG7J+E4 /lXIx34imIMxfy0sNgszq33nlLDglPtRfKksBcODe4xeIUB6CS4AmwH1Ns9OpHl6hcN+CDBGnhs9Z AnkZaUHuB4PMk/qRC9VJXjizyoI6HyFXMsmYSk6S7gPR7iZj48yfOlARVllu0YFhsvjQGWCzKqS52 LcKDdH0i+doJJNP1Ly4kQx1MWEBdMPZpKVF45QUYSsdg6Hv0nHr3wI9jPJAqoqiPT/WA7pKuwE7+A LiZ1YDcKRSMDIvXbyhOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1CAz-0006ND-WE; Mon, 10 Feb 2020 16:44:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1CAx-0006Mg-Ab for linux-arm-kernel@lists.infradead.org; Mon, 10 Feb 2020 16:44:48 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1346120733; Mon, 10 Feb 2020 16:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581353087; bh=N8yq2QheeIQsMuSfVUwgC4v4zDfKO0EfsxrtfIRuif4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2VwzkEdpM+ZMnhTLMJYcU9N3jiiHVKzdt/a8hF/PCj1fXdjLM5sFDHMXpzaDNZC5v rX1pFDXRVL2huOr1q9AxbDro7JOJTMPmLrqO9yHDSnnqfpwUUIBJGDEnezY64skR+M BIMtEnTzgYJ9mRVtp/4/HnR7TwXJiZDAKuqYFC68= Date: Mon, 10 Feb 2020 16:44:41 +0000 From: Will Deacon To: Sami Tolvanen Subject: Re: [PATCH v7 09/11] arm64: disable SCS for hypervisor code Message-ID: <20200210164440.GC21900@willie-the-truck> References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <20200128184934.77625-10-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200128184934.77625-10-samitolvanen@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200210_084447_382992_403FB27C X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , Miguel Ojeda , clang-built-linux@googlegroups.com, james.morse@arm.com, Masami Hiramatsu , Marc Zyngier , kernel-hardening@lists.openwall.com, Laura Abbott , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 28, 2020 at 10:49:32AM -0800, Sami Tolvanen wrote: > Filter out CC_FLAGS_SCS and -ffixed-x18 for code that runs at a > different exception level. > > Suggested-by: Steven Rostedt (VMware) > Signed-off-by: Sami Tolvanen > Reviewed-by: Kees Cook > Reviewed-by: Mark Rutland > --- > arch/arm64/kvm/hyp/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile > index ea710f674cb6..5843adef9ef6 100644 > --- a/arch/arm64/kvm/hyp/Makefile > +++ b/arch/arm64/kvm/hyp/Makefile > @@ -28,3 +28,6 @@ GCOV_PROFILE := n > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > KCOV_INSTRUMENT := n > + > +# remove the SCS flags from all objects in this directory > +KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel