From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Joe Perches <joe@perches.com>, Kajol Jain <kjain@linux.ibm.com>,
acme@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Jin Yao <yao.jin@linux.intel.com>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Anju T Sudhakar <anju@linux.vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v3] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events
Date: Mon, 10 Feb 2020 10:00:31 -0800 [thread overview]
Message-ID: <20200210180031.GY302770@tassilo.jf.intel.com> (raw)
In-Reply-To: <20200210121135.GI1907700@krava>
> > stack declarations of variable length arrays are not
> > a good thing.
> >
> > https://lwn.net/Articles/749089/
> >
> > and
> >
> > bool evlist_used[perf_evlist->core.nr_entries] = {};
>
> hum, I think we already have few of them in perf ;-)
For user space they don't really matter as long as the size is
not totally out of bound, it has a fairly large stack compared
to the kernel, and also is less security sensitive.
-Andi
next prev parent reply other threads:[~2020-02-10 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 5:25 [PATCH v3] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events Kajol Jain
2020-02-06 18:45 ` Jiri Olsa
2020-02-06 18:58 ` Joe Perches
2020-02-10 12:11 ` Jiri Olsa
2020-02-10 18:00 ` Andi Kleen [this message]
2020-02-11 11:20 ` kajoljain
2020-02-11 13:41 ` Jiri Olsa
2020-02-06 20:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210180031.GY302770@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=joe@perches.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.