Re: [master/thud][PATCH] screenshot: Remove this screenshot tool in favor of fbgrab

From: Denys Dmytriyenko <denys@ti.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [master/thud][PATCH] screenshot: Remove this screenshot tool in favor of fbgrab
Date: Mon, 10 Feb 2020 20:41:13 -0500	[thread overview]
Message-ID: <20200211014113.GF17543@beryl> (raw)
In-Reply-To: <20200127194555.GW3658@beryl>

On Mon, Jan 27, 2020 at 02:45:55PM -0500, Denys Dmytriyenko wrote:
> On Mon, Jan 27, 2020 at 11:26:16AM -0500, Andrew F. Davis wrote:
> > This takes a screenshot of the current framebuffer only. There are tools
> > for taking screenshots of the current window system which is usually what
> > a user wants. If the user really wants the conent of the framebuffer then
> > they can use fbgrab which is already in meta-oe.
> 
> I'm not 100% sure, but I believe there's some use of screeshot tool in Matrix 
> demos. I guess we would need to update that too for this change.
> 
> Jake, any comments from OOBE perspective?

Ping

> Denys
> 
> 
> > Signed-off-by: Andrew F. Davis <afd@ti.com>
> > ---
> >  .../packagegroup-arago-tisdk-amsdk.bb         |  5 ----
> >  .../screenshot/screenshot_1.0.bb              | 27 -------------------
> >  2 files changed, 32 deletions(-)
> >  delete mode 100644 meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb
> > 
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb
> > index 42c6aefa..c9a17c5e 100644
> > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-amsdk.bb
> > @@ -17,11 +17,6 @@ OOBE_ti43x += "\
> >      parse-ip \
> >  "
> >  
> > -EXTRA_APPLICATIONS = "\
> > -    screenshot \
> > -"
> > -
> >  RDEPENDS_${PN} = "\
> >      ${OOBE} \
> > -    ${EXTRA_APPLICATIONS} \
> >  "
> > diff --git a/meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb b/meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb
> > deleted file mode 100644
> > index 08a3040b..00000000
> > --- a/meta-arago-extras/recipes-graphics/screenshot/screenshot_1.0.bb
> > +++ /dev/null
> > @@ -1,27 +0,0 @@
> > -SUMMARY = "Screenshot"
> > -HOMEPAGE = "https://gitorious.org/screenshot"
> > -LICENSE = "BSD"
> > -LIC_FILES_CHKSUM = "file://COPYING;md5=5cad16cc3f514a15adb1d710b82d5fc4"
> > -SECTION = "graphics"
> > -
> > -PR = "r2"
> > -
> > -BRANCH ?= "master"
> > -SRCREV = "169242aa7a265d5c94755d74601ad4a3f1828c96"
> > -
> > -SRC_URI = "git://git.ti.com/apps/screenshot.git;protocol=git;branch=${BRANCH}"
> > -
> > -S = "${WORKDIR}/git"
> > -
> > -do_compile() {
> > -    export CROSS_COMPILE=${TARGET_PREFIX}
> > -    export CFLAGS='${TARGET_CC_ARCH}'
> > -    # build the release version
> > -    make release CC="${CC}"
> > -}
> > -
> > -do_install() {
> > -    make DESTDIR=${D} install
> > -}
> > -
> > -INSANE_SKIP_${PN} = "ldflags"
> > -- 
> > 2.17.1
> > 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago