From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1766CC352A3 for ; Tue, 11 Feb 2020 13:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E31152173E for ; Tue, 11 Feb 2020 13:58:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NhuRHNZb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730091AbgBKN6W (ORCPT ); Tue, 11 Feb 2020 08:58:22 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:43024 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730084AbgBKN6V (ORCPT ); Tue, 11 Feb 2020 08:58:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581429499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WG0Npq/OjpsV9gQYxRWfzFxfkdPt4v/t5ykKU8PVL2k=; b=NhuRHNZbmQhqMCWLx84wGgRxirxv3XtKtWkQhKsg9+SBRFd8piflpgx4ZTQLYQHvSG7vfE 14Bc8flNq739l+v2VwNcxHjsR//Ll4nsFHzt/EQcEinYdkS8SdG0vqp3l+HPwsBCHajWRP 8+tgo/afmD97TfJByvGng5W9KwviabE= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-r5y8lCFYNWaozmj9SXvsWw-1; Tue, 11 Feb 2020 08:58:04 -0500 X-MC-Unique: r5y8lCFYNWaozmj9SXvsWw-1 Received: by mail-qt1-f198.google.com with SMTP id b5so6602095qtt.10 for ; Tue, 11 Feb 2020 05:58:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WG0Npq/OjpsV9gQYxRWfzFxfkdPt4v/t5ykKU8PVL2k=; b=ZDQThDNE3+08QMusFm749G8kx3MLEuY5KDa3eHRkhidPqXgk+TXmYd48vMPFR0MLlv 0frO8mreRPQImc+nZ6Oi9kr/4duQgd6NVD0Tjm9EZz2R7fdk0SncZE1DahApCxyZsNPf kplne/WZqUe2oaYc/Dwde89lK27Li52gr4QfLYepgmVfGSCpkblTlCfJ/wt6mjIDhanK Nl/0yG+62vTi7YRMrKdiDy8DXf8c3lh5xYU2bcifi6lEvQtmXguOXbQMZzadk6OBpEnR g9mWqO/OTlWwhxsDtUGX8TNDzGAL48m6Th4bl235BECwryACip96/igvO2M4yJuISm2P x6nw== X-Gm-Message-State: APjAAAWlMBJu1jgqLTJsXLihYRsvSKRHqAuIFIZl/2pTKVHMZ1BfU0MD 6VU97B7z5KOtetdLN7RpGxEid35yYeqDPgxQYssoUmUqIbi34Os0cFrOE0rrdp4Rl7sxpWN5EmE OxlpDGPFInq4g/g5nwSVrrldh X-Received: by 2002:ad4:49ca:: with SMTP id j10mr2823696qvy.155.1581429483895; Tue, 11 Feb 2020 05:58:03 -0800 (PST) X-Google-Smtp-Source: APXvYqz11UYC/BUBAy6kXD/YknIJWxgOMbrK5yvh/VgO+Bst7ojYaRjy5EybVs2SGNTw/K86LmEO+w== X-Received: by 2002:ad4:49ca:: with SMTP id j10mr2823688qvy.155.1581429483704; Tue, 11 Feb 2020 05:58:03 -0800 (PST) Received: from redhat.com (bzq-79-176-41-183.red.bezeqint.net. [79.176.41.183]) by smtp.gmail.com with ESMTPSA id a72sm2102422qkc.121.2020.02.11.05.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 05:58:02 -0800 (PST) Date: Tue, 11 Feb 2020 08:57:58 -0500 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: Christian Borntraeger , "virtualization@lists.linux-foundation.org" , Stephen Rothwell , Linux Next Mailing List , "linux-kernel@vger.kernel.org" , kvm list , Halil Pasic , Cornelia Huck Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot Message-ID: <20200211085736-mutt-send-email-mst@kernel.org> References: <2a63b15f-8cf5-5868-550c-42e2cfd92c60@de.ibm.com> <1ade56b5-083f-bb6f-d3e0-3ddcf78f4d26@de.ibm.com> <20200206171349-mutt-send-email-mst@kernel.org> <5c860fa1-cef5-b389-4ebf-99a62afa0fe8@de.ibm.com> <20200207025806-mutt-send-email-mst@kernel.org> <97c93d38-ef07-e321-d133-18483d54c0c0@de.ibm.com> <43a5dbaa-9129-e220-8483-45c60a82c945@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 02:04:54PM +0100, Eugenio Pérez wrote: > On Mon, 2020-02-10 at 12:01 +0100, Christian Borntraeger wrote: > > > > On 10.02.20 10:47, Eugenio Perez Martin wrote: > > > Hi Christian. > > > > > > I'm not able to reproduce the failure with eccb852f1fe6bede630e2e4f1a121a81e34354ab commit. Could you add more data? > > > Your configuration (libvirt or qemu line), and host's dmesg output if any? > > > > > > Thanks! > > > > If it was not obvious, this is on s390x, a big endian system. > > > > Hi Christian. Thank you very much for your fast responses. > > Could you try this patch on top of eccb852f1fe6bede630e2e4f1a121a81e34354ab? > > Thanks! > > >From 71d0f9108a18aa894cc0c0c1c7efbad39f465a27 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= < > eperezma@redhat.com> > Date: Tue, 11 Feb 2020 13:19:10 +0100 > Subject: [PATCH] vhost: fix return value of vhost_get_vq_desc > > Before of the batch change, it was the chain's head. Need to keep that > way or we will not be able to free a chain of descriptors. I think it's cleaner to have all descriptors in the chain have the same id. > Fixes: eccb852f1fe6 ("vhost: batching fetches") > --- > drivers/vhost/vhost.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index b5a51b1f2e79..fc422c3e5c08 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -2409,12 +2409,11 @@ int vhost_get_vq_desc(struct vhost_virtqueue *vq, > *out_num += ret; > } > > - ret = desc->id; > - > if (!(desc->flags & VRING_DESC_F_NEXT)) > break; > } > > + ret = vq->descs[vq->first_desc].id; > vq->first_desc = i + 1; > > return ret; > -- > 2.18.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot Date: Tue, 11 Feb 2020 08:57:58 -0500 Message-ID: <20200211085736-mutt-send-email-mst@kernel.org> References: <2a63b15f-8cf5-5868-550c-42e2cfd92c60@de.ibm.com> <1ade56b5-083f-bb6f-d3e0-3ddcf78f4d26@de.ibm.com> <20200206171349-mutt-send-email-mst@kernel.org> <5c860fa1-cef5-b389-4ebf-99a62afa0fe8@de.ibm.com> <20200207025806-mutt-send-email-mst@kernel.org> <97c93d38-ef07-e321-d133-18483d54c0c0@de.ibm.com> <43a5dbaa-9129-e220-8483-45c60a82c945@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: Stephen Rothwell , kvm list , Cornelia Huck , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Halil Pasic , Christian Borntraeger , Linux Next Mailing List List-Id: virtualization@lists.linuxfoundation.org On Tue, Feb 11, 2020 at 02:04:54PM +0100, Eugenio P=C3=A9rez wrote: > On Mon, 2020-02-10 at 12:01 +0100, Christian Borntraeger wrote: > > = > > On 10.02.20 10:47, Eugenio Perez Martin wrote: > > > Hi Christian. > > > = > > > I'm not able to reproduce the failure with eccb852f1fe6bede630e2e4f1a= 121a81e34354ab commit. Could you add more data? > > > Your configuration (libvirt or qemu line), and host's dmesg output if= any? > > > = > > > Thanks! > > = > > If it was not obvious, this is on s390x, a big endian system. > > = > = > Hi Christian. Thank you very much for your fast responses. > = > Could you try this patch on top of eccb852f1fe6bede630e2e4f1a121a81e34354= ab? > = > Thanks! > = > >From 71d0f9108a18aa894cc0c0c1c7efbad39f465a27 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Eugenio=3D20P=3DC3=3DA9rez?=3D < > eperezma@redhat.com> > Date: Tue, 11 Feb 2020 13:19:10 +0100 > Subject: [PATCH] vhost: fix return value of vhost_get_vq_desc > = > Before of the batch change, it was the chain's head. Need to keep that > way or we will not be able to free a chain of descriptors. I think it's cleaner to have all descriptors in the chain have the same id. > Fixes: eccb852f1fe6 ("vhost: batching fetches") > --- > drivers/vhost/vhost.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > = > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index b5a51b1f2e79..fc422c3e5c08 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -2409,12 +2409,11 @@ int vhost_get_vq_desc(struct vhost_virtqueue *vq, > *out_num +=3D ret; > } > = > - ret =3D desc->id; > - > if (!(desc->flags & VRING_DESC_F_NEXT)) > break; > } > = > + ret =3D vq->descs[vq->first_desc].id; > vq->first_desc =3D i + 1; > = > return ret; > -- = > 2.18.1