From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B745C352A3 for ; Tue, 11 Feb 2020 09:54:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29CD020873 for ; Tue, 11 Feb 2020 09:54:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581414851; bh=dZ6CUij+Y34KbHJA5uYdVJiJ5KihU8UAFU+V7kMs+eE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BH/vloeJe5QkoYO3jNRold8s11hePmZqrxLrE/+G9jDBjsBRwg0NDUgZWQfNoBPCB WpEZykAvzv52gbypRNHYtNbjB9HmV1qJ1RNpYXK1UMpjH/ZaOz13Y3SKwaGl0F1gTe 8fsj5wrJVVin9NnbBQNsWvrEDBwRj2avSp3m8Zrg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728077AbgBKJyK (ORCPT ); Tue, 11 Feb 2020 04:54:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:42404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727264AbgBKJyJ (ORCPT ); Tue, 11 Feb 2020 04:54:09 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E938F20714; Tue, 11 Feb 2020 09:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581414849; bh=dZ6CUij+Y34KbHJA5uYdVJiJ5KihU8UAFU+V7kMs+eE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wPuXWwxpf67WBRCSd6gmmbHXBuqvSvmM7CL5fmZPWW/D8lxpA6mBLOiyCCe82Ondo 3bLF5Mk0tp3wc7yciEiT9D+0q01TUCgH5co17XExIGf17qY4ndjc51TU5p8+1Z7yee ZmH+8o2VhBQKJpV1BsMvZ2mVsLoV5sPSz3ZIWmH4= Date: Tue, 11 Feb 2020 09:54:02 +0000 From: Will Deacon To: Mark Rutland Cc: James Morse , Sami Tolvanen , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 09/11] arm64: disable SCS for hypervisor code Message-ID: <20200211095401.GA8560@willie-the-truck> References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <20200128184934.77625-10-samitolvanen@google.com> <6f62b3c0-e796-e91c-f53b-23bd80fcb065@arm.com> <20200210175214.GA23318@willie-the-truck> <20200210180327.GB20840@lakrids.cambridge.arm.com> <20200210180740.GA24354@willie-the-truck> <20200210182431.GC20840@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200210182431.GC20840@lakrids.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2020 at 06:24:32PM +0000, Mark Rutland wrote: > On Mon, Feb 10, 2020 at 06:07:41PM +0000, Will Deacon wrote: > > On Mon, Feb 10, 2020 at 06:03:28PM +0000, Mark Rutland wrote: > > > On Mon, Feb 10, 2020 at 05:52:15PM +0000, Will Deacon wrote: > > > > On Mon, Feb 10, 2020 at 05:18:58PM +0000, James Morse wrote: > > > > > On 28/01/2020 18:49, Sami Tolvanen wrote: > > > > > > Filter out CC_FLAGS_SCS and -ffixed-x18 for code that runs at a > > > > > > different exception level. > > > > > > > > > > Hmmm, there are two things being disabled here. > > > > > > > > > > Stashing the lr in memory pointed to by VA won't work transparently at EL2 ... but > > > > > shouldn't KVM's C code still treat x18 as a fixed register? > > > > > > > > My review of v6 suggested dropping the -ffixed-x18 as well, since it's only > > > > introduced by SCS (in patch 5) and so isn't required by anything else. Why > > > > do you think it's needed? > > > > > > When EL1 code calls up to hyp, it expects x18 to be preserved across the > > > call, so hyp needs to either preserve it explicitly across a transitions > > > from/to EL1 or always preserve it. > > > > I thought we explicitly saved/restored it across the call after > > af12376814a5 ("arm64: kvm: stop treating register x18 as caller save"). Is > > that not sufficient? > > That covers the hyp->guest->hyp round trip, but not the host->hyp->host > portion surrounding that. Thanks, I missed that. It's annoying that we'll end up needing /both/ -ffixed-x18 *and* the save/restore around guest transitions, but if we actually want to use SCS for the VHE code then I see that it will be required. Sami -- can you restore -ffixed-x18 and then try the function attribute as suggested by James, please? Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5299C352A3 for ; Tue, 11 Feb 2020 09:54:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9979720842 for ; Tue, 11 Feb 2020 09:54:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dxOzyYkN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wPuXWwxp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9979720842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d4GLvY8ZGEQ3dmH7tS3W5EiN6iMq8yTKrwbYdwo/Kok=; b=dxOzyYkNx0vYlF /2o94XwkoZtvfTpfaXjTx0epOgokgdxpI1PyK+Dd6HsFJc46vkFvCIj9cMZG/7o1yB5LZFJA9XroU wA9zjTEffB7gcIpytpEgaxpclKbRwz870cm95MBFOCriSws3qdrdhg/C7XQGO0ADZ1hopK9mufH/F RlWEj8ZlBEAiglG4RtF6fjHPA/WfI23dcE2dJDd2522af+XxwQbDqOsUDaW9n6tCmZesC3/HAhsKQ xoHUPL7nrb6ZNmotb65BWa+eYoiohzPp05AKJkobQQX4Gb9P5SBDZnsOYXXmvPe9LmwZnz25fddZu 0mXoQdcba6OytC38jjhw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1SFA-0002FI-NZ; Tue, 11 Feb 2020 09:54:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1SF7-0002Eh-FW for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 09:54:10 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E938F20714; Tue, 11 Feb 2020 09:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581414849; bh=dZ6CUij+Y34KbHJA5uYdVJiJ5KihU8UAFU+V7kMs+eE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wPuXWwxpf67WBRCSd6gmmbHXBuqvSvmM7CL5fmZPWW/D8lxpA6mBLOiyCCe82Ondo 3bLF5Mk0tp3wc7yciEiT9D+0q01TUCgH5co17XExIGf17qY4ndjc51TU5p8+1Z7yee ZmH+8o2VhBQKJpV1BsMvZ2mVsLoV5sPSz3ZIWmH4= Date: Tue, 11 Feb 2020 09:54:02 +0000 From: Will Deacon To: Mark Rutland Subject: Re: [PATCH v7 09/11] arm64: disable SCS for hypervisor code Message-ID: <20200211095401.GA8560@willie-the-truck> References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <20200128184934.77625-10-samitolvanen@google.com> <6f62b3c0-e796-e91c-f53b-23bd80fcb065@arm.com> <20200210175214.GA23318@willie-the-truck> <20200210180327.GB20840@lakrids.cambridge.arm.com> <20200210180740.GA24354@willie-the-truck> <20200210182431.GC20840@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200210182431.GC20840@lakrids.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_015409_543691_63A466FD X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , Miguel Ojeda , clang-built-linux@googlegroups.com, James Morse , Masami Hiramatsu , Sami Tolvanen , Marc Zyngier , kernel-hardening@lists.openwall.com, Laura Abbott , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 10, 2020 at 06:24:32PM +0000, Mark Rutland wrote: > On Mon, Feb 10, 2020 at 06:07:41PM +0000, Will Deacon wrote: > > On Mon, Feb 10, 2020 at 06:03:28PM +0000, Mark Rutland wrote: > > > On Mon, Feb 10, 2020 at 05:52:15PM +0000, Will Deacon wrote: > > > > On Mon, Feb 10, 2020 at 05:18:58PM +0000, James Morse wrote: > > > > > On 28/01/2020 18:49, Sami Tolvanen wrote: > > > > > > Filter out CC_FLAGS_SCS and -ffixed-x18 for code that runs at a > > > > > > different exception level. > > > > > > > > > > Hmmm, there are two things being disabled here. > > > > > > > > > > Stashing the lr in memory pointed to by VA won't work transparently at EL2 ... but > > > > > shouldn't KVM's C code still treat x18 as a fixed register? > > > > > > > > My review of v6 suggested dropping the -ffixed-x18 as well, since it's only > > > > introduced by SCS (in patch 5) and so isn't required by anything else. Why > > > > do you think it's needed? > > > > > > When EL1 code calls up to hyp, it expects x18 to be preserved across the > > > call, so hyp needs to either preserve it explicitly across a transitions > > > from/to EL1 or always preserve it. > > > > I thought we explicitly saved/restored it across the call after > > af12376814a5 ("arm64: kvm: stop treating register x18 as caller save"). Is > > that not sufficient? > > That covers the hyp->guest->hyp round trip, but not the host->hyp->host > portion surrounding that. Thanks, I missed that. It's annoying that we'll end up needing /both/ -ffixed-x18 *and* the save/restore around guest transitions, but if we actually want to use SCS for the VHE code then I see that it will be required. Sami -- can you restore -ffixed-x18 and then try the function attribute as suggested by James, please? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel