From: Will Deacon <will@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Jonathan Corbet <corbet@lwn.net>,
Saravana Kannan <saravanak@google.com>,
Jason Baron <jbaron@akamai.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v6] dynamic_debug: allow to work if debugfs is disabled
Date: Tue, 11 Feb 2020 11:01:27 +0000 [thread overview]
Message-ID: <20200211110126.GC8560@willie-the-truck> (raw)
In-Reply-To: <20200210211142.GB1373304@kroah.com>
On Mon, Feb 10, 2020 at 01:11:42PM -0800, Greg Kroah-Hartman wrote:
> With the realization that having debugfs enabled on "production" systems
> is generally not a good idea, debugfs is being disabled from more and
> more platforms over time. However, the functionality of dynamic
> debugging still is needed at times, and since it relies on debugfs for
> its user api, having debugfs disabled also forces dynamic debug to be
> disabled.
>
> To get around this, also create the "control" file for dynamic_debug in
> procfs. This allows people turn on debugging as needed at runtime for
> individual driverfs and subsystems.
>
> Reported-by: many different companies
> Cc: Jason Baron <jbaron@akamai.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v6: fix up Kconfig help, it was a bit incorrect,thanks to Saravana for
> the review.
> v5: as many people asked for it, now enable the control file in both
> debugfs and procfs at the same time.
The 'ddebug_lock' mutex looks like it resolves all of the races here, so:
Acked-by: Will Deacon <will@kernel.org>
Will
next prev parent reply other threads:[~2020-02-11 11:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 7:43 [PATCH] dynamic_debug: allow to work if debugfs is disabled Greg Kroah-Hartman
2020-01-22 8:03 ` Will Deacon
2020-01-22 8:12 ` Greg Kroah-Hartman
2020-01-22 13:53 ` [PATCH v2] " Greg Kroah-Hartman
2020-01-22 18:56 ` Jason Baron
2020-01-22 19:29 ` Greg Kroah-Hartman
2020-01-22 19:31 ` [PATCH v3] " Greg Kroah-Hartman
2020-01-22 21:43 ` Randy Dunlap
2020-01-23 8:48 ` Greg Kroah-Hartman
2020-01-23 8:50 ` [PATCH v4] " Greg Kroah-Hartman
2020-01-23 9:36 ` Will Deacon
2020-01-23 15:53 ` [PATCH v3] " Theodore Y. Ts'o
2020-01-23 17:55 ` Greg Kroah-Hartman
2020-01-24 6:02 ` Theodore Y. Ts'o
2020-01-24 7:29 ` Greg Kroah-Hartman
2020-01-25 1:42 ` Theodore Y. Ts'o
2020-01-25 17:11 ` Jonathan Corbet
2020-01-27 22:19 ` Saravana Kannan
2020-02-09 11:05 ` [PATCH v5] " Greg Kroah-Hartman
2020-02-09 15:53 ` Joe Perches
2020-02-09 17:03 ` Greg Kroah-Hartman
2020-02-10 21:11 ` [PATCH v6] " Greg Kroah-Hartman
2020-02-10 21:15 ` Randy Dunlap
2020-02-12 21:58 ` Greg Kroah-Hartman
2020-02-11 11:01 ` Will Deacon [this message]
2020-01-25 0:03 ` [PATCH] " kbuild test robot
2020-01-25 0:03 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211110126.GC8560@willie-the-truck \
--to=will@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=saravanak@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.