All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: git@vger.kernel.org, gitster@pobox.com,
	johannes.schindelin@gmx.de, peff@peff.net,
	chriscool@tuxfamily.org
Cc: Shourya Shukla <shouryashukla.oo@gmail.com>
Subject: [PATCH 0/1] [RFC][GSoC] submodule: enforcing stricter checks
Date: Tue, 11 Feb 2020 22:33:58 +0530	[thread overview]
Message-ID: <20200211170359.31835-1-shouryashukla.oo@gmail.com> (raw)

Greetings everyone!

I have tried to improve the checks in some functions of 'submodule.c'
and attempted to make them stricter. Initially, not all conditions were
satisfied by the functions 'update_path_in_gitmodules()' and
'remove_path_from_gitmodules()' while changing(updating/removing paths)
the '.gitmodules' file.

Now, on implementing the 'is_writing_gitmodules_ok()' function in one of the
if cases of the functions, all the conditions are checked before returning a
value unlike before.

Thanks,
Shourya Shukla

Shourya Shukla (1):
  submodule: using 'is_writing_gitmodules_ok()' for a stricter check

 submodule.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

-- 
2.20.1

             reply	other threads:[~2020-02-11 17:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 17:03 Shourya Shukla [this message]
2020-02-11 17:03 ` [PATCH 1/1][RFC][GSoC] submodule: using 'is_writing_gitmodules_ok()' for a stricter check Shourya Shukla
2020-02-13 13:42   ` Johannes Schindelin
2020-02-13 16:38     ` Shourya Shukla
2020-02-14 13:28       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211170359.31835-1-shouryashukla.oo@gmail.com \
    --to=shouryashukla.oo@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.