From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9185C35242 for ; Tue, 11 Feb 2020 19:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E2EB2086A for ; Tue, 11 Feb 2020 19:47:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="P2ychzB1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731100AbgBKTrb (ORCPT ); Tue, 11 Feb 2020 14:47:31 -0500 Received: from frisell.zx2c4.com ([192.95.5.64]:52685 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729525AbgBKTr3 (ORCPT ); Tue, 11 Feb 2020 14:47:29 -0500 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 6b9363c0; Tue, 11 Feb 2020 19:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=mail; bh=JzV6toZzstw9vzB/ziu+YJh5G mY=; b=P2ychzB1fiPpHbKLH5pu3loY8Fdgy1/VeuQN9mRxc4/Y2chhz3n8aXP0N 3XH29lQRMIpwnaDTQFP1rfZMIQSWVbwjeHirTpGeKym62d0VHo90RR3kjUB9QPDX m1w7BVuZBihtJevm6XKMSFaW5LBUV3jaQbPrv6bGzZ3nbcsM9YSlYDIsMf4RQ7Mt 4YDkQOz9juORcDjTsXRJq+3NW2lE5pWe7N1lOjC6m1q82OuKA40/BjOzY9/ZBlru Fyr9V+coNxRKLV+P4EkJfVeb9eYisP4ytWzbL6S7liBZS1BHvhJFkFKyLr+rXN0O zVuM6dgWcLBZrV+MZvy8Mw7oV7jNA== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id cd5744c0 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 11 Feb 2020 19:45:43 +0000 (UTC) From: "Jason A. Donenfeld" To: netdev@vger.kernel.org, davem@davemloft.net Cc: "Jason A. Donenfeld" , Harald Welte Subject: [PATCH v4 net 2/5] gtp: use icmp_ndo_send helper Date: Tue, 11 Feb 2020 20:47:06 +0100 Message-Id: <20200211194709.723383-3-Jason@zx2c4.com> In-Reply-To: <20200211194709.723383-1-Jason@zx2c4.com> References: <20200211194709.723383-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Because gtp is calling icmp from network device context, it should use the ndo helper so that the rate limiting applies correctly. Signed-off-by: Jason A. Donenfeld Cc: Harald Welte --- drivers/net/gtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index af07ea760b35..672cd2caf2fb 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -546,8 +546,8 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev, mtu < ntohs(iph->tot_len)) { netdev_dbg(dev, "packet too big, fragmentation needed\n"); memset(IPCB(skb), 0, sizeof(*IPCB(skb))); - icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, - htonl(mtu)); + icmp_ndo_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, + htonl(mtu)); goto err_rt; } -- 2.25.0