From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j1mkC-0006LB-Pe
	for mharc-grub-devel@gnu.org; Wed, 12 Feb 2020 02:47:36 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:58652)
 by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <ps@pks.im>)
 id 1j1mk9-0006L0-Th
 for grub-devel@gnu.org; Wed, 12 Feb 2020 02:47:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ps@pks.im>) id 1j1mk8-0006qc-Qn
 for grub-devel@gnu.org; Wed, 12 Feb 2020 02:47:33 -0500
Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:35041)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <ps@pks.im>) id 1j1mk8-0006oB-BI
 for grub-devel@gnu.org; Wed, 12 Feb 2020 02:47:32 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id F07D74FA;
 Wed, 12 Feb 2020 02:47:28 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Wed, 12 Feb 2020 02:47:29 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date
 :from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=fm3; bh=XsrXfKoBq0/c9VigaFYnDYpPP+m
 JFs6Q9X4KO/jJI8s=; b=qd5+WifM5msvyjCRczEdkVVknayGJ/4GO1Mul7Vh1yG
 SaSeyAZXUYGIhKTmTyNjpuF/yH+qkc+NMh56DXUxzqDY7Nk1+w2T/FMfiqySQsZo
 Al5jPo3JgoFu6NS3z/aulZ9+XynIc7nWJeXF7U7bGWNc6Lcz7Tk95ThNFbt0HSZ0
 AJyvJH5JMZKD6S03W5kw1Ud6mEe4GRiawT0WjZE28D3+LoCIH+FSyWmw0yzi9H93
 wic/8Qz8oslMfv7Pd3pwK0PqyI6JQZ/kZ2lhaDpK2HRhOBEKa6HKYpiY6RsmICgo
 Wp0UQBXKqptWNPIQgkJMLS0h0FWhmQn6d1OtdprCHow==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=XsrXfK
 oBq0/c9VigaFYnDYpPP+mJFs6Q9X4KO/jJI8s=; b=HDOHniKiRoS/f8HJ/oGqLm
 OsijUo+ExF60+b8e0z8yUexGhWuEYTZcf0/28ALYlDE3/IJXWLp3CSMQhf2i19tK
 pydS8mSbYgult9I/vAZwkhk/ChkXdN3T+vCRJbXTUDQsjtUnQAIij3EcSbg/aHjL
 mgd7gVPByU1xqiy9iEpUSOvit8T8wDQr+XdQXH8bOG+W63lcv2CQXd3tMQL37by+
 hQcxRJ1jBWFlja4Khbc1vBrSNhdhnfum3ubZAzdVRcVCtAtv09N8pyAjgpXj59g0
 jg8SDbHr+ud7VakjjgVNirZY8u7uFsnGYSAh/JUOImj5DnuNcZAk6uO3sr+3w7pA
 ==
X-ME-Sender: <xms:j61DXvqQx4VyyuXgJBiuqqvUaNrexgYaa9ZSHtSlOoh2WyGuPkBUlQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrieeggddutdejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi
 tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucfkphepjeejrdduke
 efrddutdelrdefgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl
 fhhrohhmpehpshesphhkshdrihhm
X-ME-Proxy: <xmx:j61DXoW0mdXQeQfE2AfgG8v2s_h3Za9AOYo2zLja4Un543Kl7fzCAA>
 <xmx:j61DXvg88Yt1iBS7-mRpxKB2wMclqKHEwhPY-sGxvUxWkXn74oClCw>
 <xmx:j61DXvws7LuSpRU9ycCb9ehOk4toegJbtJqRGUAD4YcTewmNS3wdzQ>
 <xmx:kK1DXrXqNwiO088Fvz6rGO_fJt1zBOF4Mc0B1Z-t-6l18X42JS9BUQ>
Received: from vm-mail (x4db76d22.dyn.telefonica.de [77.183.109.34])
 by mail.messagingengine.com (Postfix) with ESMTPA id CDAC830606FB;
 Wed, 12 Feb 2020 02:47:26 -0500 (EST)
Received: from localhost (<unknown> [10.192.0.11])
 by vm-mail (OpenSMTPD) with ESMTPSA id 02b0e039
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Wed, 12 Feb 2020 07:47:25 +0000 (UTC)
Date: Wed, 12 Feb 2020 08:47:49 +0100
From: Patrick Steinhardt <ps@pks.im>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>,
 gmazyland@gmail.com, leif@nuviainc.com, agraf@csgraf.de,
 pjones@redhat.com, mjg59@google.com, phcoder@gmail.com
Subject: Re: [PATCH 0/5] Support Argon2 KDF in LUKS2
Message-ID: <20200212074749.GA4330@ncase>
References: <cover.1580998938.git.ps@pks.im>
 <20200211215359.m7dpfsq45zssqvtq@tomti.i.net-space.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY"
Content-Disposition: inline
In-Reply-To: <20200211215359.m7dpfsq45zssqvtq@tomti.i.net-space.pl>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 64.147.123.19
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Feb 2020 07:47:35 -0000


--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 11, 2020 at 10:53:59PM +0100, Daniel Kiper wrote:
> >       GRUB's codebase. This included both stripping off unneeded
> >       functionality as well as converting the code to use our own coding
>=20
> Stripping unneeded functionality is OK. However, I think that it does
> not make sense to convert coding style to the GRUB one. Especially if we
> do not do that for other modules. So, I would leave coding style in
> Argon2 module as is and save your precious minutes for something more
> productive... ;-)


Fair enough, I'll send out a v2 with the original coding style. I
thought as much when I was ready with v1, but was too lazy to do the
work and change back the coding style.

Anyway, to save myself another roundtrip: would you prefer to merge
Argon2 functionality into a single file like I've done it right now or
to retain the original set of files? The reason why I've opted for the
latter is mainly to be able to annotate more functions as static.

> >       style. While it makes importing upstream fixes harder, I'd argue
> >       the code is still very similar in its structure and thus
> >       backporting should be easy enough.
> >
> > Anyway. With these changes I'm able to successfully decrypt LUKS2
> > partitions making use of either PBKDF2, Argon2i or Argon2id.
>=20
> I will take deeper dive into the code if we hammer out things listed abov=
e.

Cool, thanks!

Patrick

--OXfL5xGRrasGEqWY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl5DraMACgkQEXxntp6r
8SxXEA//cJz+eBfnB3ljAcEm8mCj4+cuQTMevijfaprbdXAWNyLtghLuCzEA+HSA
AbMN2ZjZQ7Oc+h7CnmDHC1X20HXIa00gUyaWdennznCpj5ZU8QuIpcFjGddyI3II
8Btr+FEt/g6pJ+/NUFAGMTNgMGoQenas90tLEDSwqYYy9VB9411yWLA6N4y2GflV
CJpXr8EbstGZxvy4vHYxhiACyWveI5v4287vPcqIWNHdB0LYzp4uGkNgb4O4zVat
mlaT3mz3M3nLjpLYodAJh7OWKEnsvv4hzNRbhr1a+q6tR75iWDFIDkrL5wudvIlJ
/4O4pgNj1V9F9vhYAtqPUqj/t/0PLkmwweNaNkR/orYjvL76ty2dkDOTN3HmxC1B
GTBGVePQvuoTGu/dRAvqfRt0J3wBukG4SWWHVuj8lVHtJmY199iiLN+DDM4507Gi
A4I1Ei2p9xhAt62zma6hG/L3SiDffyGiDvLZGO+QvxTUOjp/p4B6h+1rgQ5IuikN
rdyAEfIIbtlN4p6rLZjlY9YBwLYSf2GaZjtepIrolsn239KIA1pmZYyuYbrfMA8J
8yTIoRy61Q5xxKkltQjcjj5f7NXuqHnQgHi0nhiqFfQcwhmRJETE/K8DLzbukBMj
924MVrETsXQUZBmLZPflTjWy0vRSNAgSjm9h9H9eXI1aZHfDwNo=
=s0JH
-----END PGP SIGNATURE-----

--OXfL5xGRrasGEqWY--