From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6DEC2BA83 for ; Wed, 12 Feb 2020 10:49:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CF0520848 for ; Wed, 12 Feb 2020 10:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581504549; bh=e7/KyaTyypq+Fd/F2Np5hVC5zzZzRMc32NuzncQ3qr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XzQNwrEeSXzY+dZG+iO369cGuEnCwgXTWR+Z7PmyJfgF8ThI5rmfK5HUbNh9OoOjp hMsU+HBv+FQIdcK/G/3Fo3DarLTm6uZNh/TO5MpCj7zv+ybcRhTjnOn7lNcIhiFqmL g9ZnkLn/vnUzS4PT0O7UV/BVkGOjdqQ6fGvtpcUY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727980AbgBLKtJ (ORCPT ); Wed, 12 Feb 2020 05:49:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:55486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727347AbgBLKtI (ORCPT ); Wed, 12 Feb 2020 05:49:08 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA3D32082F; Wed, 12 Feb 2020 10:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581504548; bh=e7/KyaTyypq+Fd/F2Np5hVC5zzZzRMc32NuzncQ3qr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k3CZSF6H7D/ew3dYU1hxbYGV9FK3JiiBQCudA+bcHr5Dk5IZycoxRNeIIAczEJqZx If5vFyX31y5yq6FxhPyHwSCDqIAJJh6SwTK1/8xMwNCt3TKZ/W20LPfEpWgZrOpiXN VIfGeiSbNiAu4H64sjCjLwY8SP/gbnSeWNK9h0qc= Date: Wed, 12 Feb 2020 10:49:03 +0000 From: Will Deacon To: Li Yang Cc: Joerg Roedel , Will Deacon , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Russell King - ARM Linux admin , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel Message-ID: <20200212104902.GA3664@willie-the-truck> References: <1581467841-25397-1-git-send-email-leoyang.li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1581467841-25397-1-git-send-email-leoyang.li@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote: > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module") > introduced a side effect that changed the module name from arm-smmu to > arm-smmu-mod. This breaks the users of kernel parameters for the driver > (e.g. arm-smmu.disable_bypass). This patch changes the module name back > to be consistent. > > Signed-off-by: Li Yang > --- > drivers/iommu/Makefile | 4 ++-- > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0 > 2 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%) Can't we just override MODULE_PARAM_PREFIX instead of renaming the file? Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 992F0C2BA83 for ; Wed, 12 Feb 2020 10:49:12 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 590D620848 for ; Wed, 12 Feb 2020 10:49:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="k3CZSF6H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 590D620848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0ED9186303; Wed, 12 Feb 2020 10:49:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8hxhERJyUA8u; Wed, 12 Feb 2020 10:49:11 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 8C821861B3; Wed, 12 Feb 2020 10:49:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 67CAEC1D88; Wed, 12 Feb 2020 10:49:11 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5474AC0177 for ; Wed, 12 Feb 2020 10:49:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3DD3A203CA for ; Wed, 12 Feb 2020 10:49:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zdUAjDploxNx for ; Wed, 12 Feb 2020 10:49:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id 4D38020373 for ; Wed, 12 Feb 2020 10:49:08 +0000 (UTC) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA3D32082F; Wed, 12 Feb 2020 10:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581504548; bh=e7/KyaTyypq+Fd/F2Np5hVC5zzZzRMc32NuzncQ3qr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k3CZSF6H7D/ew3dYU1hxbYGV9FK3JiiBQCudA+bcHr5Dk5IZycoxRNeIIAczEJqZx If5vFyX31y5yq6FxhPyHwSCDqIAJJh6SwTK1/8xMwNCt3TKZ/W20LPfEpWgZrOpiXN VIfGeiSbNiAu4H64sjCjLwY8SP/gbnSeWNK9h0qc= Date: Wed, 12 Feb 2020 10:49:03 +0000 From: Will Deacon To: Li Yang Subject: Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel Message-ID: <20200212104902.GA3664@willie-the-truck> References: <1581467841-25397-1-git-send-email-leoyang.li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1581467841-25397-1-git-send-email-leoyang.li@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Will Deacon , linux-kernel@vger.kernel.org, Russell King - ARM Linux admin , iommu@lists.linux-foundation.org, Robin Murphy , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote: > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module") > introduced a side effect that changed the module name from arm-smmu to > arm-smmu-mod. This breaks the users of kernel parameters for the driver > (e.g. arm-smmu.disable_bypass). This patch changes the module name back > to be consistent. > > Signed-off-by: Li Yang > --- > drivers/iommu/Makefile | 4 ++-- > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0 > 2 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%) Can't we just override MODULE_PARAM_PREFIX instead of renaming the file? Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE96C2BA83 for ; Wed, 12 Feb 2020 10:49:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D56402082F for ; Wed, 12 Feb 2020 10:49:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r40QfnsC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="k3CZSF6H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D56402082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pHbiMO2NI0WQWM9Nbg9OjbQZL/zZyN7JpolYOsuAwVQ=; b=r40QfnsCZ3gWIk ulwZw8XSht2cS6r0gOvB0Ry6HoI0vgXdQDD2OuPt0mUTFRAvEi2+jtE9frXBKduonK/RTyo1xiJZM vHYzI2tCqUL9LCoGoP83JnC1qcJHtfnYjIsJFXLTY0rza6GqCV7NmmFBK3T9e/2rbbxztbWUGuwuq +S5EBGk269OKDOPyLpCi86cCYNZgcpWQdCzTfhTt1BYn3FGKzyC9WZAobljFiMZ3J59Skeo0ySS0m OhOvKkMhYI/cOjf27o9ULrhBT/+nVuHb9SVNQSCU2sKX2iGiwGH8iqUM153Es196xf/Pm1YXaXrp2 xN+2FLjgt+SooZxsORVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1paA-0000o3-Du; Wed, 12 Feb 2020 10:49:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1pZs-0000b4-OZ for linux-arm-kernel@lists.infradead.org; Wed, 12 Feb 2020 10:49:09 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA3D32082F; Wed, 12 Feb 2020 10:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581504548; bh=e7/KyaTyypq+Fd/F2Np5hVC5zzZzRMc32NuzncQ3qr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k3CZSF6H7D/ew3dYU1hxbYGV9FK3JiiBQCudA+bcHr5Dk5IZycoxRNeIIAczEJqZx If5vFyX31y5yq6FxhPyHwSCDqIAJJh6SwTK1/8xMwNCt3TKZ/W20LPfEpWgZrOpiXN VIfGeiSbNiAu4H64sjCjLwY8SP/gbnSeWNK9h0qc= Date: Wed, 12 Feb 2020 10:49:03 +0000 From: Will Deacon To: Li Yang Subject: Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel Message-ID: <20200212104902.GA3664@willie-the-truck> References: <1581467841-25397-1-git-send-email-leoyang.li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1581467841-25397-1-git-send-email-leoyang.li@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200212_024908_816600_90081981 X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg Roedel , Will Deacon , linux-kernel@vger.kernel.org, Russell King - ARM Linux admin , iommu@lists.linux-foundation.org, Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote: > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module") > introduced a side effect that changed the module name from arm-smmu to > arm-smmu-mod. This breaks the users of kernel parameters for the driver > (e.g. arm-smmu.disable_bypass). This patch changes the module name back > to be consistent. > > Signed-off-by: Li Yang > --- > drivers/iommu/Makefile | 4 ++-- > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0 > 2 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%) Can't we just override MODULE_PARAM_PREFIX instead of renaming the file? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel