All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>
Subject: Re: [PATCH v1] printk: Declare log_wait as external variable
Date: Wed, 12 Feb 2020 15:03:55 +0100	[thread overview]
Message-ID: <20200212140355.56drih2wfcryjjtl@pathway.suse.cz> (raw)
In-Reply-To: <20200212013133.GB13208@google.com>

On Wed 2020-02-12 10:31:33, Sergey Senozhatsky wrote:
> On (20/02/11 13:43), Petr Mladek wrote:
> >
> > Even better solution might be to move fs/proc/kmsg.c to
> > kernel/printk/proc_kmsg.c and declare printk_log_wait only
> > in kernel/printk/internal.h. I think that this is what
> > Sergey suggested.
> 
> Yes, right.
> 
> > Another great thing would be to extract devkmsg stuff from
> > kernel/printk/printk.c and put it into kernel/printk/dev_kmsg.c.
> 
> Yeah, can do, I would still prefer proc_kmsg to "move in".
> Either both can live in printk.c (won't make it much worse),
> or in kernel/printk/dev_kmsg.c and kernel/printk/proc_kmsg.c

I would prefer to split it:

    + printk.c is already too big and would deserve splitting.

    + The two different kmgs interfaces are confusing on its
      own. IMHO, it will be even more confusing when they
      live in one huge source file.


> I can take a look at dev_ksmg.c/proc_kmsg.c option, unless
> someone else wants to spend their time on this.

It would be lovely from my POV. I am only concerned about
the lockless printk() stuff. I would prefer to avoid creating
too many conflicts in the same merge window. Well, I am
not sure how many conflicts there would be. Adding John
into CC.

Best Regards,
Petr

  reply	other threads:[~2020-02-12 14:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 13:15 [PATCH v1] printk: Declare log_wait as external variable Andy Shevchenko
2020-02-04  2:16 ` Sergey Senozhatsky
2020-02-04  9:05   ` Andy Shevchenko
2020-02-04 11:22     ` Sergey Senozhatsky
2020-02-04 11:31       ` Andy Shevchenko
2020-02-11 12:43 ` Petr Mladek
2020-02-12  1:31   ` Sergey Senozhatsky
2020-02-12 14:03     ` Petr Mladek [this message]
2020-02-12 14:24       ` John Ogness
2020-02-13 12:02         ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200212140355.56drih2wfcryjjtl@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.