All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PULL 9/9] target/i386: enable monitor and ucode revision with -cpu max
Date: Wed, 12 Feb 2020 17:41:29 +0100	[thread overview]
Message-ID: <20200212164129.6968-10-pbonzini@redhat.com> (raw)
In-Reply-To: <20200212164129.6968-1-pbonzini@redhat.com>

These two features were incorrectly tied to host_cpuid_required rather than
cpu->max_features.  As a result, -cpu max was not enabling either MONITOR
features or ucode revision.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/i386/cpu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 32efa46852..92fafa2659 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6414,7 +6414,9 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
             error_setg(&local_err, "CPU model '%s' requires KVM", name);
             goto out;
         }
+    }
 
+    if (cpu->max_features && accel_uses_host_cpuid()) {
         if (enable_cpu_pm) {
             host_cpuid(5, 0, &cpu->mwait.eax, &cpu->mwait.ebx,
                        &cpu->mwait.ecx, &cpu->mwait.edx);
-- 
2.21.0



  parent reply	other threads:[~2020-02-12 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 16:41 [PULL 0/9] Mini misc patches queue for 2020-02-12 Paolo Bonzini
2020-02-12 16:41 ` [PULL 1/9] vl: Don't mismatch g_strsplit()/g_free() Paolo Bonzini
2020-02-12 16:41 ` [PULL 2/9] seqlock: fix seqlock_write_unlock_impl function Paolo Bonzini
2020-02-12 16:41 ` [PULL 3/9] Remove support for CLOCK_MONOTONIC not being defined Paolo Bonzini
2020-02-12 16:41 ` [PULL 4/9] minikconf: accept alnum identifiers Paolo Bonzini
2020-02-12 16:41 ` [PULL 5/9] exec: do not define use_icount for user-mode emulation Paolo Bonzini
2020-02-12 16:41 ` [PULL 6/9] build: move TARGET_GPROF to config-host.mak Paolo Bonzini
2020-02-12 16:41 ` [PULL 7/9] target/i386: fix TCG UCODE_REV access Paolo Bonzini
2020-02-12 16:41 ` [PULL 8/9] target/i386: check for availability of MSR_IA32_UCODE_REV as an emulated MSR Paolo Bonzini
2020-02-12 16:41 ` Paolo Bonzini [this message]
2020-02-13 14:43 ` [PULL 0/9] Mini misc patches queue for 2020-02-12 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200212164129.6968-10-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.