From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3FEC352A4 for ; Thu, 13 Feb 2020 01:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AED5B21739 for ; Thu, 13 Feb 2020 01:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729454AbgBMBlc (ORCPT ); Wed, 12 Feb 2020 20:41:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:50778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729285AbgBMBlb (ORCPT ); Wed, 12 Feb 2020 20:41:31 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F067420873; Thu, 13 Feb 2020 01:41:29 +0000 (UTC) Date: Wed, 12 Feb 2020 20:41:28 -0500 From: Steven Rostedt To: Joel Fernandes Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, gregkh@linuxfoundation.org, gustavo@embeddedor.com, tglx@linutronix.de, paulmck@kernel.org, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com Subject: Re: [PATCH v2 2/9] rcu: Mark rcu_dynticks_curr_cpu_in_eqs() inline Message-ID: <20200212204128.20f5e8ba@oasis.local.home> In-Reply-To: <20200212223818.GA115917@google.com> References: <20200212210139.382424693@infradead.org> <20200212210749.915180520@infradead.org> <20200212223818.GA115917@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Feb 2020 17:38:18 -0500 Joel Fernandes wrote: > I think there are ways to turn off function inlining, such as gcc's: > -fkeep-inline-functions > > And just to be sure weird compilers (clang *cough*) don't screw this up, > could we make it static inline notrace? inline is defined as notrace, so not needed. I did that because of surprises when functions marked as inline suddenly became non inlined and traced, which caused issues with function tracing (before I finally got recursion protection working). But even then, I figured, if something is inlined and gcc actually inlines it, it wont be traced. For consistency, if something is marked inline, it should not be traced. -- Steve