From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CF1C352A4 for ; Thu, 13 Feb 2020 02:03:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B8EE20659 for ; Thu, 13 Feb 2020 02:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O//7kG9v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729476AbgBMCDe (ORCPT ); Wed, 12 Feb 2020 21:03:34 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:45675 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729302AbgBMCDe (ORCPT ); Wed, 12 Feb 2020 21:03:34 -0500 Received: by mail-pl1-f196.google.com with SMTP id b22so1667754pls.12 for ; Wed, 12 Feb 2020 18:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x4frmMXGOLlmcRjK55IB+vPQaFT4KUg/VMQvDX0jZ70=; b=O//7kG9vqhbWdSfyl+B8jnRk/M8p5VWm+1N7QlLfU2UhdQ0f1C3z1SmifcWi761bwy N3IQxDzDJUwDs6NkydmvpwUNqnr2j3kPrVNWc6FOLwR9hHXDmhoPTsP8jdBx9omGRZUW 8fGZ3KXNxXWT72daAEqcBBeUwW13bU2NyqQjP9LMWZqpqwNcRrzm0sGCLEoQE53wNJ0P uTkJiRoPdpVQdvs5EHfHsuVPUPkEx3zLFc7RJGuLNBbJu1EAWw2N4eD9+PedmWI2/Q91 YXKyLbK9dmuP3djG3aqehl41aaSxG7q26yeRKf6PYyokDDLw7sMz/UaDN6mwX9PfvrsK L1cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x4frmMXGOLlmcRjK55IB+vPQaFT4KUg/VMQvDX0jZ70=; b=WyrDlk4gGRshoWWEEFsHvD1D1Yz2MbcEXNv75hgfrgqtoSz6kwSdrxYj53YaUmsUpX eBY5qsnWPTo7VDtKIk3gB3hxepMRsRRcmDtyKqNZDYC7eOFmMPauj7+Xtl8gxi7pnW81 9NJ3GCFQS1g4+mINX+mIACHIGt0mi6Fc6C7Ed6s7I+WRohChzdA7j+xQJbpl9YMMsRm8 OsS1TUGIWtTqEDRc6HTtt/ZoPISMmTBX7zo+wqLmw67nSkb1LkWdpvnUbUH0EwCA4Wz/ VhZuOsBl7ZEpTx0s8DJtf2xn8OjYRcnpLZQD7Tb/e61h0mnPCv8PkBWkM25r1S8c569t hDVg== X-Gm-Message-State: APjAAAVmLce4GH8KaH60iYbaBF6CyihbtsB0UXvUbBqADNZIL8Klj0MX AI/9nunGAMZ0goaaptFDaR8= X-Google-Smtp-Source: APXvYqyUErjZyLodAXxDTkgukQoJFsyyrZhVcKLE8Nt+SOOTHjErXHL8vCZ/j1oym/Hn12tMqfDmCw== X-Received: by 2002:a17:90b:46c4:: with SMTP id jx4mr2371863pjb.32.1581559413377; Wed, 12 Feb 2020 18:03:33 -0800 (PST) Received: from localhost ([106.200.59.46]) by smtp.gmail.com with ESMTPSA id k9sm459336pjo.19.2020.02.12.18.03.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Feb 2020 18:03:32 -0800 (PST) Date: Thu, 13 Feb 2020 07:33:30 +0530 From: afzal mohammed To: Finn Thain Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, Greg Ungerer , Thomas Gleixner , Geert Uytterhoeven Subject: Re: [PATCH 06/18] m68k: Replace setup_irq() by request_irq() Message-ID: <20200213020330.GC2684@teres> References: <1941c51a3237c4e9df6d9a5b87615cd1bba572dc.1581478324.git.afzal.mohd.ma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Feb 13, 2020 at 09:25:19AM +1100, Finn Thain wrote: > > - setup_irq(TMR_IRQ_NUM, &m68328_timer_irq); > > + if (request_irq(TMR_IRQ_NUM, hw_tick, IRQF_TIMER, "timer", NULL)) > > + pr_err("request_irq() on %s failed\n", "timer"); > > "request_irq() on timer failed" is bad grammar and doesn't convey what > went wrong. It could be taken to mean that request_irq() was called > because a timer went off. > > Have you considered, > > pr_err("%s: request_irq() failed\n", "timer"); i was uncomfortable with the string contents, since that didn't seem nonsense and to avoid pondering time over it, it was used. Your suggestion is definitely better, will use that instead. Regards afzal