From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org, stefana@xilinx.com
Subject: Re: [PATCH] asm-generic/bitops: Update stale comment
Date: Thu, 13 Feb 2020 11:47:26 +0100 [thread overview]
Message-ID: <20200213104726.GO14897@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200213093927.1836-1-will@kernel.org>
On Thu, Feb 13, 2020 at 09:39:27AM +0000, Will Deacon wrote:
> The comment in 'asm-generic/bitops.h' states that you should "recode
> these in the native assembly language, if at all possible". This is
> pretty crappy advice now that the generic implementation is defined in
> terms of atomic_long_t rather than a spinlock, so update the comment and
> hopefully save future architecture maintainers a bit of work.
>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Reported-by: Stefan Asserhall <stefana@xilinx.com>
> Signed-off-by: Will Deacon <will@kernel.org>
Thanks Will!
next prev parent reply other threads:[~2020-02-13 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 9:39 [PATCH] asm-generic/bitops: Update stale comment Will Deacon
2020-02-13 10:47 ` Peter Zijlstra [this message]
2020-03-06 10:39 ` [tip: locking/core] " tip-bot2 for Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213104726.GO14897@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefana@xilinx.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.