From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1C5C2BA83 for ; Thu, 13 Feb 2020 15:53:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA1442073C for ; Thu, 13 Feb 2020 15:53:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gBl+ut21" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388190AbgBMPxh (ORCPT ); Thu, 13 Feb 2020 10:53:37 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26109 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388059AbgBMPxg (ORCPT ); Thu, 13 Feb 2020 10:53:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581609215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3FkWdFXSGm8nRf/G4t6XQozUjKUXP7Krdr59zDr+Cjw=; b=gBl+ut21WhW/bOBDWFonkIWdQiR9tv0EcGB7BBNxiOCUCJ/NDnWAuLscPYpBLOIWwXlhEI Ja16R4LyqmEBaH32ZpiUlRfj+f3efkck9bYDp1A3/JozkTZW9HhVjgRXcgtZe9g0qkiR8v uO1RhELPAkapUE9BB4p370yc0WnkOR4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-ZbFlUmSUNb-Rz46GVXV3uw-1; Thu, 13 Feb 2020 10:53:31 -0500 X-MC-Unique: ZbFlUmSUNb-Rz46GVXV3uw-1 Received: by mail-qv1-f70.google.com with SMTP id v3so3777657qvm.2 for ; Thu, 13 Feb 2020 07:53:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3FkWdFXSGm8nRf/G4t6XQozUjKUXP7Krdr59zDr+Cjw=; b=jPgj2pU9d+PNJlq5J4JfnPFvOu3PtmsrU4jYQXqbjfj6vUPcdhgoA6T9ryQ6LqeGGR yI+yHDO/1MQsMgO18UppvuYPcL8XE9TrkbCIUfbOfgcMkWHGLwgj41OJY2mkL6yF4huL J4JjN8Cv6u+Kdguft9UBEuN9MT7PAS7d90nBhThOFv0vOaomHQgWW/iz6xq77tMd04DD tREahQK4vvoWd9g0ciEO/wwhVFoSxHh670ADKQveaP4lh0OTO0DVgTSUD0oWNSYlatJo hTq219RWNscGnrkZYayhGEkezf+7c+XKU0+B881cI4XLUJvPkXRLCABqK0XpUqYR4wlQ su3w== X-Gm-Message-State: APjAAAVejr2M8EDjPPp49EUEO30mgPZ73hhWgZiz78lHcVEAW+6O7Q8W FJmA4fZojlRSiwtQaIaH0Sr/+aiZ9dlbj7381brebDbMgZz5Mg8mYB1deQUaRgDtQEa/z0nxFvH 7CLCVIssZ/dZgfJyB X-Received: by 2002:ae9:e88e:: with SMTP id a136mr172040qkg.71.1581609210920; Thu, 13 Feb 2020 07:53:30 -0800 (PST) X-Google-Smtp-Source: APXvYqxik+NUrSDUNwyo9OGo5sO0s3wLTjJedNNG8mgbQZB+akZZDVEf2GTRfMcPb1EYKXHzYpEcoQ== X-Received: by 2002:ae9:e88e:: with SMTP id a136mr172018qkg.71.1581609210635; Thu, 13 Feb 2020 07:53:30 -0800 (PST) Received: from redhat.com (bzq-79-176-28-95.red.bezeqint.net. [79.176.28.95]) by smtp.gmail.com with ESMTPSA id l6sm1651426qti.10.2020.02.13.07.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 07:53:29 -0800 (PST) Date: Thu, 13 Feb 2020 10:53:25 -0500 From: "Michael S. Tsirkin" To: Eric Dumazet Cc: Anton Ivanov , netdev@vger.kernel.org, Jason Wang , linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso Message-ID: <20200213105010-mutt-send-email-mst@kernel.org> References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 13, 2020 at 07:44:06AM -0800, Eric Dumazet wrote: > > > On 2/13/20 2:00 AM, Michael S. Tsirkin wrote: > > On Wed, Feb 12, 2020 at 05:38:09PM +0000, Anton Ivanov wrote: > >> > >> > >> On 11/02/2020 10:37, Michael S. Tsirkin wrote: > >>> On Tue, Feb 11, 2020 at 07:42:37AM +0000, Anton Ivanov wrote: > >>>> On 11/02/2020 02:51, Jason Wang wrote: > >>>>> > >>>>> On 2020/2/11 上午12:55, Anton Ivanov wrote: > >>>>>> > >>>>>> > >>>>>> On 09/12/2019 10:48, anton.ivanov@cambridgegreys.com wrote: > >>>>>>> From: Anton Ivanov > >>>>>>> > >>>>>>> Some of the frames marked as GSO which arrive at > >>>>>>> virtio_net_hdr_from_skb() have no GSO_TYPE, no > >>>>>>> fragments (data_len = 0) and length significantly shorter > >>>>>>> than the MTU (752 in my experiments). > >>>>>>> > >>>>>>> This is observed on raw sockets reading off vEth interfaces > >>>>>>> in all 4.x and 5.x kernels I tested. > >>>>>>> > >>>>>>> These frames are reported as invalid while they are in fact > >>>>>>> gso-less frames. > >>>>>>> > >>>>>>> This patch marks the vnet header as no-GSO for them instead > >>>>>>> of reporting it as invalid. > >>>>>>> > >>>>>>> Signed-off-by: Anton Ivanov > >>>>>>> --- > >>>>>>>   include/linux/virtio_net.h | 8 ++++++-- > >>>>>>>   1 file changed, 6 insertions(+), 2 deletions(-) > >>>>>>> > >>>>>>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h > >>>>>>> index 0d1fe9297ac6..d90d5cff1b9a 100644 > >>>>>>> --- a/include/linux/virtio_net.h > >>>>>>> +++ b/include/linux/virtio_net.h > >>>>>>> @@ -112,8 +112,12 @@ static inline int > >>>>>>> virtio_net_hdr_from_skb(const struct sk_buff *skb, > >>>>>>>               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV4; > >>>>>>>           else if (sinfo->gso_type & SKB_GSO_TCPV6) > >>>>>>>               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; > >>>>>>> -        else > >>>>>>> -            return -EINVAL; > >>>>>>> +        else { > >>>>>>> +            if (skb->data_len == 0) > >>>>>>> +                hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; > >>>>>>> +            else > >>>>>>> +                return -EINVAL; > >>>>>>> +        } > >>>>>>>           if (sinfo->gso_type & SKB_GSO_TCP_ECN) > >>>>>>>               hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; > >>>>>>>       } else > >>>>>>> > >>>>>> > >>>>>> ping. > >>>>>> > >>>>> > >>>>> Do you mean gso_size is set but gso_type is not? Looks like a bug > >>>>> elsewhere. > >>>>> > >>>>> Thanks > >>>>> > >>>>> > >>>> Yes. > >>>> > >>>> I could not trace it where it is coming from. > >>>> > >>>> I see it when doing recvmmsg on raw sockets in the UML vector network > >>>> drivers. > >>>> > >>> > >>> I think we need to find the culprit and fix it there, lots of other things > >>> can break otherwise. > >>> Just printing out skb->dev->name should do the trick, no? > >> > >> The printk in virtio_net_hdr_from_skb says NULL. > >> > >> That is probably normal for a locally originated frame. > >> > >> I cannot reproduce this with network traffic by the way - it happens only if the traffic is locally originated on the host. > >> > >> A, > > > > OK so is it code in __tcp_transmit_skb that sets gso_size to non-null > > when gso_type is 0? > > > > Correct way to determine if a packet is a gso one is by looking at gso_size. > Then only it is legal looking at gso_type > > > static inline bool skb_is_gso(const struct sk_buff *skb) > { > return skb_shinfo(skb)->gso_size; > } > > /* Note: Should be called only if skb_is_gso(skb) is true */ > static inline bool skb_is_gso_v6(const struct sk_buff *skb) > ... > > > There is absolutely no relation between GSO and skb->data_len, skb can be linearized > for various orthogonal reasons. The reported problem is that virtio gets a packet where gso_size is !0 but gso_type is 0. It currently drops these on the assumption that it's some type of a gso packet it does not know how to handle. So you are saying if skb_is_gso we can still have gso_type set to 0, and that's an expected configuration? So the patch should just be: - if (skb_is_gso(skb)) { + if (skb_is_gso(skb) && sinfo->gso_type) { ? From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso Date: Thu, 13 Feb 2020 10:53:25 -0500 Message-ID: <20200213105010-mutt-send-email-mst@kernel.org> References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Eric Dumazet Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-um@lists.infradead.org, Anton Ivanov List-Id: virtualization@lists.linuxfoundation.org T24gVGh1LCBGZWIgMTMsIDIwMjAgYXQgMDc6NDQ6MDZBTSAtMDgwMCwgRXJpYyBEdW1hemV0IHdy b3RlOgo+IAo+IAo+IE9uIDIvMTMvMjAgMjowMCBBTSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl Ogo+ID4gT24gV2VkLCBGZWIgMTIsIDIwMjAgYXQgMDU6Mzg6MDlQTSArMDAwMCwgQW50b24gSXZh bm92IHdyb3RlOgo+ID4+Cj4gPj4KPiA+PiBPbiAxMS8wMi8yMDIwIDEwOjM3LCBNaWNoYWVsIFMu IFRzaXJraW4gd3JvdGU6Cj4gPj4+IE9uIFR1ZSwgRmViIDExLCAyMDIwIGF0IDA3OjQyOjM3QU0g KzAwMDAsIEFudG9uIEl2YW5vdiB3cm90ZToKPiA+Pj4+IE9uIDExLzAyLzIwMjAgMDI6NTEsIEph c29uIFdhbmcgd3JvdGU6Cj4gPj4+Pj4KPiA+Pj4+PiBPbiAyMDIwLzIvMTEg5LiK5Y2IMTI6NTUs IEFudG9uIEl2YW5vdiB3cm90ZToKPiA+Pj4+Pj4KPiA+Pj4+Pj4KPiA+Pj4+Pj4gT24gMDkvMTIv MjAxOSAxMDo0OCwgYW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbSB3cm90ZToKPiA+Pj4+ Pj4+IEZyb206IEFudG9uIEl2YW5vdiA8YW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbT4K PiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBTb21lIG9mIHRoZSBmcmFtZXMgbWFya2VkIGFzIEdTTyB3aGlj aCBhcnJpdmUgYXQKPiA+Pj4+Pj4+IHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKCkgaGF2ZSBubyBH U09fVFlQRSwgbm8KPiA+Pj4+Pj4+IGZyYWdtZW50cyAoZGF0YV9sZW4gPSAwKSBhbmQgbGVuZ3Ro IHNpZ25pZmljYW50bHkgc2hvcnRlcgo+ID4+Pj4+Pj4gdGhhbiB0aGUgTVRVICg3NTIgaW4gbXkg ZXhwZXJpbWVudHMpLgo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IFRoaXMgaXMgb2JzZXJ2ZWQgb24gcmF3 IHNvY2tldHMgcmVhZGluZyBvZmYgdkV0aCBpbnRlcmZhY2VzCj4gPj4+Pj4+PiBpbiBhbGwgNC54 IGFuZCA1Lngga2VybmVscyBJIHRlc3RlZC4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBUaGVzZSBmcmFt ZXMgYXJlIHJlcG9ydGVkIGFzIGludmFsaWQgd2hpbGUgdGhleSBhcmUgaW4gZmFjdAo+ID4+Pj4+ Pj4gZ3NvLWxlc3MgZnJhbWVzLgo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IFRoaXMgcGF0Y2ggbWFya3Mg dGhlIHZuZXQgaGVhZGVyIGFzIG5vLUdTTyBmb3IgdGhlbSBpbnN0ZWFkCj4gPj4+Pj4+PiBvZiBy ZXBvcnRpbmcgaXQgYXMgaW52YWxpZC4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBTaWduZWQtb2ZmLWJ5 OiBBbnRvbiBJdmFub3YgPGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5jb20+Cj4gPj4+Pj4+ PiAtLS0KPiA+Pj4+Pj4+ICDCoCBpbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaCB8IDggKysrKysr LS0KPiA+Pj4+Pj4+ICDCoCAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3Zp cnRpb19uZXQuaCBiL2luY2x1ZGUvbGludXgvdmlydGlvX25ldC5oCj4gPj4+Pj4+PiBpbmRleCAw ZDFmZTkyOTdhYzYuLmQ5MGQ1Y2ZmMWI5YSAxMDA2NDQKPiA+Pj4+Pj4+IC0tLSBhL2luY2x1ZGUv bGludXgvdmlydGlvX25ldC5oCj4gPj4+Pj4+PiArKysgYi9pbmNsdWRlL2xpbnV4L3ZpcnRpb19u ZXQuaAo+ID4+Pj4+Pj4gQEAgLTExMiw4ICsxMTIsMTIgQEAgc3RhdGljIGlubGluZSBpbnQKPiA+ Pj4+Pj4+IHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKGNvbnN0IHN0cnVjdCBza19idWZmICpza2Is Cj4gPj4+Pj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSA9IFZJ UlRJT19ORVRfSERSX0dTT19UQ1BWNDsKPiA+Pj4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgZWxz ZSBpZiAoc2luZm8tPmdzb190eXBlICYgU0tCX0dTT19UQ1BWNikKPiA+Pj4+Pj4+ICDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RD UFY2Owo+ID4+Pj4+Pj4gLcKgwqDCoMKgwqDCoMKgIGVsc2UKPiA+Pj4+Pj4+IC3CoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGVs c2Ugewo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHNrYi0+ZGF0YV9sZW4g PT0gMCkKPiA+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29f dHlwZSA9IFZJUlRJT19ORVRfSERSX0dTT19OT05FOwo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqAgZWxzZQo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gLUVJTlZBTDsKPiA+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB9Cj4gPj4+Pj4+PiAgwqDC oMKgwqDCoMKgwqDCoMKgIGlmIChzaW5mby0+Z3NvX3R5cGUgJiBTS0JfR1NPX1RDUF9FQ04pCj4g Pj4+Pj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSB8PSBWSVJU SU9fTkVUX0hEUl9HU09fRUNOOwo+ID4+Pj4+Pj4gIMKgwqDCoMKgwqAgfSBlbHNlCj4gPj4+Pj4+ Pgo+ID4+Pj4+Pgo+ID4+Pj4+PiBwaW5nLgo+ID4+Pj4+Pgo+ID4+Pj4+Cj4gPj4+Pj4gRG8geW91 IG1lYW4gZ3NvX3NpemUgaXMgc2V0IGJ1dCBnc29fdHlwZSBpcyBub3Q/IExvb2tzIGxpa2UgYSBi dWcKPiA+Pj4+PiBlbHNld2hlcmUuCj4gPj4+Pj4KPiA+Pj4+PiBUaGFua3MKPiA+Pj4+Pgo+ID4+ Pj4+Cj4gPj4+PiBZZXMuCj4gPj4+Pgo+ID4+Pj4gSSBjb3VsZCBub3QgdHJhY2UgaXQgd2hlcmUg aXQgaXMgY29taW5nIGZyb20uCj4gPj4+Pgo+ID4+Pj4gSSBzZWUgaXQgd2hlbiBkb2luZyByZWN2 bW1zZyBvbiByYXcgc29ja2V0cyBpbiB0aGUgVU1MIHZlY3RvciBuZXR3b3JrCj4gPj4+PiBkcml2 ZXJzLgo+ID4+Pj4KPiA+Pj4KPiA+Pj4gSSB0aGluayB3ZSBuZWVkIHRvIGZpbmQgdGhlIGN1bHBy aXQgYW5kIGZpeCBpdCB0aGVyZSwgbG90cyBvZiBvdGhlciB0aGluZ3MKPiA+Pj4gY2FuIGJyZWFr IG90aGVyd2lzZS4KPiA+Pj4gSnVzdCBwcmludGluZyBvdXQgc2tiLT5kZXYtPm5hbWUgc2hvdWxk IGRvIHRoZSB0cmljaywgbm8/Cj4gPj4KPiA+PiBUaGUgcHJpbnRrIGluIHZpcnRpb19uZXRfaGRy X2Zyb21fc2tiIHNheXMgTlVMTC4KPiA+Pgo+ID4+IFRoYXQgaXMgcHJvYmFibHkgbm9ybWFsIGZv ciBhIGxvY2FsbHkgb3JpZ2luYXRlZCBmcmFtZS4KPiA+Pgo+ID4+IEkgY2Fubm90IHJlcHJvZHVj ZSB0aGlzIHdpdGggbmV0d29yayB0cmFmZmljIGJ5IHRoZSB3YXkgLSBpdCBoYXBwZW5zIG9ubHkg aWYgdGhlIHRyYWZmaWMgaXMgbG9jYWxseSBvcmlnaW5hdGVkIG9uIHRoZSBob3N0Lgo+ID4+Cj4g Pj4gQSwKPiA+IAo+ID4gT0sgc28gaXMgaXQgY29kZSBpbiBfX3RjcF90cmFuc21pdF9za2IgdGhh dCBzZXRzIGdzb19zaXplIHRvIG5vbi1udWxsCj4gPiB3aGVuIGdzb190eXBlIGlzIDA/Cj4gPgo+ IAo+IENvcnJlY3Qgd2F5IHRvIGRldGVybWluZSBpZiBhIHBhY2tldCBpcyBhIGdzbyBvbmUgaXMg YnkgbG9va2luZyBhdCBnc29fc2l6ZS4KPiBUaGVuIG9ubHkgaXQgaXMgbGVnYWwgbG9va2luZyBh dCBnc29fdHlwZQo+IAo+IAo+IHN0YXRpYyBpbmxpbmUgYm9vbCBza2JfaXNfZ3NvKGNvbnN0IHN0 cnVjdCBza19idWZmICpza2IpCj4gewo+ICAgICByZXR1cm4gc2tiX3NoaW5mbyhza2IpLT5nc29f c2l6ZTsKPiB9Cj4gCj4gLyogTm90ZTogU2hvdWxkIGJlIGNhbGxlZCBvbmx5IGlmIHNrYl9pc19n c28oc2tiKSBpcyB0cnVlICovCj4gc3RhdGljIGlubGluZSBib29sIHNrYl9pc19nc29fdjYoY29u c3Qgc3RydWN0IHNrX2J1ZmYgKnNrYikKPiAuLi4KPiAKPiAKPiBUaGVyZSBpcyBhYnNvbHV0ZWx5 IG5vIHJlbGF0aW9uIGJldHdlZW4gR1NPIGFuZCBza2ItPmRhdGFfbGVuLCBza2IgY2FuIGJlIGxp bmVhcml6ZWQKPiBmb3IgdmFyaW91cyBvcnRob2dvbmFsIHJlYXNvbnMuCgpUaGUgcmVwb3J0ZWQg cHJvYmxlbSBpcyB0aGF0IHZpcnRpbyBnZXRzIGEgcGFja2V0IHdoZXJlIGdzb19zaXplCmlzICEw IGJ1dCBnc29fdHlwZSBpcyAwLgoKSXQgY3VycmVudGx5IGRyb3BzIHRoZXNlIG9uIHRoZSBhc3N1 bXB0aW9uIHRoYXQgaXQncyBzb21lIHR5cGUKb2YgYSBnc28gcGFja2V0IGl0IGRvZXMgbm90IGtu b3cgaG93IHRvIGhhbmRsZS4KCgpTbyB5b3UgYXJlIHNheWluZyBpZiBza2JfaXNfZ3NvIHdlIGNh biBzdGlsbCBoYXZlIGdzb190eXBlIHNldCB0byAwLAphbmQgdGhhdCdzIGFuIGV4cGVjdGVkIGNv bmZpZ3VyYXRpb24/CgpTbyB0aGUgcGF0Y2ggc2hvdWxkIGp1c3QgYmU6CgoKLSAgICAgICAgaWYg KHNrYl9pc19nc28oc2tiKSkgeworICAgICAgICBpZiAoc2tiX2lzX2dzbyhza2IpICYmIHNpbmZv LT5nc29fdHlwZSkgewoKCgo/CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3Jn L21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2Go3-0001Lh-1v for linux-um@lists.infradead.org; Thu, 13 Feb 2020 15:53:37 +0000 Received: by mail-qv1-f69.google.com with SMTP id z9so3751465qvo.10 for ; Thu, 13 Feb 2020 07:53:31 -0800 (PST) Date: Thu, 13 Feb 2020 10:53:25 -0500 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso Message-ID: <20200213105010-mutt-send-email-mst@kernel.org> References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> MIME-Version: 1.0 In-Reply-To: <94fb9656-99ee-a001-e428-9d76c3620e61@gmail.com> Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Eric Dumazet Cc: netdev@vger.kernel.org, Jason Wang , virtualization@lists.linux-foundation.org, linux-um@lists.infradead.org, Anton Ivanov T24gVGh1LCBGZWIgMTMsIDIwMjAgYXQgMDc6NDQ6MDZBTSAtMDgwMCwgRXJpYyBEdW1hemV0IHdy b3RlOgo+IAo+IAo+IE9uIDIvMTMvMjAgMjowMCBBTSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl Ogo+ID4gT24gV2VkLCBGZWIgMTIsIDIwMjAgYXQgMDU6Mzg6MDlQTSArMDAwMCwgQW50b24gSXZh bm92IHdyb3RlOgo+ID4+Cj4gPj4KPiA+PiBPbiAxMS8wMi8yMDIwIDEwOjM3LCBNaWNoYWVsIFMu IFRzaXJraW4gd3JvdGU6Cj4gPj4+IE9uIFR1ZSwgRmViIDExLCAyMDIwIGF0IDA3OjQyOjM3QU0g KzAwMDAsIEFudG9uIEl2YW5vdiB3cm90ZToKPiA+Pj4+IE9uIDExLzAyLzIwMjAgMDI6NTEsIEph c29uIFdhbmcgd3JvdGU6Cj4gPj4+Pj4KPiA+Pj4+PiBPbiAyMDIwLzIvMTEg5LiK5Y2IMTI6NTUs IEFudG9uIEl2YW5vdiB3cm90ZToKPiA+Pj4+Pj4KPiA+Pj4+Pj4KPiA+Pj4+Pj4gT24gMDkvMTIv MjAxOSAxMDo0OCwgYW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbSB3cm90ZToKPiA+Pj4+ Pj4+IEZyb206IEFudG9uIEl2YW5vdiA8YW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbT4K PiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBTb21lIG9mIHRoZSBmcmFtZXMgbWFya2VkIGFzIEdTTyB3aGlj aCBhcnJpdmUgYXQKPiA+Pj4+Pj4+IHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKCkgaGF2ZSBubyBH U09fVFlQRSwgbm8KPiA+Pj4+Pj4+IGZyYWdtZW50cyAoZGF0YV9sZW4gPSAwKSBhbmQgbGVuZ3Ro IHNpZ25pZmljYW50bHkgc2hvcnRlcgo+ID4+Pj4+Pj4gdGhhbiB0aGUgTVRVICg3NTIgaW4gbXkg ZXhwZXJpbWVudHMpLgo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IFRoaXMgaXMgb2JzZXJ2ZWQgb24gcmF3 IHNvY2tldHMgcmVhZGluZyBvZmYgdkV0aCBpbnRlcmZhY2VzCj4gPj4+Pj4+PiBpbiBhbGwgNC54 IGFuZCA1Lngga2VybmVscyBJIHRlc3RlZC4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBUaGVzZSBmcmFt ZXMgYXJlIHJlcG9ydGVkIGFzIGludmFsaWQgd2hpbGUgdGhleSBhcmUgaW4gZmFjdAo+ID4+Pj4+ Pj4gZ3NvLWxlc3MgZnJhbWVzLgo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IFRoaXMgcGF0Y2ggbWFya3Mg dGhlIHZuZXQgaGVhZGVyIGFzIG5vLUdTTyBmb3IgdGhlbSBpbnN0ZWFkCj4gPj4+Pj4+PiBvZiBy ZXBvcnRpbmcgaXQgYXMgaW52YWxpZC4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBTaWduZWQtb2ZmLWJ5 OiBBbnRvbiBJdmFub3YgPGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5jb20+Cj4gPj4+Pj4+ PiAtLS0KPiA+Pj4+Pj4+ICDCoCBpbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaCB8IDggKysrKysr LS0KPiA+Pj4+Pj4+ICDCoCAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQo+ID4+Pj4+Pj4KPiA+Pj4+Pj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3Zp cnRpb19uZXQuaCBiL2luY2x1ZGUvbGludXgvdmlydGlvX25ldC5oCj4gPj4+Pj4+PiBpbmRleCAw ZDFmZTkyOTdhYzYuLmQ5MGQ1Y2ZmMWI5YSAxMDA2NDQKPiA+Pj4+Pj4+IC0tLSBhL2luY2x1ZGUv bGludXgvdmlydGlvX25ldC5oCj4gPj4+Pj4+PiArKysgYi9pbmNsdWRlL2xpbnV4L3ZpcnRpb19u ZXQuaAo+ID4+Pj4+Pj4gQEAgLTExMiw4ICsxMTIsMTIgQEAgc3RhdGljIGlubGluZSBpbnQKPiA+ Pj4+Pj4+IHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKGNvbnN0IHN0cnVjdCBza19idWZmICpza2Is Cj4gPj4+Pj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSA9IFZJ UlRJT19ORVRfSERSX0dTT19UQ1BWNDsKPiA+Pj4+Pj4+ICDCoMKgwqDCoMKgwqDCoMKgwqAgZWxz ZSBpZiAoc2luZm8tPmdzb190eXBlICYgU0tCX0dTT19UQ1BWNikKPiA+Pj4+Pj4+ICDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RD UFY2Owo+ID4+Pj4+Pj4gLcKgwqDCoMKgwqDCoMKgIGVsc2UKPiA+Pj4+Pj4+IC3CoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGVs c2Ugewo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHNrYi0+ZGF0YV9sZW4g PT0gMCkKPiA+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29f dHlwZSA9IFZJUlRJT19ORVRfSERSX0dTT19OT05FOwo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqAgZWxzZQo+ID4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gLUVJTlZBTDsKPiA+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB9Cj4gPj4+Pj4+PiAgwqDC oMKgwqDCoMKgwqDCoMKgIGlmIChzaW5mby0+Z3NvX3R5cGUgJiBTS0JfR1NPX1RDUF9FQ04pCj4g Pj4+Pj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSB8PSBWSVJU SU9fTkVUX0hEUl9HU09fRUNOOwo+ID4+Pj4+Pj4gIMKgwqDCoMKgwqAgfSBlbHNlCj4gPj4+Pj4+ Pgo+ID4+Pj4+Pgo+ID4+Pj4+PiBwaW5nLgo+ID4+Pj4+Pgo+ID4+Pj4+Cj4gPj4+Pj4gRG8geW91 IG1lYW4gZ3NvX3NpemUgaXMgc2V0IGJ1dCBnc29fdHlwZSBpcyBub3Q/IExvb2tzIGxpa2UgYSBi dWcKPiA+Pj4+PiBlbHNld2hlcmUuCj4gPj4+Pj4KPiA+Pj4+PiBUaGFua3MKPiA+Pj4+Pgo+ID4+ Pj4+Cj4gPj4+PiBZZXMuCj4gPj4+Pgo+ID4+Pj4gSSBjb3VsZCBub3QgdHJhY2UgaXQgd2hlcmUg aXQgaXMgY29taW5nIGZyb20uCj4gPj4+Pgo+ID4+Pj4gSSBzZWUgaXQgd2hlbiBkb2luZyByZWN2 bW1zZyBvbiByYXcgc29ja2V0cyBpbiB0aGUgVU1MIHZlY3RvciBuZXR3b3JrCj4gPj4+PiBkcml2 ZXJzLgo+ID4+Pj4KPiA+Pj4KPiA+Pj4gSSB0aGluayB3ZSBuZWVkIHRvIGZpbmQgdGhlIGN1bHBy aXQgYW5kIGZpeCBpdCB0aGVyZSwgbG90cyBvZiBvdGhlciB0aGluZ3MKPiA+Pj4gY2FuIGJyZWFr IG90aGVyd2lzZS4KPiA+Pj4gSnVzdCBwcmludGluZyBvdXQgc2tiLT5kZXYtPm5hbWUgc2hvdWxk IGRvIHRoZSB0cmljaywgbm8/Cj4gPj4KPiA+PiBUaGUgcHJpbnRrIGluIHZpcnRpb19uZXRfaGRy X2Zyb21fc2tiIHNheXMgTlVMTC4KPiA+Pgo+ID4+IFRoYXQgaXMgcHJvYmFibHkgbm9ybWFsIGZv ciBhIGxvY2FsbHkgb3JpZ2luYXRlZCBmcmFtZS4KPiA+Pgo+ID4+IEkgY2Fubm90IHJlcHJvZHVj ZSB0aGlzIHdpdGggbmV0d29yayB0cmFmZmljIGJ5IHRoZSB3YXkgLSBpdCBoYXBwZW5zIG9ubHkg aWYgdGhlIHRyYWZmaWMgaXMgbG9jYWxseSBvcmlnaW5hdGVkIG9uIHRoZSBob3N0Lgo+ID4+Cj4g Pj4gQSwKPiA+IAo+ID4gT0sgc28gaXMgaXQgY29kZSBpbiBfX3RjcF90cmFuc21pdF9za2IgdGhh dCBzZXRzIGdzb19zaXplIHRvIG5vbi1udWxsCj4gPiB3aGVuIGdzb190eXBlIGlzIDA/Cj4gPgo+ IAo+IENvcnJlY3Qgd2F5IHRvIGRldGVybWluZSBpZiBhIHBhY2tldCBpcyBhIGdzbyBvbmUgaXMg YnkgbG9va2luZyBhdCBnc29fc2l6ZS4KPiBUaGVuIG9ubHkgaXQgaXMgbGVnYWwgbG9va2luZyBh dCBnc29fdHlwZQo+IAo+IAo+IHN0YXRpYyBpbmxpbmUgYm9vbCBza2JfaXNfZ3NvKGNvbnN0IHN0 cnVjdCBza19idWZmICpza2IpCj4gewo+ICAgICByZXR1cm4gc2tiX3NoaW5mbyhza2IpLT5nc29f c2l6ZTsKPiB9Cj4gCj4gLyogTm90ZTogU2hvdWxkIGJlIGNhbGxlZCBvbmx5IGlmIHNrYl9pc19n c28oc2tiKSBpcyB0cnVlICovCj4gc3RhdGljIGlubGluZSBib29sIHNrYl9pc19nc29fdjYoY29u c3Qgc3RydWN0IHNrX2J1ZmYgKnNrYikKPiAuLi4KPiAKPiAKPiBUaGVyZSBpcyBhYnNvbHV0ZWx5 IG5vIHJlbGF0aW9uIGJldHdlZW4gR1NPIGFuZCBza2ItPmRhdGFfbGVuLCBza2IgY2FuIGJlIGxp bmVhcml6ZWQKPiBmb3IgdmFyaW91cyBvcnRob2dvbmFsIHJlYXNvbnMuCgpUaGUgcmVwb3J0ZWQg cHJvYmxlbSBpcyB0aGF0IHZpcnRpbyBnZXRzIGEgcGFja2V0IHdoZXJlIGdzb19zaXplCmlzICEw IGJ1dCBnc29fdHlwZSBpcyAwLgoKSXQgY3VycmVudGx5IGRyb3BzIHRoZXNlIG9uIHRoZSBhc3N1 bXB0aW9uIHRoYXQgaXQncyBzb21lIHR5cGUKb2YgYSBnc28gcGFja2V0IGl0IGRvZXMgbm90IGtu b3cgaG93IHRvIGhhbmRsZS4KCgpTbyB5b3UgYXJlIHNheWluZyBpZiBza2JfaXNfZ3NvIHdlIGNh biBzdGlsbCBoYXZlIGdzb190eXBlIHNldCB0byAwLAphbmQgdGhhdCdzIGFuIGV4cGVjdGVkIGNv bmZpZ3VyYXRpb24/CgpTbyB0aGUgcGF0Y2ggc2hvdWxkIGp1c3QgYmU6CgoKLSAgICAgICAgaWYg KHNrYl9pc19nc28oc2tiKSkgeworICAgICAgICBpZiAoc2tiX2lzX2dzbyhza2IpICYmIHNpbmZv LT5nc29fdHlwZSkgewoKCgo/CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11 bQo=