From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD99C2BA83 for ; Thu, 13 Feb 2020 12:10:41 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 149132073C for ; Thu, 13 Feb 2020 12:10:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 149132073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69BBF1BFB6; Thu, 13 Feb 2020 13:10:40 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A48DC1BFA5; Thu, 13 Feb 2020 13:10:38 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 04:10:37 -0800 X-IronPort-AV: E=Sophos;i="5.70,436,1574150400"; d="scan'208";a="227215477" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 13 Feb 2020 04:10:35 -0800 Date: Thu, 13 Feb 2020 12:10:32 +0000 From: Bruce Richardson To: Ciara Power Cc: dev@dpdk.org, pawelx.modrak@intel.com, stable@dpdk.org Message-ID: <20200213121032.GB845@bricha3-MOBL.ger.corp.intel.com> References: <20200204160156.64773-1-ciara.power@intel.com> <20200207102402.24396-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200207102402.24396-1-ciara.power@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v2] examples/ioat: fix invalid link status check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 07, 2020 at 10:24:02AM +0000, Ciara Power wrote: > The return value of the get link function call was not checked, and > could return a negative value indicating a failure. This meant the > link_status of the link being checked is invalid, because the link was > not filled with data. The return value is now checked, and if the return > value is not 0 for success, the loop continues with the next port. > > To avoid confusion between variable names, the existing retval variable > is renamed to link_status, to better represent its use. > > Coverity issue: 350348 > Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver") > Cc: pawelx.modrak@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power > Acked-by: Bruce Richardson