From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3443C2BA83 for ; Thu, 13 Feb 2020 12:28:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F84F218AC for ; Thu, 13 Feb 2020 12:28:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XXgMppd4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F84F218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9D5F5165D; Thu, 13 Feb 2020 13:27:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9D5F5165D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581596886; bh=4qVn7YU+FDFdSXW2EdeerdCC5qpbrEA3tacH98/hXt0=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XXgMppd4ntlSIloJoQ4T4a+5dww+f+xJpjUZwP/6XUqaHkiKf5phGQGW4sD/1y9Zh 1nUwg49GsO7TUBfT/CpbrKWXU63+32N0B7wjndGFU6F6QBZNpDZfpAoxluMxyiyB5H mq3AEbvpHETIc4eeEjTRvqdeNN1uxbi5vVPBCyto= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 311BFF80138; Thu, 13 Feb 2020 13:27:16 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2E5E4F80145; Thu, 13 Feb 2020 13:27:14 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id DFA29F80139 for ; Thu, 13 Feb 2020 13:27:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DFA29F80139 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73D3A1FB; Thu, 13 Feb 2020 04:27:10 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB91F3F6CF; Thu, 13 Feb 2020 04:27:09 -0800 (PST) Date: Thu, 13 Feb 2020 12:27:08 +0000 From: Mark Brown To: Tzung-Bi Shih Message-ID: <20200213122708.GE4333@sirena.org.uk> References: <20200213032728.199462-1-tzungbi@google.com> <20200213112003.4.Ia542007f51d3de753a9e0a83135ee074581dbf71@changeid> MIME-Version: 1.0 In-Reply-To: <20200213112003.4.Ia542007f51d3de753a9e0a83135ee074581dbf71@changeid> X-Cookie: Academicians care, that's who. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, dgreid@google.com, cychiang@google.com Subject: Re: [alsa-devel] [RESEND PATCH 4/4] ASoC: mediatek: mt8183-da7219: apply some refactors X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2432486108027511647==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============2432486108027511647== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="G6nVm6DDWH/FONJq" Content-Disposition: inline --G6nVm6DDWH/FONJq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 13, 2020 at 11:27:28AM +0800, Tzung-Bi Shih wrote: > 1. Moves headset jack to card-specific storage. > 2. Removes trailing blank line. > 3. Moves card registration to the end of probe. I'll apply this but it feels like it should be at least two patches - if you're writing a changelog with numbered changes like this it's a big warning sign. --G6nVm6DDWH/FONJq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5FQJsACgkQJNaLcl1U h9Aidgf+JwrAqdcozzfnMI6mZlMZXWd5pDVALFrkeGrP0hSK0gI4U4Fj4G6tIzvV C2Yx83socKmi5lGDsAGsWCYZk9uzzqziCpkzVe9hk4sleRKClHcsWyr4gija4K1o AVNsQxNghzdU+ATZ9A2frExvYoKo9T1P1TNlhOz4gyMRZwAIBgVHGIcF6WHfisEB z0Ll/I24+pT8vj99s0ubtwrKmotS2UMMGy404sEQSI8Wpnv/RUtGShSUPBvlqwk+ YG4m3wje9+7jhw4M86bliJi7fteRkZNQPhGKLAYy8PuSUZk4fnSFrCB+hNuVBxcj lKJOeFrdHO1NWtvmyYZRjmQDUJCcWA== =3AId -----END PGP SIGNATURE----- --G6nVm6DDWH/FONJq-- --===============2432486108027511647== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============2432486108027511647==--