From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86EB5C2BA83 for ; Thu, 13 Feb 2020 14:01:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BA4B2073C for ; Thu, 13 Feb 2020 14:01:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="quL/ByWr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730218AbgBMOBf (ORCPT ); Thu, 13 Feb 2020 09:01:35 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:44248 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730036AbgBMOBf (ORCPT ); Thu, 13 Feb 2020 09:01:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dBPcaumofvER+ysc/5YzhCD8WPvgMzyqDiq0EqFZH28=; b=quL/ByWr5NLXCoyC0GNZJfknyY FFGV85ZDYk01LlJl52CmTeqemXxZg8ChC81Zcok4VUVKsAuMuefv61CKkCcTn5QJgOIrLrN5DWYQr fnmlizbHuKnPK8pqWuMB+7Q9qsJUuVDZJSrICgGbEAGseM6pMjhcEhaPmX8oWaXWGUyY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j2F3c-0003Iq-VA; Thu, 13 Feb 2020 15:01:32 +0100 Date: Thu, 13 Feb 2020 15:01:32 +0100 From: Andrew Lunn To: Per@axis.com, Forlin Cc: netdev@vger.kernel.org, o.rempel@pengutronix.de, davem@davemloft.net, Per Forlin , Per Forlin Subject: Re: [PATCH net 1/2] net: dsa: tag_qca: Make sure there is headroom for tag Message-ID: <20200213140132.GC12151@lunn.ch> References: <20200213135100.2963-1-per.forlin@axis.com> <20200213135100.2963-2-per.forlin@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200213135100.2963-2-per.forlin@axis.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 13, 2020 at 02:50:59PM +0100, Per@axis.com wrote: > From: Per Forlin > > Passing tag size to skb_cow_head will make sure > there is enough headroom for the tag data. > This change does not introduce any overhead in case there > is already available headroom for tag. > > Signed-off-by: Per Forlin Hi Per If these are for net, you need a Fixes: tag. Also, you should add the Reivewed-by: tags i gave for these patches. Andrew