From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A19C3B189 for ; Thu, 13 Feb 2020 15:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECBC82469A for ; Thu, 13 Feb 2020 15:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607398; bh=kanQ/mCG5wDkKu+r5IT/E563GzDRLbbAXBk1dBOccZU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JEgcHn4NXNTm9RI41uMmfM7mDyVActKk91I4FyiY4uCk+xoekHA+HLULaOUAJMmzr d3wCnBCG1rEvfk98iNDe1/Fx7NOxLaT1EDdHhx9gTYRCtobzCSDDNCW2TvD4jP1oP6 m3pq1/YuCl1KtJmvUHgiBV9m1CDXhiHej7OHlDjA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728327AbgBMPXQ (ORCPT ); Thu, 13 Feb 2020 10:23:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:32858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728162AbgBMPWv (ORCPT ); Thu, 13 Feb 2020 10:22:51 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF13724689; Thu, 13 Feb 2020 15:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607371; bh=kanQ/mCG5wDkKu+r5IT/E563GzDRLbbAXBk1dBOccZU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u+r6z/VYqaRmtyLpaTWcYNSVIKNBqnyKmh1xurWYYWcQER//SEWMz02AP5yJWR3Uu 6oj/PYnVDkLZ69nB5Pg620J6pc7u4ZiQlp6K2eVvvKXrpQL68TwncyJVMx0MSCovrz LNmLd94WFVWLRd/B4MpK9t6fabC+QOS3WTxbkPZ0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Greg Kurz , Sean Christopherson , Paul Mackerras , Paolo Bonzini Subject: [PATCH 4.4 45/91] KVM: PPC: Book3S PR: Free shared page if mmu initialization fails Date: Thu, 13 Feb 2020 07:20:02 -0800 Message-Id: <20200213151839.034371359@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151821.384445454@linuxfoundation.org> References: <20200213151821.384445454@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Christopherson commit cb10bf9194f4d2c5d830eddca861f7ca0fecdbb4 upstream. Explicitly free the shared page if kvmppc_mmu_init() fails during kvmppc_core_vcpu_create(), as the page is freed only in kvmppc_core_vcpu_free(), which is not reached via kvm_vcpu_uninit(). Fixes: 96bc451a15329 ("KVM: PPC: Introduce shared page") Cc: stable@vger.kernel.org Reviewed-by: Greg Kurz Signed-off-by: Sean Christopherson Acked-by: Paul Mackerras Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/kvm/book3s_pr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/arch/powerpc/kvm/book3s_pr.c +++ b/arch/powerpc/kvm/book3s_pr.c @@ -1434,10 +1434,12 @@ static struct kvm_vcpu *kvmppc_core_vcpu err = kvmppc_mmu_init(vcpu); if (err < 0) - goto uninit_vcpu; + goto free_shared_page; return vcpu; +free_shared_page: + free_page((unsigned long)vcpu->arch.shared); uninit_vcpu: kvm_vcpu_uninit(vcpu); free_shadow_vcpu: