From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, James Smart <jsmart2021@gmail.com>
Subject: [PATCH] fc: fix fpin_els build breakage
Date: Thu, 13 Feb 2020 14:40:42 -0800 [thread overview]
Message-ID: <20200213224042.26986-1-jsmart2021@gmail.com> (raw)
Kbuild reported the following error:
All error/warnings (new ones prefixed by >>):
In file included from <command-line>:32:0:
./usr/include/scsi/fc/fc_els.h: In function 'fc_tlv_next_desc':
>> ./usr/include/scsi/fc/fc_els.h:274:4: error: implicit declaration of
function 'be32_to_cpu'; did you mean '__be32_to_cpu'?
[-Werror=implicit-function-declaration]
(be32_to_cpu((tlv)->desc_len) + FC_TLV_DESC_HDR_SZ)
^
>> ./usr/include/scsi/fc/fc_els.h:286:17: note: in expansion of macro
'FC_TLV_DESC_SZ_FROM_LENGTH'
return (desc + FC_TLV_DESC_SZ_FROM_LENGTH(tlv));
^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Fix by converting fc_tlv_next_desc to use __be32_to_cpu().
Signed-off-by: James Smart <jsmart2021@gmail.com>
Reported-by: kbuild test robot <lkp@intel.com>
---
include/uapi/scsi/fc/fc_els.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/scsi/fc/fc_els.h b/include/uapi/scsi/fc/fc_els.h
index 10b609a2f863..66318c44acd7 100644
--- a/include/uapi/scsi/fc/fc_els.h
+++ b/include/uapi/scsi/fc/fc_els.h
@@ -271,7 +271,7 @@ struct fc_tlv_desc {
/* Macro, used on received payloads, to return the descriptor length */
#define FC_TLV_DESC_SZ_FROM_LENGTH(tlv) \
- (be32_to_cpu((tlv)->desc_len) + FC_TLV_DESC_HDR_SZ)
+ (__be32_to_cpu((tlv)->desc_len) + FC_TLV_DESC_HDR_SZ)
/*
* This helper is used to walk descriptors in a descriptor list.
--
2.13.7
next reply other threads:[~2020-02-13 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 22:40 James Smart [this message]
2020-02-14 7:33 ` [PATCH] fc: fix fpin_els build breakage Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213224042.26986-1-jsmart2021@gmail.com \
--to=jsmart2021@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.