From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49365C2BA83 for ; Fri, 14 Feb 2020 14:29:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A97F2187F for ; Fri, 14 Feb 2020 14:29:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V+Kkwox+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N9UeXtEj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A97F2187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nl3lLqFQhydWQQ4s20dmS32QZJuxKiqoFQbQKZPKHe4=; b=V+Kkwox+2TY8Hr s6awzpyN5peEtwmNIhw62t6ROfviJR0+xyUUjEOeqwRWrzqfwMjSkO5jVXRerU1ZzWXeSTip7s1QZ TCVtvdJeEtuiqQZHrNKMb06OyKej8Me6Ov6YM/2LyE3RXsAaZNkOA4kuf4mA9GssBLvpmcCdK2uwC DDnrMq0wolTi7gCrbTyyjVv6qi6FW3h0QWhi+IzjeKJAXmHq6C/a1NHB6v8iVpHA+Hj0zW/VXy8W/ Qo56gx2Q1k7eVyfky2LgNbLpkJoy+EIP8QR1jy4FotIGAx8w5c2+jJO6RgOpVmJvfsev/IANIf7wZ ozhTwgc6BZzBAR1v1cZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2byc-0000s7-A5; Fri, 14 Feb 2020 14:29:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2bya-0000rl-3w for linux-nvme@lists.infradead.org; Fri, 14 Feb 2020 14:29:53 +0000 Received: from redsun51.ssa.fujisawa.hgst.com (unknown [199.255.47.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 414BD2168B; Fri, 14 Feb 2020 14:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581690591; bh=BV0TVDmo7Y2EP/tkJUOPVFfO9ED38vm0i1ntGPQTCDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N9UeXtEjyttE5eQ/u1CbjLbwN1a15I9iGXN5ZUuEHp5zXwwxtAu/nreQv5N++e0je NNUSGHmYgzveuRU0AaDt1aLuNHOU/TEaE+9TqcwBxbh//MzSOYgY0BDV8wsMPQQ62C dO2kM5qIKTh1JTge0uCU3RCZ9G2/xehwTegIz228= Date: Fri, 14 Feb 2020 23:29:48 +0900 From: Keith Busch To: Sagi Grimberg Subject: Re: [PATCH 1/2] fabrics: ignore hostnqn file if its empty Message-ID: <20200214142948.GC9819@redsun51.ssa.fujisawa.hgst.com> References: <20200212200158.14237-1-sagi@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200212200158.14237-1-sagi@grimberg.me> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_062952_179941_83AA81B4 X-CRM114-Status: GOOD ( 10.39 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Feb 12, 2020 at 12:01:57PM -0800, Sagi Grimberg wrote: > If we read an empty string from /etc/nvme/hostnqn we should > ignore it instead of passing an empty string to the > driver resulting in the error: > > nvme_fabrics: unknown parameter or missing value 'hostnqn=' in ctrl creation request > > Signed-off-by: Sagi Grimberg Thanks, both patches applied. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme