From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A46C35242 for ; Fri, 14 Feb 2020 20:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6014522314 for ; Fri, 14 Feb 2020 20:50:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HUhU9ihK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389843AbgBNUuL (ORCPT ); Fri, 14 Feb 2020 15:50:11 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50596 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388650AbgBNUs6 (ORCPT ); Fri, 14 Feb 2020 15:48:58 -0500 Received: by mail-wm1-f66.google.com with SMTP id a5so11325884wmb.0; Fri, 14 Feb 2020 12:48:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QfadLLWZFDK0HW1MeHL/yYg616BevIp9ZGw1GPPO0/0=; b=HUhU9ihKMpebXnodYzcr6vYwtC8bdpB8oxQa8rtJBmB+xksqy8O2aLAF5UvjeiPmul LC1xq8Ngplhb4m01IXk/MPBsKXi6Oi5iFFiwnrJ6glSe0/YsYX7ttf8UOqS2Z4ZeLoT7 HhngVua4KhpJ8+4hbEIxVgypcvHitU+7cOwW0zswVD1CsYtzLiAVAjNVpRm8kzdvf9Tt pg5C/5oQLIHwWxSWbI522Fn8yRQELqi0baz07ePgjCufAVKiTf3c6Oi9kZYzz+D6oGxP RqRPoIjR/a8pS0OsONbxqrgBwLEWwal///NREZDYCIev3zgbaHic/A7kdhUpqm1kkPA+ TWPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QfadLLWZFDK0HW1MeHL/yYg616BevIp9ZGw1GPPO0/0=; b=TwSQ/WqOixe4ukkOZ5ZJtZEuH/UDGBTuXxJswV52P7vABBwo6df752UasOTcm0tkaC wLgG9uba5vbSC3qWOn193mQ/a9MVxXfdT44oSpgoVNldpJ6QdZtch4xgyQgLMNPfICE2 Ckdwn5jqiiCecePtujdmRlT0FrMDKbJTL1maqZCwzA1ONGP23cuuO57SC2tlNXG4Ip6q J0KVECGnLexB8O3gj0e8ZDvzwGPIvUuoCW/lggvX77MZcD7ZxnWu4QM8gMXWnDqBYYUU ZuEXOkzvD7I9q9qkNeCWqg5NqHqkpyC+PM9h2/2PckSGKJR7GPvAO2RBfZNIS6OzR4Cr u0KA== X-Gm-Message-State: APjAAAUlcmkldXVMPupsJkMaE723ro+7ezQjln45E/jZ/rS90HfeIW/+ 4EHEFGsBSwB6/6K6xhA208U1+8QOXQPE X-Google-Smtp-Source: APXvYqxniUnwEd16DVrtt5snPqjC+/Ihrq2d/flim0WgiDRCJIaJFWNV03e83MZL/2lm6myw25ihTg== X-Received: by 2002:a7b:c851:: with SMTP id c17mr6313167wml.71.1581713335973; Fri, 14 Feb 2020 12:48:55 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:55 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Don Fry , "David S. Miller" , netdev@vger.kernel.org (open list:PCNET32 NETWORK DRIVER) Subject: [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Date: Fri, 14 Feb 2020 20:47:31 +0000 Message-Id: <20200214204741.94112-21-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at pcnet32_suspend() warning: context imbalance in pcnet32_suspend() - unexpected unlock The root cause is the missing annotation at pcnet32_suspend() Add the missing __must_hold(&lp->lock) annotattion Signed-off-by: Jules Irenge --- drivers/net/ethernet/amd/pcnet32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index dc7d88227e76..ac6c19441932 100644 --- a/drivers/net/ethernet/amd/pcnet32.c +++ b/drivers/net/ethernet/amd/pcnet32.c @@ -684,7 +684,7 @@ static void pcnet32_poll_controller(struct net_device *dev) * lp->lock must be held. */ static int pcnet32_suspend(struct net_device *dev, unsigned long *flags, - int can_sleep) + int can_sleep) __must_hold(&lp->lock) { int csr5; struct pcnet32_private *lp = netdev_priv(dev); -- 2.24.1