From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D54C3F68F for ; Fri, 14 Feb 2020 20:48:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF9AA24670 for ; Fri, 14 Feb 2020 20:48:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O5ir4u/a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387576AbgBNUsj (ORCPT ); Fri, 14 Feb 2020 15:48:39 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:39302 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727742AbgBNUsh (ORCPT ); Fri, 14 Feb 2020 15:48:37 -0500 Received: by mail-wm1-f66.google.com with SMTP id c84so12167780wme.4; Fri, 14 Feb 2020 12:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XQbKLQ9ukje1bT/FheNFvSXPv2JzfMKZr476ojL2Is0=; b=O5ir4u/aNTfUulqZgaK74Gu8mBBzIqrjfADgTPMzLTzu1KAaf5QhfiF7kasEvy5r4K ErG2wMyrU7UIe0OHtzQefP/ASrTS2xW6pdSXgvPTDid60F1YgIP5XLH4vSUw/PECCgGv Pa4cg3cKyKakJj7xVxQ0ei/Rp6Od561Ee9nLUyaY5bPJGHcMYlszGui/5WsNIo3AiOp1 8chcGs06TgYmRm4OU+BMsaiPP3+fjTxtzTIDU6vJLXvT8YZ9sTd+TmxgjbbvPUsJaof9 8qPho5ezQRvGRyFcOCnQK+B6YW4RPQhq9zuSANGmyzBFVnDjnlJ6D97CHQo2DeXk/VHs Lxlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XQbKLQ9ukje1bT/FheNFvSXPv2JzfMKZr476ojL2Is0=; b=FQnrB4MbinrfrYJadZtraXZWNFWyaHoKFzzcVMUiQC3t7AnEIfnRfJMrDccbCV4ngk jtn96ISMli6pLbMpBtcKj5jINrCbDxP9SYaVqxf0pKRUsINKN4WzFf5BSy2jU4LmoMbP xymaaHXQg9+KjI85pBS+xmGBJHS8IIW1QCAcr2urtnJwJ99v7oQ5yV8yaielFhkPDS7s R4XTad31ppC6XFM2A0n05hO6DmkRxuqkjt70gPOlRqt+XmR0rBa9WxOd6Rr0efBWCHaY UCX7VQACMf0ZOzBaL93YLKoT4vPBc6oCKXvwqnWMHKzMxQln1mEzMPknMZ11P+k1T2nA idNQ== X-Gm-Message-State: APjAAAX/1pJC27sDAtChonmsAQu0cMWN6gEJis6IKu3mlPJt2o76v++k FIfaokMR1Jq4+BwFKpIhbC53BD9bX5QS X-Google-Smtp-Source: APXvYqzDv6V1/vR7pqSlQ0ZZe6UVzBWl6YQ5gh8Uk6kepa8dWWi2wm55mdwrZhSCm7+OaCMs66lDZA== X-Received: by 2002:a7b:c759:: with SMTP id w25mr6358657wmk.15.1581713314492; Fri, 14 Feb 2020 12:48:34 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:34 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: [PATCH 04/30] mm/memcontrol: Add missing annotation for lock_page_lru() Date: Fri, 14 Feb 2020 20:47:15 +0000 Message-Id: <20200214204741.94112-5-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports warning at lock_page_lry() warning: context imbalance in lock_page_lru() - wrong count at exit The root cause is the missing annotation at lock_page_lru() Add the missing __acquires(&pgdat->lru_lock) Signed-off-by: Jules Irenge --- mm/memcontrol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 22ddd557a69b..67dc9f1af0bf 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2571,6 +2571,7 @@ static void cancel_charge(struct mem_cgroup *memcg, unsigned int nr_pages) } static void lock_page_lru(struct page *page, int *isolated) + __acquires(&pgdat->lru_lock) { pg_data_t *pgdat = page_pgdat(page); -- 2.24.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jules Irenge Subject: [PATCH 04/30] mm/memcontrol: Add missing annotation for lock_page_lru() Date: Fri, 14 Feb 2020 20:47:15 +0000 Message-ID: <20200214204741.94112-5-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XQbKLQ9ukje1bT/FheNFvSXPv2JzfMKZr476ojL2Is0=; b=O5ir4u/aNTfUulqZgaK74Gu8mBBzIqrjfADgTPMzLTzu1KAaf5QhfiF7kasEvy5r4K ErG2wMyrU7UIe0OHtzQefP/ASrTS2xW6pdSXgvPTDid60F1YgIP5XLH4vSUw/PECCgGv Pa4cg3cKyKakJj7xVxQ0ei/Rp6Od561Ee9nLUyaY5bPJGHcMYlszGui/5WsNIo3AiOp1 8chcGs06TgYmRm4OU+BMsaiPP3+fjTxtzTIDU6vJLXvT8YZ9sTd+TmxgjbbvPUsJaof9 8qPho5ezQRvGRyFcOCnQK+B6YW4RPQhq9zuSANGmyzBFVnDjnlJ6D97CHQo2DeXk/VHs Lxlg== In-Reply-To: <20200214204741.94112-1-jbi.octave-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: boqun.feng-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Jules Irenge , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER MEMCG" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER MEMCG" Sparse reports warning at lock_page_lry() warning: context imbalance in lock_page_lru() - wrong count at exit The root cause is the missing annotation at lock_page_lru() Add the missing __acquires(&pgdat->lru_lock) Signed-off-by: Jules Irenge --- mm/memcontrol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 22ddd557a69b..67dc9f1af0bf 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2571,6 +2571,7 @@ static void cancel_charge(struct mem_cgroup *memcg, unsigned int nr_pages) } static void lock_page_lru(struct page *page, int *isolated) + __acquires(&pgdat->lru_lock) { pg_data_t *pgdat = page_pgdat(page); -- 2.24.1