From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5900C7619B for ; Mon, 17 Feb 2020 02:37:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9587622522 for ; Mon, 17 Feb 2020 02:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726663AbgBQChc (ORCPT ); Sun, 16 Feb 2020 21:37:32 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47850 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726656AbgBQChc (ORCPT ); Sun, 16 Feb 2020 21:37:32 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A80BE15383A6E; Sun, 16 Feb 2020 18:37:31 -0800 (PST) Date: Sun, 16 Feb 2020 18:37:31 -0800 (PST) Message-Id: <20200216.183731.2157450869886971370.davem@davemloft.net> To: jhubbard@nvidia.com Cc: akpm@linux-foundation.org, santosh.shilimkar@oracle.com, hans.westgaard.ry@oracle.com, leonro@mellanox.com, kuba@kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] net/rds: Track user mapped pages through special API From: David Miller In-Reply-To: <20200212030355.1600749-2-jhubbard@nvidia.com> References: <20200212030355.1600749-1-jhubbard@nvidia.com> <20200212030355.1600749-2-jhubbard@nvidia.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 16 Feb 2020 18:37:32 -0800 (PST) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: John Hubbard Date: Tue, 11 Feb 2020 19:03:55 -0800 > From: Leon Romanovsky > > Convert net/rds to use the newly introduces pin_user_pages() API, > which properly sets FOLL_PIN. Setting FOLL_PIN is now required for > code that requires tracking of pinned pages. > > Note that this effectively changes the code's behavior: it now > ultimately calls set_page_dirty_lock(), instead of set_page_dirty(). > This is probably more accurate. > > As Christoph Hellwig put it, "set_page_dirty() is only safe if we are > dealing with a file backed page where we have reference on the inode it > hangs off." [1] > > [1] https://lore.kernel.org/r/20190723153640.GB720@lst.de > > Cc: Hans Westgaard Ry > Cc: Santosh Shilimkar > Signed-off-by: Leon Romanovsky > Signed-off-by: John Hubbard Applied, thank you.