All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Francisco Iglesias <frasse.iglesias@gmail.com>
Cc: peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com,
	alistair@alistair23.me, qemu-devel@nongnu.org, edgari@xilinx.com,
	clg@kaod.org, alistair23@gmail.com
Subject: Re: [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd
Date: Sun, 16 Feb 2020 17:04:13 +0100	[thread overview]
Message-ID: <20200216160413.GF22292@toto> (raw)
In-Reply-To: <20200218113350.6090-1-frasse.iglesias@gmail.com>

On Tue, Feb 18, 2020 at 12:33:50PM +0100, Francisco Iglesias wrote:
> From: Francisco Iglesias <francisco.iglesias@xilinx.com>
> 
> Correct the number of dummy cycles required by the FAST_READ_4 command (to
> be eight, one dummy byte).
> 
> Fixes: ef06ca3946 ("xilinx_spips: Add support for RX discard and RX drain")
> Suggested-by: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>



> ---
>  hw/ssi/xilinx_spips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index 6c9ef59779..c57850a505 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -576,11 +576,11 @@ static int xilinx_spips_num_dummies(XilinxQSPIPS *qs, uint8_t command)
>      case FAST_READ:
>      case DOR:
>      case QOR:
> +    case FAST_READ_4:
>      case DOR_4:
>      case QOR_4:
>          return 1;
>      case DIOR:
> -    case FAST_READ_4:
>      case DIOR_4:
>          return 2;
>      case QIOR:
> -- 
> 2.11.0
> 


  reply	other threads:[~2020-02-19  1:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 11:33 [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd Francisco Iglesias
2020-02-16 16:04 ` Edgar E. Iglesias [this message]
2020-02-20 15:02   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200216160413.GF22292@toto \
    --to=edgar.iglesias@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=clg@kaod.org \
    --cc=edgari@xilinx.com \
    --cc=frasse.iglesias@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sai.pavan.boddu@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.