From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F5D2C761A0 for ; Mon, 17 Feb 2020 09:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 371FB2067D for ; Mon, 17 Feb 2020 09:14:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="EAuUGbIu"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lik8Lr7R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728713AbgBQJO3 (ORCPT ); Mon, 17 Feb 2020 04:14:29 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:57169 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728272AbgBQJO2 (ORCPT ); Mon, 17 Feb 2020 04:14:28 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 23E8158D9; Mon, 17 Feb 2020 04:14:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 17 Feb 2020 04:14:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=I14qqSa44pqibysylqjnJvoStph owXN60qAH0HmIOOk=; b=EAuUGbIuhZh0DXzoXVHHztJTrb8eBm2mp9htdM6LVn/ B4yzXZmGWryVzz9Fw8WCCnvJumnVY1EdR78GNUh9O/S4NzDZzeMieTUCK+KTLW95 9SXL7yIrbv0MrpjZzRs29MBVa7AAey6KOVjkCrfMeTlGgOe29OomQ5W/3KhfdHEB 2I5CkHHJpJ+tiQe+1huTRXXvfla2buzQbUWGLEtd0QpruMmX4P4tic+4rr3m9nZR uZ9HhmwQuWxJ/wYeKwtRGMLIMSsceuTg/J4y8PryN/u62SBmoP4ldSsAPytMHtuX aeXiNViClRaOK4gHgmwfPvbuadUde+HnJEY36xUeGRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=I14qqS a44pqibysylqjnJvoStphowXN60qAH0HmIOOk=; b=lik8Lr7RVQqNSV3aPYfoUp H90Xt8Fpw3L2KIrMaoRynRmRd9D9C24cDxR8GAusJRkQEwWT2rHg7d+m4wOdyBcu AXthhxe+m8akQCKbyUJEdzv2aHGTXaQqxDXR77IqiiC4s0fvzgLT/PtwpMKItwYZ h3qtxU10iXxprv/nPOY5AR3ekqWqrWNy86YDf85SGHiO4MK9B+qmW8d3UeSfYPw/ 6xcdTni4SXTveWcYtzegbp3NmNPy5CSl8Q2Vdq+f2x34PWZQ+3IG8eADG9cQU4hs G8+ZgJXCvqIhg/DYfdqlGlgIRzv/Tne7gU2+J3Kdswk7PZcIaeA+2OgCtz4YGSrQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeigddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucfkphepledtrd ekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 83F823280062; Mon, 17 Feb 2020 04:14:25 -0500 (EST) Date: Mon, 17 Feb 2020 10:14:23 +0100 From: Maxime Ripard To: Samuel Holland Cc: Mark Brown , Liam Girdwood , Rob Herring , Mark Rutland , Chen-Yu Tsai , Vasily Khoruzhick , =?utf-8?Q?Myl=C3=A8ne?= Josserand , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 00/34] sun8i-codec fixes and new features Message-ID: <20200217091423.y2muniz3hosquho6@gilmour.lan> References: <20200217064250.15516-1-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217064250.15516-1-samuel@sholland.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Feb 17, 2020 at 12:42:16AM -0600, Samuel Holland wrote: > The sun8i-codec driver, as used in the Allwinner A33 and A64, currently > only exposes a small subset of the available hardware features. In order > to use the A64 in a smartphone (the PinePhone), I've added the necessary > functionality to the driver: > * The full set of supported DAI format options > * Support for AIF2 and AIF3 > * Additional routing knobs > * Additional volume controls > > Unfortunately, due to preexisting issues with the driver, there are some > breaking changes, as explained further in the commit messages: > * The LRCK inversion issue means we need a new compatible for the A64. > * Some controls are named inaccurately, so they are renamed. > * Likewise, the DAPM widgets used in device trees were either named > wrong, or the device trees were using the wrong widgets in the first > place. (Specifically, the links between the analog codec and digital > codec happen at the ADC and DAC, not AIF1.) > > I tended to take the philosophy of "while I'm breaking things, I might > as well do them right", so I've probably made a few more changes than > absolutely necessary. I'm not sure about where all of the policy > boundaries are, about how far I should go to maintain compatibility. For > example, for the DT widget usage, I could: > * Rename everything and update the DTS files (which is what I did) > * Keep the old (misleading/wrong) name for the widgets, but repurpose > them to work correctly > (i.e. "ADC Left" would be named "AIF1 Slot 0 Left ADC", but it > would work just like "ADC Left" does in this patchset) > * Keep the old widgets around as a compatibility layer, but add new > widgets and update the in-tree DTS files to use them > (i.e. "ADC Left" would have a path from "AIF1 Slot 0 Left ADC", > but "AIF1 Slot 0 Left ADC" would be a no-op widget) > * Something else entirely I'm not sure this is really a concern here. We need to maintain the compatibility with old DT's, but those will have an A33 compatible too, and as far as I can see, you're not changing anything for that compatible, so we're in the clear? If not, then the third option would probably be the best, especially since it's only a couple of them. Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71235C7619D for ; Mon, 17 Feb 2020 09:15:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F108C2067D for ; Mon, 17 Feb 2020 09:15:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="e4n+QdOS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="EAuUGbIu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lik8Lr7R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F108C2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 327DF825; Mon, 17 Feb 2020 10:14:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 327DF825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581930925; bh=VNDjlJuK5xVIZ3HqS5Kq7fbgXCVVnzoWriEFtlEsj64=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=e4n+QdOSMkBreJIn+GYuMlope2vQCKhtSFmCmoMoAgKWye02ODZLhHSX0RsWd/9vG LzQHfuaSvtn7KSgIxeqpLsiQ1b28zmoBfIfd871yQCxlKTsI5PFDEwdv3Oo/OQ1PaP /Kp4V02a8nY6b2bWyF3S9762EgqxPwB8D9OxPArY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C95A1F800C4; Mon, 17 Feb 2020 10:14:34 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7DCC3F8015E; Mon, 17 Feb 2020 10:14:33 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7E81FF800B6 for ; Mon, 17 Feb 2020 10:14:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7E81FF800B6 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="EAuUGbIu"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lik8Lr7R" Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 23E8158D9; Mon, 17 Feb 2020 04:14:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 17 Feb 2020 04:14:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=I14qqSa44pqibysylqjnJvoStph owXN60qAH0HmIOOk=; b=EAuUGbIuhZh0DXzoXVHHztJTrb8eBm2mp9htdM6LVn/ B4yzXZmGWryVzz9Fw8WCCnvJumnVY1EdR78GNUh9O/S4NzDZzeMieTUCK+KTLW95 9SXL7yIrbv0MrpjZzRs29MBVa7AAey6KOVjkCrfMeTlGgOe29OomQ5W/3KhfdHEB 2I5CkHHJpJ+tiQe+1huTRXXvfla2buzQbUWGLEtd0QpruMmX4P4tic+4rr3m9nZR uZ9HhmwQuWxJ/wYeKwtRGMLIMSsceuTg/J4y8PryN/u62SBmoP4ldSsAPytMHtuX aeXiNViClRaOK4gHgmwfPvbuadUde+HnJEY36xUeGRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=I14qqS a44pqibysylqjnJvoStphowXN60qAH0HmIOOk=; b=lik8Lr7RVQqNSV3aPYfoUp H90Xt8Fpw3L2KIrMaoRynRmRd9D9C24cDxR8GAusJRkQEwWT2rHg7d+m4wOdyBcu AXthhxe+m8akQCKbyUJEdzv2aHGTXaQqxDXR77IqiiC4s0fvzgLT/PtwpMKItwYZ h3qtxU10iXxprv/nPOY5AR3ekqWqrWNy86YDf85SGHiO4MK9B+qmW8d3UeSfYPw/ 6xcdTni4SXTveWcYtzegbp3NmNPy5CSl8Q2Vdq+f2x34PWZQ+3IG8eADG9cQU4hs G8+ZgJXCvqIhg/DYfdqlGlgIRzv/Tne7gU2+J3Kdswk7PZcIaeA+2OgCtz4YGSrQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeigddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucfkphepledtrd ekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 83F823280062; Mon, 17 Feb 2020 04:14:25 -0500 (EST) Date: Mon, 17 Feb 2020 10:14:23 +0100 From: Maxime Ripard To: Samuel Holland Message-ID: <20200217091423.y2muniz3hosquho6@gilmour.lan> References: <20200217064250.15516-1-samuel@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200217064250.15516-1-samuel@sholland.org> Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Rob Herring , Vasily Khoruzhick , Chen-Yu Tsai , Mark Brown , =?utf-8?Q?Myl=C3=A8ne?= Josserand , linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [RFC PATCH 00/34] sun8i-codec fixes and new features X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On Mon, Feb 17, 2020 at 12:42:16AM -0600, Samuel Holland wrote: > The sun8i-codec driver, as used in the Allwinner A33 and A64, currently > only exposes a small subset of the available hardware features. In order > to use the A64 in a smartphone (the PinePhone), I've added the necessary > functionality to the driver: > * The full set of supported DAI format options > * Support for AIF2 and AIF3 > * Additional routing knobs > * Additional volume controls > > Unfortunately, due to preexisting issues with the driver, there are some > breaking changes, as explained further in the commit messages: > * The LRCK inversion issue means we need a new compatible for the A64. > * Some controls are named inaccurately, so they are renamed. > * Likewise, the DAPM widgets used in device trees were either named > wrong, or the device trees were using the wrong widgets in the first > place. (Specifically, the links between the analog codec and digital > codec happen at the ADC and DAC, not AIF1.) > > I tended to take the philosophy of "while I'm breaking things, I might > as well do them right", so I've probably made a few more changes than > absolutely necessary. I'm not sure about where all of the policy > boundaries are, about how far I should go to maintain compatibility. For > example, for the DT widget usage, I could: > * Rename everything and update the DTS files (which is what I did) > * Keep the old (misleading/wrong) name for the widgets, but repurpose > them to work correctly > (i.e. "ADC Left" would be named "AIF1 Slot 0 Left ADC", but it > would work just like "ADC Left" does in this patchset) > * Keep the old widgets around as a compatibility layer, but add new > widgets and update the in-tree DTS files to use them > (i.e. "ADC Left" would have a path from "AIF1 Slot 0 Left ADC", > but "AIF1 Slot 0 Left ADC" would be a no-op widget) > * Something else entirely I'm not sure this is really a concern here. We need to maintain the compatibility with old DT's, but those will have an A33 compatible too, and as far as I can see, you're not changing anything for that compatible, so we're in the clear? If not, then the third option would probably be the best, especially since it's only a couple of them. Maxime _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221BDC7619F for ; Mon, 17 Feb 2020 09:14:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB5B12067D for ; Mon, 17 Feb 2020 09:14:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YpLnt56U"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="EAuUGbIu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lik8Lr7R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB5B12067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r59r0t7qhnLATad5q1umCmSXzHl/bY7+D10boPL0RFE=; b=YpLnt56UiI5TCy GnK1zIvWZtBrUjF+LrgSRUvo/Ed5Dy54RYA753RARbtOr72eAXkV7u93adiQg844GS8Y1FKhoBCTM ix6vJpcz8wprpPeGUWI7MQNJAr6AL2c2EWoD2SxP9SXSyN/lWIp2/qfV+95CceHEqfJMy+ENuBwr3 5l87TsizORT5TcxOu18gWEQUfdCtmJIaTpE/noh/FShERukeFLtyhi15l0gm6UXwD7j6YhBGVTQEX hsVvUVv3awrt0C5NBmSXQ2A6w6djrln3GNZGHrdZHhsq9nTbkai3OYMs2Bico1tKu+/m0/rxmPFor aFB0Vg00had0V4DDIOEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3cU9-0007wy-W7; Mon, 17 Feb 2020 09:14:37 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3cU7-0007w4-1R for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 09:14:36 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 23E8158D9; Mon, 17 Feb 2020 04:14:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 17 Feb 2020 04:14:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=I14qqSa44pqibysylqjnJvoStph owXN60qAH0HmIOOk=; b=EAuUGbIuhZh0DXzoXVHHztJTrb8eBm2mp9htdM6LVn/ B4yzXZmGWryVzz9Fw8WCCnvJumnVY1EdR78GNUh9O/S4NzDZzeMieTUCK+KTLW95 9SXL7yIrbv0MrpjZzRs29MBVa7AAey6KOVjkCrfMeTlGgOe29OomQ5W/3KhfdHEB 2I5CkHHJpJ+tiQe+1huTRXXvfla2buzQbUWGLEtd0QpruMmX4P4tic+4rr3m9nZR uZ9HhmwQuWxJ/wYeKwtRGMLIMSsceuTg/J4y8PryN/u62SBmoP4ldSsAPytMHtuX aeXiNViClRaOK4gHgmwfPvbuadUde+HnJEY36xUeGRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=I14qqS a44pqibysylqjnJvoStphowXN60qAH0HmIOOk=; b=lik8Lr7RVQqNSV3aPYfoUp H90Xt8Fpw3L2KIrMaoRynRmRd9D9C24cDxR8GAusJRkQEwWT2rHg7d+m4wOdyBcu AXthhxe+m8akQCKbyUJEdzv2aHGTXaQqxDXR77IqiiC4s0fvzgLT/PtwpMKItwYZ h3qtxU10iXxprv/nPOY5AR3ekqWqrWNy86YDf85SGHiO4MK9B+qmW8d3UeSfYPw/ 6xcdTni4SXTveWcYtzegbp3NmNPy5CSl8Q2Vdq+f2x34PWZQ+3IG8eADG9cQU4hs G8+ZgJXCvqIhg/DYfdqlGlgIRzv/Tne7gU2+J3Kdswk7PZcIaeA+2OgCtz4YGSrQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeigddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucfkphepledtrd ekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 83F823280062; Mon, 17 Feb 2020 04:14:25 -0500 (EST) Date: Mon, 17 Feb 2020 10:14:23 +0100 From: Maxime Ripard To: Samuel Holland Subject: Re: [RFC PATCH 00/34] sun8i-codec fixes and new features Message-ID: <20200217091423.y2muniz3hosquho6@gilmour.lan> References: <20200217064250.15516-1-samuel@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200217064250.15516-1-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_011435_227581_65059DCF X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Rob Herring , Jaroslav Kysela , Chen-Yu Tsai , Mark Brown , =?utf-8?Q?Myl=C3=A8ne?= Josserand , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Feb 17, 2020 at 12:42:16AM -0600, Samuel Holland wrote: > The sun8i-codec driver, as used in the Allwinner A33 and A64, currently > only exposes a small subset of the available hardware features. In order > to use the A64 in a smartphone (the PinePhone), I've added the necessary > functionality to the driver: > * The full set of supported DAI format options > * Support for AIF2 and AIF3 > * Additional routing knobs > * Additional volume controls > > Unfortunately, due to preexisting issues with the driver, there are some > breaking changes, as explained further in the commit messages: > * The LRCK inversion issue means we need a new compatible for the A64. > * Some controls are named inaccurately, so they are renamed. > * Likewise, the DAPM widgets used in device trees were either named > wrong, or the device trees were using the wrong widgets in the first > place. (Specifically, the links between the analog codec and digital > codec happen at the ADC and DAC, not AIF1.) > > I tended to take the philosophy of "while I'm breaking things, I might > as well do them right", so I've probably made a few more changes than > absolutely necessary. I'm not sure about where all of the policy > boundaries are, about how far I should go to maintain compatibility. For > example, for the DT widget usage, I could: > * Rename everything and update the DTS files (which is what I did) > * Keep the old (misleading/wrong) name for the widgets, but repurpose > them to work correctly > (i.e. "ADC Left" would be named "AIF1 Slot 0 Left ADC", but it > would work just like "ADC Left" does in this patchset) > * Keep the old widgets around as a compatibility layer, but add new > widgets and update the in-tree DTS files to use them > (i.e. "ADC Left" would have a path from "AIF1 Slot 0 Left ADC", > but "AIF1 Slot 0 Left ADC" would be a no-op widget) > * Something else entirely I'm not sure this is really a concern here. We need to maintain the compatibility with old DT's, but those will have an A33 compatible too, and as far as I can see, you're not changing anything for that compatible, so we're in the clear? If not, then the third option would probably be the best, especially since it's only a couple of them. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel