From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v7 4/4] syscalls/fsmount01: Add test for fsmount series API
Date: Mon, 17 Feb 2020 15:04:52 +0100 [thread overview]
Message-ID: <20200217140452.GA32465@dell5510> (raw)
In-Reply-To: <20200217135205.GA25504@rei>
Hi,
> > + if (ismount(MNTPOINT)) {
> > + tst_res(TPASS, "new mount API works");
> > + SAFE_UMOUNT(MNTPOINT);
> > + is_mounted = 0;
> > + } else
> > + tst_res(TFAIL, "new mount API works");
> ^
> "device not mounted" ?
+1.
> Also LKML coding style prefers curly braces over both branches if they
> are required over one of them.
I'll fix this.
> Other than this the patchset looks fine.
+ I'll add sort as a separate change.
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-17 14:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 8:46 [LTP] [PATCH v7 0/4] Add test for new mount API v5.2 Petr Vorel
2020-02-17 8:46 ` [LTP] [PATCH v7 1/4] tst_umount: Fail immediately when errno != EBUSY Petr Vorel
2020-02-17 8:46 ` [LTP] [PATCH v7 2/4] safe_macros: Use tst_umount() in safe_umount() Petr Vorel
2020-02-17 8:46 ` [LTP] [PATCH v7 3/4] lapi/fsmount: Add definitions for fsmount related syscalls Petr Vorel
2020-02-17 13:49 ` Cyril Hrubis
2020-02-17 8:46 ` [LTP] [PATCH v7 4/4] syscalls/fsmount01: Add test for fsmount series API Petr Vorel
2020-02-17 9:16 ` Li Wang
2020-02-17 9:38 ` Petr Vorel
2020-02-17 13:52 ` Cyril Hrubis
2020-02-17 14:04 ` Petr Vorel [this message]
2020-02-17 14:13 ` Petr Vorel
2020-02-17 15:02 ` Petr Vorel
2020-02-17 9:14 ` [LTP] [PATCH v7 0/4] Add test for new mount API v5.2 Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217140452.GA32465@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.