From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AFFC34022 for ; Mon, 17 Feb 2020 15:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36AF920801 for ; Mon, 17 Feb 2020 15:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581951887; bh=9a7TXwZ2XWmh09Mmv+cWAABgd4vU3rDZVU8uG6XGFa8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qiU81bxeZn8/uQwKB9tmHF4447GqpEQK/OpbdHzmEJfZgPD1VE9TxSdxEpaDsJhEL JxYXfLfwer8rLiRLNshePFpF0ujz6sIbppd8HwX9eAym2CATOUbP7Le8I74quce3ZW Dpe+ufjd9JT+eKMRRSPG0+hUj6jXZ1pAW0TWl054= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729417AbgBQPEq (ORCPT ); Mon, 17 Feb 2020 10:04:46 -0500 Received: from foss.arm.com ([217.140.110.172]:36962 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729319AbgBQPEp (ORCPT ); Mon, 17 Feb 2020 10:04:45 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D586B30E; Mon, 17 Feb 2020 07:04:44 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 599683F703; Mon, 17 Feb 2020 07:04:44 -0800 (PST) Date: Mon, 17 Feb 2020 15:04:42 +0000 From: Mark Brown To: Samuel Holland Cc: Liam Girdwood , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Vasily Khoruzhick , =?iso-8859-1?Q?Myl=E8ne?= Josserand , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 04/34] ASoC: sun8i-codec: Remove unused dev from codec struct Message-ID: <20200217150442.GH9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-5-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zhtSGe8h3+lMyY1M" Content-Disposition: inline In-Reply-To: <20200217064250.15516-5-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zhtSGe8h3+lMyY1M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 12:42:20AM -0600, Samuel Holland wrote: > This field is not used anywhere in the driver, so remove it. > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") This is in no way a bug fix, it's a random cleanup. This means that the Fixes tag isn't really appropriate and it should be done after the subsequent changes in the series that fix real bugs. You should always put bug fixes first so that they don't have any unneeded depenencies on other things and can be merged without them. --zhtSGe8h3+lMyY1M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Kq4oACgkQJNaLcl1U h9A9Vgf9HMozS/Ywu0JGI1L5GM/qN7H8wiz+zVCv1G3I0c+5ZQ+1uicI8yt2ECLS IBLZEnRacg0QqjVmh9Ht3Ar/Z1j8ZWEFHKW/633TvvKsd+sCGUxhdruB9h54TAuP Zp+7hjdRerC9Qwm9mZUohiIL/SYarUiuw7rOuaky+K9uhQTfq9XRtQX7AebIuXNh Zrg/+DrbfQriYkwAvLcS7Adk8LrJ1bDw4WGmBP1zhDFwLCXQ6E2abkf4NltY+TeY 9F481r+90owgmj4x8/yFy+oD0HPgqU3fRXVgXB6H3P4L4HJylgrfjwLXwr3Sg6ln SR4qJz3ixLII+/p8RcAUkach3NRrww== =RpUW -----END PGP SIGNATURE----- --zhtSGe8h3+lMyY1M-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 417FCC34021 for ; Mon, 17 Feb 2020 15:05:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF51B214D8 for ; Mon, 17 Feb 2020 15:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="HM4EYfr+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF51B214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 24BC615E2; Mon, 17 Feb 2020 16:04:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 24BC615E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581951941; bh=9jporvRTxcWTlgMCKcy73orcdMfobfGBESZPiwEwM6Y=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HM4EYfr+cbUcK3IYKQOIFreAn+ald8UIB0Qas1ecvIarBm5W4bSzHGNRMlc9ir8Aj /OrrkTSwmuXw/Ett42xRTxLaaNZWObQrz4NXnCbWBxMK0BD0wQTLaVQKyMrsZAmHxy qCf3GRIVvlgFNmvx55ZVgf7F8M6UwfzFKjPZDfFE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B274EF80096; Mon, 17 Feb 2020 16:04:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3AAFEF80172; Mon, 17 Feb 2020 16:04:49 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id BE23AF80096 for ; Mon, 17 Feb 2020 16:04:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BE23AF80096 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D586B30E; Mon, 17 Feb 2020 07:04:44 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 599683F703; Mon, 17 Feb 2020 07:04:44 -0800 (PST) Date: Mon, 17 Feb 2020 15:04:42 +0000 From: Mark Brown To: Samuel Holland Message-ID: <20200217150442.GH9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-5-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20200217064250.15516-5-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Maxime Ripard , Vasily Khoruzhick , Chen-Yu Tsai , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [RFC PATCH 04/34] ASoC: sun8i-codec: Remove unused dev from codec struct X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3520353786367960913==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============3520353786367960913== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zhtSGe8h3+lMyY1M" Content-Disposition: inline --zhtSGe8h3+lMyY1M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 12:42:20AM -0600, Samuel Holland wrote: > This field is not used anywhere in the driver, so remove it. > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") This is in no way a bug fix, it's a random cleanup. This means that the Fixes tag isn't really appropriate and it should be done after the subsequent changes in the series that fix real bugs. You should always put bug fixes first so that they don't have any unneeded depenencies on other things and can be merged without them. --zhtSGe8h3+lMyY1M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Kq4oACgkQJNaLcl1U h9A9Vgf9HMozS/Ywu0JGI1L5GM/qN7H8wiz+zVCv1G3I0c+5ZQ+1uicI8yt2ECLS IBLZEnRacg0QqjVmh9Ht3Ar/Z1j8ZWEFHKW/633TvvKsd+sCGUxhdruB9h54TAuP Zp+7hjdRerC9Qwm9mZUohiIL/SYarUiuw7rOuaky+K9uhQTfq9XRtQX7AebIuXNh Zrg/+DrbfQriYkwAvLcS7Adk8LrJ1bDw4WGmBP1zhDFwLCXQ6E2abkf4NltY+TeY 9F481r+90owgmj4x8/yFy+oD0HPgqU3fRXVgXB6H3P4L4HJylgrfjwLXwr3Sg6ln SR4qJz3ixLII+/p8RcAUkach3NRrww== =RpUW -----END PGP SIGNATURE----- --zhtSGe8h3+lMyY1M-- --===============3520353786367960913== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============3520353786367960913==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EADADC34022 for ; Mon, 17 Feb 2020 15:05:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE00420801 for ; Mon, 17 Feb 2020 15:05:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UEr8uI02" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE00420801 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dG+JyeUdgOx5zdeAdNUWwh1XGEWc6etn6F9iD+HJDUE=; b=UEr8uI02gijyrSSmvqnRB0QPo 6CI0vf6Iy35VYK2mFRt1QbwEaXJFjRK01CFHjOniozDeUwtD8tXrg74gA2TQBAP8vYMAjyvv3yKvW YAvn5TihZM1tqwAp6qZExACaBnzi5v17qpAXgcCJX/s0pwgwdR7yiTD6UMM5jFbqlz04VZUnQksNf HePCMs8yF6WU2liJFMsyC8N0gi69HC9WDuZzWjOF/4p5zPreeSG6uMF6pi9Nqs4KjsNLPhGrxEONM BRmJ6eOWjP8bQjQzThmFaewJLDX9yNtrjqZ+OFjZSx6LjtzyU04B55P4mGDogqr8CcUZUuyQ7VXPG TG/CP/XuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3hx6-0000Ps-Ps; Mon, 17 Feb 2020 15:04:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3hwz-0000K9-Bh for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 15:04:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D586B30E; Mon, 17 Feb 2020 07:04:44 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 599683F703; Mon, 17 Feb 2020 07:04:44 -0800 (PST) Date: Mon, 17 Feb 2020 15:04:42 +0000 From: Mark Brown To: Samuel Holland Subject: Re: [RFC PATCH 04/34] ASoC: sun8i-codec: Remove unused dev from codec struct Message-ID: <20200217150442.GH9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-5-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20200217064250.15516-5-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_070445_462089_520F78E1 X-CRM114-Status: GOOD ( 10.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Maxime Ripard , Jaroslav Kysela , Chen-Yu Tsai , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7798333356828342830==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7798333356828342830== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zhtSGe8h3+lMyY1M" Content-Disposition: inline --zhtSGe8h3+lMyY1M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 12:42:20AM -0600, Samuel Holland wrote: > This field is not used anywhere in the driver, so remove it. > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") This is in no way a bug fix, it's a random cleanup. This means that the Fixes tag isn't really appropriate and it should be done after the subsequent changes in the series that fix real bugs. You should always put bug fixes first so that they don't have any unneeded depenencies on other things and can be merged without them. --zhtSGe8h3+lMyY1M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Kq4oACgkQJNaLcl1U h9A9Vgf9HMozS/Ywu0JGI1L5GM/qN7H8wiz+zVCv1G3I0c+5ZQ+1uicI8yt2ECLS IBLZEnRacg0QqjVmh9Ht3Ar/Z1j8ZWEFHKW/633TvvKsd+sCGUxhdruB9h54TAuP Zp+7hjdRerC9Qwm9mZUohiIL/SYarUiuw7rOuaky+K9uhQTfq9XRtQX7AebIuXNh Zrg/+DrbfQriYkwAvLcS7Adk8LrJ1bDw4WGmBP1zhDFwLCXQ6E2abkf4NltY+TeY 9F481r+90owgmj4x8/yFy+oD0HPgqU3fRXVgXB6H3P4L4HJylgrfjwLXwr3Sg6ln SR4qJz3ixLII+/p8RcAUkach3NRrww== =RpUW -----END PGP SIGNATURE----- --zhtSGe8h3+lMyY1M-- --===============7798333356828342830== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7798333356828342830==--