From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F6DBC34022 for ; Mon, 17 Feb 2020 15:24:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E184720801 for ; Mon, 17 Feb 2020 15:24:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581953065; bh=2zACJdzJWOimtEDKdqtbvKk8L5olDddcqqV+IDbusDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uiGduDM+iQ2vvK6cquByDEeb1jA2SvmIoOdDNWfL2mwEPmp4+iL5TSowumGO7oU0w sDVeW5SBAH+5p7qcEpQw+3dm4fKxrg+wFXfiSFaapO4C6nzZBS5QpOry63ZlrCBRXG CN+vRcdljLaUIMdkjVrjWCAHTN1sIGGXmkXXyXAk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728774AbgBQPYX (ORCPT ); Mon, 17 Feb 2020 10:24:23 -0500 Received: from foss.arm.com ([217.140.110.172]:37270 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727428AbgBQPYX (ORCPT ); Mon, 17 Feb 2020 10:24:23 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F112530E; Mon, 17 Feb 2020 07:24:22 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74CEB3F703; Mon, 17 Feb 2020 07:24:22 -0800 (PST) Date: Mon, 17 Feb 2020 15:24:20 +0000 From: Mark Brown To: Samuel Holland Cc: Liam Girdwood , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Vasily Khoruzhick , =?iso-8859-1?Q?Myl=E8ne?= Josserand , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@kernel.org Subject: Re: [RFC PATCH 09/34] ASoC: sun8i-codec: Fix broken DAPM routing Message-ID: <20200217152420.GK9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-10-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="opg8F0UgoHELSI+9" Content-Disposition: inline In-Reply-To: <20200217064250.15516-10-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --opg8F0UgoHELSI+9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 12:42:25AM -0600, Samuel Holland wrote: > This commit provides the minimal necessary changes to the driver's > device tree ABI, so that the driver can begin to describe the full > hardware topology. > Cc: stable@kernel.org You're changing the ABI and trying to CC this to stable. This is obviously not at all OK, this would mean that if someone got a stable update with this change the ABI break would mean that their existing device tree would not work. The code should be making every effort to provide a stable ABI over new kernel releases, never mind within a stable point release. --opg8F0UgoHELSI+9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KsCQACgkQJNaLcl1U h9DlOQf/fnliV8i6hOsjjmuPNKhYpYFB0CpQahOVaYcseah4KRMxgLYafPDPCBFi YOG1uPOnbNmX7j2Vk4tA4fobq2c9iAJjVUafUWsNm6qiftRtSKHw8NgpDcH/i5+A hQpjcJoW+zdzoV3a/l0/lA0Ntot3eligdLNJZEukfJTWU5KndAo0k6jJH0WNj3zw xjiw6WNJee1j6xkOZEWzHoIZNZ+eXQjebMa5KbArSwzBXVS3SeaYZ9eMCzph7OpI CXcIBWJssHvQlSxZeCjB64bwsBCbzUuRW6doz1Ikjn/IdAfjudwjwODeRENTKykJ JCEiaoF87UkEhPoF68ycyKTgcgrxRA== =pmEj -----END PGP SIGNATURE----- --opg8F0UgoHELSI+9-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7149DC34024 for ; Mon, 17 Feb 2020 15:25:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED5E8215A4 for ; Mon, 17 Feb 2020 15:25:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="sRJH2IDy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED5E8215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 569C015E5; Mon, 17 Feb 2020 16:24:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 569C015E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581953120; bh=rE/hG0cfjxvN8w3fIGZZT2pTC0Z07YtHBGOI4Qh4SBc=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sRJH2IDyw10Lh28IqZQljIU0S1ww1juBDy29bhgAoOZgfbkM4uHy88G5sG0anH8PT gNjZCxsqW36Jv6D9DI+H8ZkIizBmkn1F0kMXqriEewOdNXzQt9Rpf9qUWP45N1WRze OyokTtUwoqFboc4UG4FlVvCju2Gk/3D7Pp5L28Zw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D2836F8015E; Mon, 17 Feb 2020 16:24:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C46F7F80172; Mon, 17 Feb 2020 16:24:27 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 07D03F800C4 for ; Mon, 17 Feb 2020 16:24:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07D03F800C4 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F112530E; Mon, 17 Feb 2020 07:24:22 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74CEB3F703; Mon, 17 Feb 2020 07:24:22 -0800 (PST) Date: Mon, 17 Feb 2020 15:24:20 +0000 From: Mark Brown To: Samuel Holland Message-ID: <20200217152420.GK9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-10-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20200217064250.15516-10-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Maxime Ripard , Vasily Khoruzhick , Chen-Yu Tsai , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , stable@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [RFC PATCH 09/34] ASoC: sun8i-codec: Fix broken DAPM routing X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5296854945196220754==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============5296854945196220754== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="opg8F0UgoHELSI+9" Content-Disposition: inline --opg8F0UgoHELSI+9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 12:42:25AM -0600, Samuel Holland wrote: > This commit provides the minimal necessary changes to the driver's > device tree ABI, so that the driver can begin to describe the full > hardware topology. > Cc: stable@kernel.org You're changing the ABI and trying to CC this to stable. This is obviously not at all OK, this would mean that if someone got a stable update with this change the ABI break would mean that their existing device tree would not work. The code should be making every effort to provide a stable ABI over new kernel releases, never mind within a stable point release. --opg8F0UgoHELSI+9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KsCQACgkQJNaLcl1U h9DlOQf/fnliV8i6hOsjjmuPNKhYpYFB0CpQahOVaYcseah4KRMxgLYafPDPCBFi YOG1uPOnbNmX7j2Vk4tA4fobq2c9iAJjVUafUWsNm6qiftRtSKHw8NgpDcH/i5+A hQpjcJoW+zdzoV3a/l0/lA0Ntot3eligdLNJZEukfJTWU5KndAo0k6jJH0WNj3zw xjiw6WNJee1j6xkOZEWzHoIZNZ+eXQjebMa5KbArSwzBXVS3SeaYZ9eMCzph7OpI CXcIBWJssHvQlSxZeCjB64bwsBCbzUuRW6doz1Ikjn/IdAfjudwjwODeRENTKykJ JCEiaoF87UkEhPoF68ycyKTgcgrxRA== =pmEj -----END PGP SIGNATURE----- --opg8F0UgoHELSI+9-- --===============5296854945196220754== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============5296854945196220754==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC05C34022 for ; Mon, 17 Feb 2020 15:24:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD9A4215A4 for ; Mon, 17 Feb 2020 15:24:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PhVa0Z5r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD9A4215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uxDZdjE6Bu44L8bQHTiOCIOh+UuHF4OIhAGml52siyM=; b=PhVa0Z5rZ8lBtqbKeq7wDc0gl CUV/YEBHdd/3j7IBTUl4zxEoD7e0rZQZBK/2X8wps6Gc9Ke2wm33g1WhZO/CGIHDsWDwTvaBT/vah s/nsTT8IHCp5s5ZDL7t2k3xk+DzF4psBxdrAtF/RDWUxDltMqp3JX7yMEho3WzTMg/W5V13ktaSmr 37XpmBHRPRTo0HTOvyG0XzaewcSTVyAtpOEARPg2fz2CZ8Ksh3BcZ/EO5/RoUji+jxSo2WQmkn3ZQ 0T22aRjCt0UyD9NzW1MmfwGHlUvnrcy4G/UW/DcqazmaAaTjpXyzGcsSUzF7UCyWIf9Gb+hsruXgj JYZWUPrUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3iG2-0001QD-4I; Mon, 17 Feb 2020 15:24:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3iFz-0001Pm-S2 for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 15:24:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F112530E; Mon, 17 Feb 2020 07:24:22 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74CEB3F703; Mon, 17 Feb 2020 07:24:22 -0800 (PST) Date: Mon, 17 Feb 2020 15:24:20 +0000 From: Mark Brown To: Samuel Holland Subject: Re: [RFC PATCH 09/34] ASoC: sun8i-codec: Fix broken DAPM routing Message-ID: <20200217152420.GK9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-10-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20200217064250.15516-10-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_072423_950253_71EF01BD X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Maxime Ripard , Jaroslav Kysela , Chen-Yu Tsai , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , stable@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5323430374491070888==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5323430374491070888== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="opg8F0UgoHELSI+9" Content-Disposition: inline --opg8F0UgoHELSI+9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 12:42:25AM -0600, Samuel Holland wrote: > This commit provides the minimal necessary changes to the driver's > device tree ABI, so that the driver can begin to describe the full > hardware topology. > Cc: stable@kernel.org You're changing the ABI and trying to CC this to stable. This is obviously not at all OK, this would mean that if someone got a stable update with this change the ABI break would mean that their existing device tree would not work. The code should be making every effort to provide a stable ABI over new kernel releases, never mind within a stable point release. --opg8F0UgoHELSI+9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KsCQACgkQJNaLcl1U h9DlOQf/fnliV8i6hOsjjmuPNKhYpYFB0CpQahOVaYcseah4KRMxgLYafPDPCBFi YOG1uPOnbNmX7j2Vk4tA4fobq2c9iAJjVUafUWsNm6qiftRtSKHw8NgpDcH/i5+A hQpjcJoW+zdzoV3a/l0/lA0Ntot3eligdLNJZEukfJTWU5KndAo0k6jJH0WNj3zw xjiw6WNJee1j6xkOZEWzHoIZNZ+eXQjebMa5KbArSwzBXVS3SeaYZ9eMCzph7OpI CXcIBWJssHvQlSxZeCjB64bwsBCbzUuRW6doz1Ikjn/IdAfjudwjwODeRENTKykJ JCEiaoF87UkEhPoF68ycyKTgcgrxRA== =pmEj -----END PGP SIGNATURE----- --opg8F0UgoHELSI+9-- --===============5323430374491070888== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5323430374491070888==--