From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF07C34021 for ; Mon, 17 Feb 2020 15:30:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD88F20801 for ; Mon, 17 Feb 2020 15:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581953427; bh=sWp7aeUVD81rQW+jXkgInh487wAxjgtJfV+WNx4x9gE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vngPL/vRFeDKXaQyvKlqePNuB19T+1n/e2KI86b9WUqLxLhLl6ypn+5hV3hYrMTRn iLskX8aEK9vTRKJMW7t97e1Red4ovMpZF0acskzDnIc4OjMIAlTqJQ4aPWSY/VyeUD VmJR+jRgMIZJ3V04EZfRn6g+33DYmeUcagco7/Ow= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728424AbgBQPa0 (ORCPT ); Mon, 17 Feb 2020 10:30:26 -0500 Received: from foss.arm.com ([217.140.110.172]:37370 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbgBQPa0 (ORCPT ); Mon, 17 Feb 2020 10:30:26 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCCDE30E; Mon, 17 Feb 2020 07:30:25 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E50E3F703; Mon, 17 Feb 2020 07:30:25 -0800 (PST) Date: Mon, 17 Feb 2020 15:30:23 +0000 From: Mark Brown To: Samuel Holland Cc: Liam Girdwood , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Vasily Khoruzhick , =?iso-8859-1?Q?Myl=E8ne?= Josserand , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@kernel.org Subject: Re: [RFC PATCH 10/34] ASoC: sun8i-codec: Advertise only hardware-supported rates Message-ID: <20200217153023.GL9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-11-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0qVF/w3MHQqLSynd" Content-Disposition: inline In-Reply-To: <20200217064250.15516-11-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0qVF/w3MHQqLSynd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 17, 2020 at 12:42:26AM -0600, Samuel Holland wrote: > The hardware does not support 64kHz, 88.2kHz, or 176.4kHz sample rates, > so the driver should not advertise them. The hardware can handle two > additional non-standard sample rates: 12kHz and 24kHz, so declare > support for them via SNDRV_PCM_RATE_KNOT. >=20 > Cc: stable@kernel.org > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") > Fixes: eda85d1fee05 ("ASoC: sun8i-codec: Add ADC support for a33") > Signed-off-by: Samuel Holland The new sample rates are new functionality, they are definitely not stable material. For the sample rates you are removing do we understand why they were added - do they work for people, are they perhaps supported for some users and not others for example? --0qVF/w3MHQqLSynd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KsY8ACgkQJNaLcl1U h9DgKwf/RkeIHeM2sJ2RgbLTXWX8YZmWkvlMjMbuWBeFxHTz/Hdo+gM34z7glK5D vTsYnMg6wYSVtkRJzw6JOjJE/YqT+KFTmpqMHlhJkHhh+0Ce33hnN5vhPWAOyDLX ajN4NNYMR/RvlHVhAD8YVCjWKy65hpslCTajh+74Pn5GNtXao1z2mH6vDaVOntZj KsuP3g6wxqKicdi4lrAYDS80cpUVlOD4OkMk49MT5h1U78w3hblZkKULqFjOt3BL jgdv2os2/zg+/7OxQCcAlJfrfd4m4kBHbI9HF+0IMV9CIt+pR7Kmy7H+zcliwi9L 1zUYINK1EWJvcb+4lIeZcMRp0sH7aQ== =ZBtq -----END PGP SIGNATURE----- --0qVF/w3MHQqLSynd-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 636CBC34022 for ; Mon, 17 Feb 2020 15:31:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E34A02070B for ; Mon, 17 Feb 2020 15:31:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vM1zOlCO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E34A02070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 295303E; Mon, 17 Feb 2020 16:30:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 295303E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581953483; bh=BAJtar/5sRR5rj/UpDdz+BoQbze/LWEs2wS7Ij55BUs=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vM1zOlCOg8yRm8KQ15NtiGh1jlOK71LRkjFB9gVMC12jQvJkPSML35hS4gPpaIv00 FfOqpiL6KXhRSAnyrsiYuuOTGD93aOD8lHtB1/ObNCxSK2Wsp49b+UG7mht4uXMAU9 wqUGggbbsaN3xD+AzJz12wTFEU5x4JAeL8t9svYQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A9A06F8015E; Mon, 17 Feb 2020 16:30:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9968CF80172; Mon, 17 Feb 2020 16:30:30 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 94B73F80096 for ; Mon, 17 Feb 2020 16:30:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 94B73F80096 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCCDE30E; Mon, 17 Feb 2020 07:30:25 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E50E3F703; Mon, 17 Feb 2020 07:30:25 -0800 (PST) Date: Mon, 17 Feb 2020 15:30:23 +0000 From: Mark Brown To: Samuel Holland Message-ID: <20200217153023.GL9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-11-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20200217064250.15516-11-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Maxime Ripard , Vasily Khoruzhick , Chen-Yu Tsai , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , stable@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [RFC PATCH 10/34] ASoC: sun8i-codec: Advertise only hardware-supported rates X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6067526400003327137==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============6067526400003327137== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0qVF/w3MHQqLSynd" Content-Disposition: inline --0qVF/w3MHQqLSynd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 17, 2020 at 12:42:26AM -0600, Samuel Holland wrote: > The hardware does not support 64kHz, 88.2kHz, or 176.4kHz sample rates, > so the driver should not advertise them. The hardware can handle two > additional non-standard sample rates: 12kHz and 24kHz, so declare > support for them via SNDRV_PCM_RATE_KNOT. >=20 > Cc: stable@kernel.org > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") > Fixes: eda85d1fee05 ("ASoC: sun8i-codec: Add ADC support for a33") > Signed-off-by: Samuel Holland The new sample rates are new functionality, they are definitely not stable material. For the sample rates you are removing do we understand why they were added - do they work for people, are they perhaps supported for some users and not others for example? --0qVF/w3MHQqLSynd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KsY8ACgkQJNaLcl1U h9DgKwf/RkeIHeM2sJ2RgbLTXWX8YZmWkvlMjMbuWBeFxHTz/Hdo+gM34z7glK5D vTsYnMg6wYSVtkRJzw6JOjJE/YqT+KFTmpqMHlhJkHhh+0Ce33hnN5vhPWAOyDLX ajN4NNYMR/RvlHVhAD8YVCjWKy65hpslCTajh+74Pn5GNtXao1z2mH6vDaVOntZj KsuP3g6wxqKicdi4lrAYDS80cpUVlOD4OkMk49MT5h1U78w3hblZkKULqFjOt3BL jgdv2os2/zg+/7OxQCcAlJfrfd4m4kBHbI9HF+0IMV9CIt+pR7Kmy7H+zcliwi9L 1zUYINK1EWJvcb+4lIeZcMRp0sH7aQ== =ZBtq -----END PGP SIGNATURE----- --0qVF/w3MHQqLSynd-- --===============6067526400003327137== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============6067526400003327137==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC4DCC34021 for ; Mon, 17 Feb 2020 15:30:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A031D20801 for ; Mon, 17 Feb 2020 15:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G2m0RYTo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A031D20801 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O8oIPRT3NKHz24KgxD7T6yoXneIWRjwL1x8lx80zZ2o=; b=G2m0RYTomcjs+qPpkC8e/78KT enbWV5TIdro0UheGDEuj7jxiM+aJVwy5PtERQDacrXaj+9xj5N5WOwefAYS1wGVk06os6cPQCzuGu HJ+r6MUkDFGYeV28idw3Nug5QNqlC/KxbFVZrK3GtghtIrvVwH1aM/SbX1p6O06BuPWRaMr8Mum1t i8to1phVi5eyrr8TnR/o9q5RaaC6MJQz1oHCvFdVoDo6QXXEDrxTGEkt/5Eba0tF6wyfXp4g4y3Pb GeYu7Nc9qkcX66H3CGtwlYjqzNkUSyFnc+anOgHAE64VLJn3KDAmShx15A4IWzeSbyUiSMNCcsXl4 XZKnpfjSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3iLu-0004fQ-Hh; Mon, 17 Feb 2020 15:30:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3iLr-0004en-2v for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2020 15:30:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCCDE30E; Mon, 17 Feb 2020 07:30:25 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E50E3F703; Mon, 17 Feb 2020 07:30:25 -0800 (PST) Date: Mon, 17 Feb 2020 15:30:23 +0000 From: Mark Brown To: Samuel Holland Subject: Re: [RFC PATCH 10/34] ASoC: sun8i-codec: Advertise only hardware-supported rates Message-ID: <20200217153023.GL9304@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-11-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20200217064250.15516-11-samuel@sholland.org> X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_073027_176399_95ECC070 X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Maxime Ripard , Jaroslav Kysela , Chen-Yu Tsai , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , stable@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3166822561063455299==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3166822561063455299== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0qVF/w3MHQqLSynd" Content-Disposition: inline --0qVF/w3MHQqLSynd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 17, 2020 at 12:42:26AM -0600, Samuel Holland wrote: > The hardware does not support 64kHz, 88.2kHz, or 176.4kHz sample rates, > so the driver should not advertise them. The hardware can handle two > additional non-standard sample rates: 12kHz and 24kHz, so declare > support for them via SNDRV_PCM_RATE_KNOT. >=20 > Cc: stable@kernel.org > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") > Fixes: eda85d1fee05 ("ASoC: sun8i-codec: Add ADC support for a33") > Signed-off-by: Samuel Holland The new sample rates are new functionality, they are definitely not stable material. For the sample rates you are removing do we understand why they were added - do they work for people, are they perhaps supported for some users and not others for example? --0qVF/w3MHQqLSynd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5KsY8ACgkQJNaLcl1U h9DgKwf/RkeIHeM2sJ2RgbLTXWX8YZmWkvlMjMbuWBeFxHTz/Hdo+gM34z7glK5D vTsYnMg6wYSVtkRJzw6JOjJE/YqT+KFTmpqMHlhJkHhh+0Ce33hnN5vhPWAOyDLX ajN4NNYMR/RvlHVhAD8YVCjWKy65hpslCTajh+74Pn5GNtXao1z2mH6vDaVOntZj KsuP3g6wxqKicdi4lrAYDS80cpUVlOD4OkMk49MT5h1U78w3hblZkKULqFjOt3BL jgdv2os2/zg+/7OxQCcAlJfrfd4m4kBHbI9HF+0IMV9CIt+pR7Kmy7H+zcliwi9L 1zUYINK1EWJvcb+4lIeZcMRp0sH7aQ== =ZBtq -----END PGP SIGNATURE----- --0qVF/w3MHQqLSynd-- --===============3166822561063455299== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3166822561063455299==--