From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52297C34037 for ; Tue, 18 Feb 2020 11:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FA9021D56 for ; Tue, 18 Feb 2020 11:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582025563; bh=2b1XwxH8MZNa/x4vH9fIYj1CqGENzpjeWAElEh1a/xI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SX7uDa4v+2KYvxLpG18GEGzHhlUkvQT00nx+sIDzoTbxCFxhUerxa8/25dpWbluAU tslG6jjz0y3VX7GIocdYH4ePQf1tFr2DicGoY0xzJxhTvPgyQQWwGwfV2+FWXPOs8c F7793ZDgLCe0/bbUE5eMlLbSdQ/XPWE67ZX1DG1Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbgBRLcm (ORCPT ); Tue, 18 Feb 2020 06:32:42 -0500 Received: from foss.arm.com ([217.140.110.172]:50372 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbgBRLcl (ORCPT ); Tue, 18 Feb 2020 06:32:41 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 705721FB; Tue, 18 Feb 2020 03:32:41 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E92BA3F703; Tue, 18 Feb 2020 03:32:40 -0800 (PST) Date: Tue, 18 Feb 2020 11:32:39 +0000 From: Mark Brown To: Samuel Holland Cc: Liam Girdwood , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Vasily Khoruzhick , =?iso-8859-1?Q?Myl=E8ne?= Josserand , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@kernel.org Subject: Re: [RFC PATCH 05/34] ASoC: sun8i-codec: Remove incorrect SND_SOC_DAIFMT_DSP_B Message-ID: <20200218113239.GB4232@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-6-samuel@sholland.org> <20200217150208.GG9304@sirena.org.uk> <1cdcbc0d-39c7-25f2-68eb-a44e815fb9b8@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nVMJ2NtxeReIH9PS" Content-Disposition: inline In-Reply-To: <1cdcbc0d-39c7-25f2-68eb-a44e815fb9b8@sholland.org> X-Cookie: No alcohol, dogs or horses. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nVMJ2NtxeReIH9PS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 07:35:08PM -0600, Samuel Holland wrote: > On 2/17/20 9:02 AM, Mark Brown wrote: > > On Mon, Feb 17, 2020 at 12:42:21AM -0600, Samuel Holland wrote: > >> DSP_A and DSP_B are not interchangeable. The timing used by the codec in > >> DSP mode is consistent with DSP_A. This is verified with an EG25-G modem > >> connected to AIF2, as well as by comparing with the BSP driver. > > This can only break things for existing systems using stable, if they > > haven't noticed a problem with DSP B they'll certainly notice failing to > > set up the DAI at all without it. > Are you suggesting that I drop this patch entirely, or only that I remove the CC > to stable (and/or Fixes: tag)? Is this something that can't be removed once it's > there, or is the concern about making user-visible changes on stable? Remove the stable tag, if someone is relying on the DSP B support in stable this will break it. --nVMJ2NtxeReIH9PS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Ly1YACgkQJNaLcl1U h9CFEQf8D9YL5SadnjL9dOFFrzy8yoRe7dCBkHfRxS2YavdoyZPsbCrDOcY93rEL /VkLJwslj6K1LCmAYYJ4/Qo+q+hPV2bnnzcslJD4Mk19RhLuBbLR8/kfP0mgnlb4 igA2RgQJlN1GubExF4orNfkGrQxaTORV9EmceHayvRL232NkBdwGqu6wcG4Gk3YR dA0GaD0uBoCMBucCRvveNRdwJAD9aStpZZwC2Qb4Iv3lMAD6do8XCz99kT+ptlFs 8N/oDBbmQpwJTkXmTphUhhkCkxA/bMZMw8QxPHZnG5SuemVyfYJ/WYevARSnpaTp zPxaVojES71xzKzOJUh3NURlUBhKcg== =Hx/L -----END PGP SIGNATURE----- --nVMJ2NtxeReIH9PS-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503BEC34026 for ; Tue, 18 Feb 2020 11:33:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D188624125 for ; Tue, 18 Feb 2020 11:33:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="CBjUC/XW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D188624125 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3BB401678; Tue, 18 Feb 2020 12:32:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3BB401678 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582025617; bh=2b1XwxH8MZNa/x4vH9fIYj1CqGENzpjeWAElEh1a/xI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CBjUC/XWUgjX2ofhDrHxT/TOTXiKUbd/vf2niK4RwHCPx7ZodBMzKihfa2mL7AL+s EdGk9ulujC/GADpE62aFnsnHqk+Erj4+KUNnFTuw48/q6a1izRz5mCNPMO9oPaEUer 00bign2gdU5FZSCT91Xi1IHQO+N2d4VaBOxBKmlE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CB452F8014A; Tue, 18 Feb 2020 12:32:46 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1366DF8014C; Tue, 18 Feb 2020 12:32:45 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 9740BF80135 for ; Tue, 18 Feb 2020 12:32:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9740BF80135 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 705721FB; Tue, 18 Feb 2020 03:32:41 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E92BA3F703; Tue, 18 Feb 2020 03:32:40 -0800 (PST) Date: Tue, 18 Feb 2020 11:32:39 +0000 From: Mark Brown To: Samuel Holland Subject: Re: [RFC PATCH 05/34] ASoC: sun8i-codec: Remove incorrect SND_SOC_DAIFMT_DSP_B Message-ID: <20200218113239.GB4232@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-6-samuel@sholland.org> <20200217150208.GG9304@sirena.org.uk> <1cdcbc0d-39c7-25f2-68eb-a44e815fb9b8@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nVMJ2NtxeReIH9PS" Content-Disposition: inline In-Reply-To: <1cdcbc0d-39c7-25f2-68eb-a44e815fb9b8@sholland.org> X-Cookie: No alcohol, dogs or horses. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Maxime Ripard , Vasily Khoruzhick , Chen-Yu Tsai , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , stable@kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --nVMJ2NtxeReIH9PS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 07:35:08PM -0600, Samuel Holland wrote: > On 2/17/20 9:02 AM, Mark Brown wrote: > > On Mon, Feb 17, 2020 at 12:42:21AM -0600, Samuel Holland wrote: > >> DSP_A and DSP_B are not interchangeable. The timing used by the codec in > >> DSP mode is consistent with DSP_A. This is verified with an EG25-G modem > >> connected to AIF2, as well as by comparing with the BSP driver. > > This can only break things for existing systems using stable, if they > > haven't noticed a problem with DSP B they'll certainly notice failing to > > set up the DAI at all without it. > Are you suggesting that I drop this patch entirely, or only that I remove the CC > to stable (and/or Fixes: tag)? Is this something that can't be removed once it's > there, or is the concern about making user-visible changes on stable? Remove the stable tag, if someone is relying on the DSP B support in stable this will break it. --nVMJ2NtxeReIH9PS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Ly1YACgkQJNaLcl1U h9CFEQf8D9YL5SadnjL9dOFFrzy8yoRe7dCBkHfRxS2YavdoyZPsbCrDOcY93rEL /VkLJwslj6K1LCmAYYJ4/Qo+q+hPV2bnnzcslJD4Mk19RhLuBbLR8/kfP0mgnlb4 igA2RgQJlN1GubExF4orNfkGrQxaTORV9EmceHayvRL232NkBdwGqu6wcG4Gk3YR dA0GaD0uBoCMBucCRvveNRdwJAD9aStpZZwC2Qb4Iv3lMAD6do8XCz99kT+ptlFs 8N/oDBbmQpwJTkXmTphUhhkCkxA/bMZMw8QxPHZnG5SuemVyfYJ/WYevARSnpaTp zPxaVojES71xzKzOJUh3NURlUBhKcg== =Hx/L -----END PGP SIGNATURE----- --nVMJ2NtxeReIH9PS-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6681EC34026 for ; Tue, 18 Feb 2020 11:32:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B73521D56 for ; Tue, 18 Feb 2020 11:32:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eVQU/yKL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B73521D56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I0yNQ8iVMmbjskn+lXllk8oVnMnj6bWkTrL1/DZUpNU=; b=eVQU/yKLZ/xs5H75/z2YRDKjr hYdjsuy3ATu1gtN4kYOP1M+DvnouQ5rbB4ySyG882DazaCVKwanIni8wxLznsq6p/1vD1PAlCK8ya p+h3j5eW9XZSGsaChSmQkmvHG0dxQyAxjHoZqWu1GJXNhpAQ7FvbP1gFjsLgYUFw/jD8Okcynkb5m d/5I/fyU1FxbXN1+J898T+W0Xuy8izedXSWDI0HbFQR0twnnFMQPW1GeEeP6ldzmKoeUuGJA/tdZS TQjyK5p3mQokRaVQrcG5Rb2qG/Ps5rQk7hDXQGpaOuvM3lQtbQcCSoxBc1Kiip5ayTWQ9hpCwj7ir dp4WfT/Ag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j417O-0006UE-7B; Tue, 18 Feb 2020 11:32:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j417L-0006TY-Hj for linux-arm-kernel@lists.infradead.org; Tue, 18 Feb 2020 11:32:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 705721FB; Tue, 18 Feb 2020 03:32:41 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E92BA3F703; Tue, 18 Feb 2020 03:32:40 -0800 (PST) Date: Tue, 18 Feb 2020 11:32:39 +0000 From: Mark Brown To: Samuel Holland Subject: Re: [RFC PATCH 05/34] ASoC: sun8i-codec: Remove incorrect SND_SOC_DAIFMT_DSP_B Message-ID: <20200218113239.GB4232@sirena.org.uk> References: <20200217064250.15516-1-samuel@sholland.org> <20200217064250.15516-6-samuel@sholland.org> <20200217150208.GG9304@sirena.org.uk> <1cdcbc0d-39c7-25f2-68eb-a44e815fb9b8@sholland.org> MIME-Version: 1.0 In-Reply-To: <1cdcbc0d-39c7-25f2-68eb-a44e815fb9b8@sholland.org> X-Cookie: No alcohol, dogs or horses. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_033243_632907_B7E58179 X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Maxime Ripard , Jaroslav Kysela , Chen-Yu Tsai , Rob Herring , =?iso-8859-1?Q?Myl=E8ne?= Josserand , stable@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7868770511427576495==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7868770511427576495== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nVMJ2NtxeReIH9PS" Content-Disposition: inline --nVMJ2NtxeReIH9PS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 17, 2020 at 07:35:08PM -0600, Samuel Holland wrote: > On 2/17/20 9:02 AM, Mark Brown wrote: > > On Mon, Feb 17, 2020 at 12:42:21AM -0600, Samuel Holland wrote: > >> DSP_A and DSP_B are not interchangeable. The timing used by the codec in > >> DSP mode is consistent with DSP_A. This is verified with an EG25-G modem > >> connected to AIF2, as well as by comparing with the BSP driver. > > This can only break things for existing systems using stable, if they > > haven't noticed a problem with DSP B they'll certainly notice failing to > > set up the DAI at all without it. > Are you suggesting that I drop this patch entirely, or only that I remove the CC > to stable (and/or Fixes: tag)? Is this something that can't be removed once it's > there, or is the concern about making user-visible changes on stable? Remove the stable tag, if someone is relying on the DSP B support in stable this will break it. --nVMJ2NtxeReIH9PS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5Ly1YACgkQJNaLcl1U h9CFEQf8D9YL5SadnjL9dOFFrzy8yoRe7dCBkHfRxS2YavdoyZPsbCrDOcY93rEL /VkLJwslj6K1LCmAYYJ4/Qo+q+hPV2bnnzcslJD4Mk19RhLuBbLR8/kfP0mgnlb4 igA2RgQJlN1GubExF4orNfkGrQxaTORV9EmceHayvRL232NkBdwGqu6wcG4Gk3YR dA0GaD0uBoCMBucCRvveNRdwJAD9aStpZZwC2Qb4Iv3lMAD6do8XCz99kT+ptlFs 8N/oDBbmQpwJTkXmTphUhhkCkxA/bMZMw8QxPHZnG5SuemVyfYJ/WYevARSnpaTp zPxaVojES71xzKzOJUh3NURlUBhKcg== =Hx/L -----END PGP SIGNATURE----- --nVMJ2NtxeReIH9PS-- --===============7868770511427576495== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7868770511427576495==--