From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB2E86E2BC for ; Tue, 18 Feb 2020 12:27:08 +0000 (UTC) From: Chris Wilson Date: Tue, 18 Feb 2020 12:26:48 +0000 Message-Id: <20200218122648.1252102-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Subject: [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Exercise implicit ordering between engines List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: intel-gfx@lists.freedsktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Check that reads are serialised after a write, and that a subsequent write is after all reads. Signed-off-by: Chris Wilson Cc: Antonio Argenziano Cc: Sravan Kumar Nedunoori --- tests/i915/gem_exec_schedule.c | 67 ++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c index a20985864..ff41551d0 100644 --- a/tests/i915/gem_exec_schedule.c +++ b/tests/i915/gem_exec_schedule.c @@ -241,6 +241,55 @@ static void fifo(int fd, unsigned ring) igt_assert_eq_u32(result, 2); } +enum implicit_dir { + READ_WRITE = 0x1, + WRITE_READ = 0x2, +}; + +static void implicit_rw(int i915, unsigned ring, enum implicit_dir dir) +{ + IGT_CORK_FENCE(cork); + unsigned int count; + uint32_t scratch; + uint32_t result; + int fence; + + count = 0; + for_each_physical_engine(other, i915) { + if (eb_ring(other) == ring) + continue; + + count++; + } + igt_require(count); + + scratch = gem_create(i915, 4096); + fence = igt_cork_plug(&cork, i915); + + if (dir & WRITE_READ) + store_dword_fenced(i915, 0, ring, scratch, 0, -ring, fence, I915_GEM_DOMAIN_RENDER); + + for_each_physical_engine(other, i915) { + if (eb_ring(other) == ring) + continue; + + store_dword_fenced(i915, 0, ring, scratch, 0, eb_ring(other), fence, 0); + } + + if (dir & READ_WRITE) + store_dword_fenced(i915, 0, ring, scratch, 0, ring, fence, I915_GEM_DOMAIN_RENDER); + + unplug_show_queue(i915, &cork, ring); + close(fence); + + result = __sync_read_u32(i915, scratch, 0); + gem_close(i915, scratch); + + igt_assert_neq_u32(result, -ring); + if (dir & READ_WRITE) + igt_assert_eq_u32(result, ring); +} + static void independent(int fd, unsigned int engine) { IGT_CORK_FENCE(cork); @@ -2042,6 +2091,24 @@ igt_main fifo(fd, eb_ring(e)); } + igt_subtest_f("implicit-read-write-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), READ_WRITE); + } + + igt_subtest_f("implicit-write-read-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), WRITE_READ); + } + + igt_subtest_f("implicit-both-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), READ_WRITE | WRITE_READ); + } + igt_subtest_f("independent-%s", e->name) { igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); igt_require(gem_can_store_dword(fd, eb_ring(e))); -- 2.25.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev