From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF6F9C3404D for ; Wed, 19 Feb 2020 00:58:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 978A82173E for ; Wed, 19 Feb 2020 00:58:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ih0TjNY9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727208AbgBSA63 (ORCPT ); Tue, 18 Feb 2020 19:58:29 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:34652 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbgBSA62 (ORCPT ); Tue, 18 Feb 2020 19:58:28 -0500 Received: by mail-pf1-f195.google.com with SMTP id i6so11600993pfc.1 for ; Tue, 18 Feb 2020 16:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iSZk69ptAiTyf7jpHNkoClrlGQ6cnI+6Xpj9dCGMjN0=; b=Ih0TjNY9842AqcuQgmoScvFqrmIbnDcyT2G+Zz4H7cAxEjHt0DyfSoOYIn774f5oXB 7N482BmqyEb+fPQ62sT9IirOQ1sOWGAEpZc/b9h9LQ9qxLL2Xkg18FgiTMcYoMsUYOV1 Agml5+hejGispc0IEUqgulEwAitKHdS/jC2J0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iSZk69ptAiTyf7jpHNkoClrlGQ6cnI+6Xpj9dCGMjN0=; b=pfldqUK5SlUyvuNH5F+z59EzJ8yoAKwi3ufP8H7VV4koOf5kZw6S5Fv9U45Ibk65br 5vK7myja2qVT2j10EhfBKD9AOtOntmyUoJo5cVOzSXWv5aqvpOPEnQFLzThxrlnJ8jZO bRisj0W2E8BzsHQo8Zd18L1ae+Nr3amR9CoxxDXnfUnSA/L32//TRAhp8T1XLw00s46p HcPqQGTQFr1NtKM2HBagTnN2SMNY2/X9PAn70RICnWxOGACK6abDQWRy/0LyBWhOyuR1 3QFvgGB8QnAHAueA7IA8YzgcnTg3yDaFDtUU7E1diKdnxZhEiKm2aC2Yj9F9N37m0T4L 9G0g== X-Gm-Message-State: APjAAAVTQT29fDQLFdiK+vqg1hAdeMHzIpqDF2ebJGXG+pSba0QixfCX KoCO3gqnkwTzwOjD1vnGArmvJg== X-Google-Smtp-Source: APXvYqwMB+TjIkvXxWZ6X+9g5aGFD1+V5OiJ0ztLwJPySi7aV3TrAhaznYiFLVqLpiYGnEPzwM+MEA== X-Received: by 2002:aa7:9aa5:: with SMTP id x5mr24532698pfi.131.1582073906946; Tue, 18 Feb 2020 16:58:26 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 4sm213446pfn.90.2020.02.18.16.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 16:58:25 -0800 (PST) Date: Tue, 18 Feb 2020 16:58:25 -0800 From: Kees Cook To: Sami Tolvanen Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Mark Rutland , james.morse@arm.com, Dave Martin , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 09/12] arm64: disable SCS for hypervisor code Message-ID: <202002181658.41FA7C514E@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20200219000817.195049-1-samitolvanen@google.com> <20200219000817.195049-10-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219000817.195049-10-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 18, 2020 at 04:08:14PM -0800, Sami Tolvanen wrote: > Disable SCS for code that runs at a different exception level by > adding __noscs to __hyp_text. > > Suggested-by: James Morse > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -Kees > --- > arch/arm64/include/asm/kvm_hyp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/kvm_hyp.h b/arch/arm64/include/asm/kvm_hyp.h > index a3a6a2ba9a63..0f0603f55ea0 100644 > --- a/arch/arm64/include/asm/kvm_hyp.h > +++ b/arch/arm64/include/asm/kvm_hyp.h > @@ -13,7 +13,7 @@ > #include > #include > > -#define __hyp_text __section(.hyp.text) notrace > +#define __hyp_text __section(.hyp.text) notrace __noscs > > #define read_sysreg_elx(r,nvh,vh) \ > ({ \ > -- > 2.25.0.265.gbab2e86ba0-goog > -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB81C3404C for ; Wed, 19 Feb 2020 00:58:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 573EE2173E for ; Wed, 19 Feb 2020 00:58:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g8+DAjeT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ih0TjNY9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 573EE2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QTI+WrBRX3zPyLmd83yVAsBV1gCTAmfJ91ieeKfnue4=; b=g8+DAjeTO5z634 oeu77GObhb9cw9UlohABvR6nf6y6u14kTG2VgstCTTIE9AjPDVIUn2uiGzQqJ9Vp5Ylg7rTWRUEdQ EyQkEiDFuJhJ57n/Fjgvj6gIgpbJBjDgWj6x0fLk/6DyVNGDKGjkBsu7hbHHI/ETvIFrqPdExU2j2 okNQUJ2yXd9lE1rg2b7t9Lq+dlJwMz1TQf81o7K/HoYxpqEk9yJJKi9AJdzXWSOMPKXTfgM3zZmLI Ke9uc760IxPaZEoSr0WxELWiuaiuzaQ2FC/Nyf08+6LtJ4DIto3ApfkjpnXmzFD+SubXk96V4y4oy WRipjtTYBt/Vvmxq/32w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4DhE-0003CQ-4I; Wed, 19 Feb 2020 00:58:36 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4DhA-0003Bp-Qb for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 00:58:34 +0000 Received: by mail-pg1-x541.google.com with SMTP id y30so202148pga.13 for ; Tue, 18 Feb 2020 16:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iSZk69ptAiTyf7jpHNkoClrlGQ6cnI+6Xpj9dCGMjN0=; b=Ih0TjNY9842AqcuQgmoScvFqrmIbnDcyT2G+Zz4H7cAxEjHt0DyfSoOYIn774f5oXB 7N482BmqyEb+fPQ62sT9IirOQ1sOWGAEpZc/b9h9LQ9qxLL2Xkg18FgiTMcYoMsUYOV1 Agml5+hejGispc0IEUqgulEwAitKHdS/jC2J0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iSZk69ptAiTyf7jpHNkoClrlGQ6cnI+6Xpj9dCGMjN0=; b=aGQkK+XSjJkdaNmrcKIZ+8StiWyBX3CmtvSC7Eusblj72SwjQL5YT5tmGVofzXOBva p7iihjtY6AlJl5kC/urPLQVVu+gZkA5wOIvD5PjMcRnHJ/FOyaG1K6AcPtgsCiI3hawQ pv7erMN5fow/tc8CG3djQhDFu1qhi755gldMIJKzZuxvPJZi2w99rw6VKQ96kDgtNGq8 QXJNqJM+IFP398kjRGTZTtJguHxk6WIKksPhDGhxReoOP2c9Sg10u46bEIfnbLpLKDgO vMm6LnPM7asgjQsj+wxadLHqupGyAqxNNUcezWV705NORfOLTK1SOcqNxExHrdZxzrks TC9Q== X-Gm-Message-State: APjAAAXf3ezkA9tPKM8+UZNT0/1ee8PAPhUR+GLhbVeAHL2roKvsiC6r b5/4RpGLwFcPxVrgmxghkW3z3Q== X-Google-Smtp-Source: APXvYqwMB+TjIkvXxWZ6X+9g5aGFD1+V5OiJ0ztLwJPySi7aV3TrAhaznYiFLVqLpiYGnEPzwM+MEA== X-Received: by 2002:aa7:9aa5:: with SMTP id x5mr24532698pfi.131.1582073906946; Tue, 18 Feb 2020 16:58:26 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 4sm213446pfn.90.2020.02.18.16.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 16:58:25 -0800 (PST) Date: Tue, 18 Feb 2020 16:58:25 -0800 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v8 09/12] arm64: disable SCS for hypervisor code Message-ID: <202002181658.41FA7C514E@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20200219000817.195049-1-samitolvanen@google.com> <20200219000817.195049-10-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200219000817.195049-10-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_165832_886369_E105A591 X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , clang-built-linux@googlegroups.com, Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , Miguel Ojeda , james.morse@arm.com, Masami Hiramatsu , Marc Zyngier , kernel-hardening@lists.openwall.com, Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 18, 2020 at 04:08:14PM -0800, Sami Tolvanen wrote: > Disable SCS for code that runs at a different exception level by > adding __noscs to __hyp_text. > > Suggested-by: James Morse > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -Kees > --- > arch/arm64/include/asm/kvm_hyp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/kvm_hyp.h b/arch/arm64/include/asm/kvm_hyp.h > index a3a6a2ba9a63..0f0603f55ea0 100644 > --- a/arch/arm64/include/asm/kvm_hyp.h > +++ b/arch/arm64/include/asm/kvm_hyp.h > @@ -13,7 +13,7 @@ > #include > #include > > -#define __hyp_text __section(.hyp.text) notrace > +#define __hyp_text __section(.hyp.text) notrace __noscs > > #define read_sysreg_elx(r,nvh,vh) \ > ({ \ > -- > 2.25.0.265.gbab2e86ba0-goog > -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel