From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C6FC34049 for ; Tue, 18 Feb 2020 17:15:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DA87208C4 for ; Tue, 18 Feb 2020 17:15:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QIjdz8QS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727966AbgBRRPB (ORCPT ); Tue, 18 Feb 2020 12:15:01 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:57558 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbgBRRO7 (ORCPT ); Tue, 18 Feb 2020 12:14:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7a7BeuJeRNU5QeUULzHih8KoXjfLOlATiPV+cUmscGw=; b=QIjdz8QSjjIzAMdVllBXV1Ditl VdQfMjoATPnUCECUsv27WHAJ189BzjMml0/WCJWrgl36BxxoeO80uWMODrvi1iZBmsS+hh7dIiy44 b+Zgrd143+f6dmQmLhZQ+FuH9ePMXl2ELA3qXgOzTDtEUEbb60nIa36OV97pUwOYLaeU/LzPg4UzL AJtwyIqOXYgNzO6uGl+GlSImIP5h2zicGElavdnAACUdimW5ZnFJN7jRzb/7V/eo9FMyiywWCQVem YDW+lqCuAVv+D7I4cdz6hEyYPzvN50Daw+JTBPbfKlKtHLSO7rU09izm9Se5yBKKdo+rL7lADysxb DeAvxGgQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j46SU-00038d-O4; Tue, 18 Feb 2020 17:14:54 +0000 Date: Tue, 18 Feb 2020 09:14:54 -0800 From: Christoph Hellwig To: Joerg Roedel Cc: Lu Baolu , David Woodhouse , jroedel@suse.de, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] iommu/vt-d: Add attach_deferred() helper Message-ID: <20200218171454.GA7067@infradead.org> References: <20200217193858.26990-1-joro@8bytes.org> <20200217193858.26990-2-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217193858.26990-2-joro@8bytes.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static bool attach_deferred(struct device *dev) > +{ > + return dev->archdata.iommu == DEFER_DEVICE_DOMAIN_INFO; > +} This is not a very useful helper. > + > /** > * is_downstream_to_pci_bridge - test if a device belongs to the PCI > * sub-hierarchy of a candidate PCI-PCI bridge > @@ -2510,8 +2515,7 @@ struct dmar_domain *find_domain(struct device *dev) > { > struct device_domain_info *info; > > - if (unlikely(dev->archdata.iommu == DEFER_DEVICE_DOMAIN_INFO || > - dev->archdata.iommu == DUMMY_DEVICE_DOMAIN_INFO)) > + if (unlikely(attach_deferred(dev) || iommu_dummy(dev))) > return NULL; I'd rather kill the iommu_dummy helper as well. And IIRC I have an outstanding series somewhere that does just that.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6767C3404F for ; Tue, 18 Feb 2020 17:15:03 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B320D2464E for ; Tue, 18 Feb 2020 17:15:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QIjdz8QS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B320D2464E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 98E28204B7; Tue, 18 Feb 2020 17:15:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4BnzFj4RuHba; Tue, 18 Feb 2020 17:15:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id AE12520489; Tue, 18 Feb 2020 17:15:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A2FB0C08A0; Tue, 18 Feb 2020 17:15:02 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4F1DCC013E for ; Tue, 18 Feb 2020 17:14:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3B9A4204A5 for ; Tue, 18 Feb 2020 17:14:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y65rcg0YfEn1 for ; Tue, 18 Feb 2020 17:14:58 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by silver.osuosl.org (Postfix) with ESMTPS id CB4BF20489 for ; Tue, 18 Feb 2020 17:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7a7BeuJeRNU5QeUULzHih8KoXjfLOlATiPV+cUmscGw=; b=QIjdz8QSjjIzAMdVllBXV1Ditl VdQfMjoATPnUCECUsv27WHAJ189BzjMml0/WCJWrgl36BxxoeO80uWMODrvi1iZBmsS+hh7dIiy44 b+Zgrd143+f6dmQmLhZQ+FuH9ePMXl2ELA3qXgOzTDtEUEbb60nIa36OV97pUwOYLaeU/LzPg4UzL AJtwyIqOXYgNzO6uGl+GlSImIP5h2zicGElavdnAACUdimW5ZnFJN7jRzb/7V/eo9FMyiywWCQVem YDW+lqCuAVv+D7I4cdz6hEyYPzvN50Daw+JTBPbfKlKtHLSO7rU09izm9Se5yBKKdo+rL7lADysxb DeAvxGgQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j46SU-00038d-O4; Tue, 18 Feb 2020 17:14:54 +0000 Date: Tue, 18 Feb 2020 09:14:54 -0800 From: Christoph Hellwig To: Joerg Roedel Subject: Re: [PATCH 1/5] iommu/vt-d: Add attach_deferred() helper Message-ID: <20200218171454.GA7067@infradead.org> References: <20200217193858.26990-1-joro@8bytes.org> <20200217193858.26990-2-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200217193858.26990-2-joro@8bytes.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: iommu@lists.linux-foundation.org, jroedel@suse.de, David Woodhouse , linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" > +static bool attach_deferred(struct device *dev) > +{ > + return dev->archdata.iommu == DEFER_DEVICE_DOMAIN_INFO; > +} This is not a very useful helper. > + > /** > * is_downstream_to_pci_bridge - test if a device belongs to the PCI > * sub-hierarchy of a candidate PCI-PCI bridge > @@ -2510,8 +2515,7 @@ struct dmar_domain *find_domain(struct device *dev) > { > struct device_domain_info *info; > > - if (unlikely(dev->archdata.iommu == DEFER_DEVICE_DOMAIN_INFO || > - dev->archdata.iommu == DUMMY_DEVICE_DOMAIN_INFO)) > + if (unlikely(attach_deferred(dev) || iommu_dummy(dev))) > return NULL; I'd rather kill the iommu_dummy helper as well. And IIRC I have an outstanding series somewhere that does just that.. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu